Skip to contentSkip to conversation

ARM: support for the Trusted Foundations secure monitor

PATCH In review Alexandre Courbot 5 participants 19 messages Nov 24, 2013 – Dec 13, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v11 cover ARM: support for the Trusted Foundations secure monitor

New rebase that should be ready-to-apply on the latest Tegra tree. The last remaining blocker is Russell's approval for this series and it is my hope to obtain it with this version.

There has been quite some debate around this series, notably about the SMC calling conventions and whether the firmware interface should be moved out of arch/arm. I hope that all the questions have been answered and that we can move forward with this series that enables NVIDIA-branded retail Tegra devices to run mainline.

Changes since v10:
- Rebased on top of more recent sources since some files have been renamed in mach-tegra.
- Gave a final proof-read and extensive testing.

Alexandre Courbot (7):
ARM: add basic support for Trusted Foundations
of: add vendor prefix for Trusted Logic Mobility
of: add Trusted Foundations bindings documentation
ARM: tegra: add support for Trusted Foundations
ARM: tegra: split setting of CPU reset handler
ARM: tegra: set CPU reset handler using firmware
ARM: tegra: support Trusted Foundations by default

 .../arm/firmware/tlm,trusted-foundations.txt       | 20 ++++++
 Documentation/devicetree/bindings/arm/tegra.txt    |  5 ++
 .../devicetree/bindings/vendor-prefixes.txt        |  1 +
 arch/arm/Kconfig                                   |  2 +
 arch/arm/Makefile                                  |  1 +
 arch/arm/configs/tegra_defconfig                   |  1 +
 arch/arm/firmware/Kconfig                          | 28 ++++++++
 arch/arm/firmware/Makefile                         |  1 +
 arch/arm/firmware/trusted_foundations.c            | 81 ++++++++++++++++++++++
 arch/arm/include/asm/trusted_foundations.h         | 67 ++++++++++++++++++
 arch/arm/mach-tegra/Kconfig                        |  1 +
 arch/arm/mach-tegra/reset.c                        | 40 ++++++++---
 arch/arm/mach-tegra/tegra.c                        |  2 +
 13 files changed, 239 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
 create mode 100644 arch/arm/firmware/Kconfig
 create mode 100644 arch/arm/firmware/Makefile
 create mode 100644 arch/arm/firmware/trusted_foundations.c
 create mode 100644 arch/arm/include/asm/trusted_foundations.h
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH v11 1/7 ARM: add basic support for Trusted Foundations

Trusted Foundations is a TrustZone-based secure monitor for ARM that can be invoked using the same SMC-based API on supported platforms. This patch adds initial basic support for Trusted Foundations using the ARM firmware API. Current features are limited to the ability to boot secondary processors.

Note: The API followed by Trusted Foundations does *not* follow the SMC calling conventions. It has nothing to do with PSCI neither and is only relevant to devices that use Trusted Foundations (like most Tegra-based retail devices).

---
 arch/arm/Kconfig                           |  2 +
 arch/arm/Makefile                          |  1 +
 arch/arm/firmware/Kconfig                  | 28 +++++++++++
 arch/arm/firmware/Makefile                 |  1 +
 arch/arm/firmware/trusted_foundations.c    | 81 ++++++++++++++++++++++++++++++
 arch/arm/include/asm/trusted_foundations.h | 67 ++++++++++++++++++++++++
 6 files changed, 180 insertions(+)
 create mode 100644 arch/arm/firmware/Kconfig
 create mode 100644 arch/arm/firmware/Makefile
 create mode 100644 arch/arm/firmware/trusted_foundations.c
 create mode 100644 arch/arm/include/asm/trusted_foundations.h
arch/arm/Kconfig +2 -0
index 3d8f0b3..b93bb9c 100644
@@ -1053,6 +1053,8 @@ config ARM_TIMER_SP804
 	select CLKSRC_MMIO
 	select CLKSRC_OF if OF
 
+source "arch/arm/firmware/Kconfig"
+
 source arch/arm/mm/Kconfig
 
 config ARM_NR_BANKS
arch/arm/Makefile +1 -0
index c99b108..2cb05d4 100644
@@ -268,6 +268,7 @@ core-$(CONFIG_KVM_ARM_HOST) 	+= arch/arm/kvm/
 core-y				+= arch/arm/kernel/ arch/arm/mm/ arch/arm/common/
 core-y				+= arch/arm/net/
 core-y				+= arch/arm/crypto/
+core-y				+= arch/arm/firmware/
 core-y				+= $(machdirs) $(platdirs)
 
 drivers-$(CONFIG_OPROFILE)      += arch/arm/oprofile/
arch/arm/firmware/Kconfig new file +28 -0
new file mode 100644
index 0000000..bb00ccf
@@ -0,0 +1,28 @@
+config ARCH_SUPPORTS_FIRMWARE
+	bool
+
+config ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
+	bool
+	select ARCH_SUPPORTS_FIRMWARE
+
+menu "Firmware options"
+	depends on ARCH_SUPPORTS_FIRMWARE
+
+config TRUSTED_FOUNDATIONS
+	bool "Trusted Foundations secure monitor support"
+	depends on ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
+	help
+	  Some devices (including most Tegra-based consumer devices on the
+	  market) are booted with the Trusted Foundations secure monitor
+	  active, requiring some core operations to be performed by the secure
+	  monitor instead of the kernel.
+
+	  This option allows the kernel to invoke the secure monitor whenever
+	  required on devices using Trusted Foundations. See
+	  arch/arm/include/asm/trusted_foundations.h or the
+	  tl,trusted-foundations device tree binding documentation for details
+	  on how to use it.
+
+	  Say n if you don't know what this is about.
+
+endmenu
arch/arm/firmware/Makefile new file +1 -0
new file mode 100644
index 0000000..a71f165
@@ -0,0 +1 @@
+obj-$(CONFIG_TRUSTED_FOUNDATIONS)	+= trusted_foundations.o
arch/arm/firmware/trusted_foundations.c new file +81 -0

81 lines not on this page · raw message

arch/arm/include/asm/trusted_foundations.h new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
1.8.4.2
#2 lore raw

PATCH v11 2/7 of: add vendor prefix for Trusted Logic Mobility

In reply to Alexandre Courbot

Add the "tlm" prefix for Trusted Logic Mobility.

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index e306917..5aa905e 100644
@@ -73,6 +73,7 @@ st	STMicroelectronics
 ste	ST-Ericsson
 stericsson	ST-Ericsson
 ti	Texas Instruments
+tlm	Trusted Logic Mobility
 toshiba	Toshiba Corporation
 toumaz	Toumaz
 v3	V3 Semiconductor
Signature · 1 line
1.8.4.2
#3 lore raw

PATCH v11 3/7 of: add Trusted Foundations bindings documentation

In reply to Alexandre Courbot

Add the Device Tree bindings documentation for the Trusted Foundation secure monitor.

---
 .../arm/firmware/tlm,trusted-foundations.txt         | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt new file +20 -0
new file mode 100644
index 0000000..780d039
@@ -0,0 +1,20 @@
+Trusted Foundations
+-------------------
+
+Boards that use the Trusted Foundations secure monitor can signal its
+presence by declaring a node compatible with "tlm,trusted-foundations"
+under the /firmware/ node
+
+Required properties:
+- compatible: "tlm,trusted-foundations"
+- tlm,version-major: major version number of Trusted Foundations firmware
+- tlm,version-minor: minor version number of Trusted Foundations firmware
+
+Example:
+	firmware {
+		trusted-foundations {
+			compatible = "tlm,trusted-foundations";
+			tlm,version-major = <2>;
+			tlm,version-minor = <8>;
+		};
+	};
Signature · 1 line
1.8.4.2
#4 lore raw

PATCH v11 4/7 ARM: tegra: add support for Trusted Foundations

In reply to Alexandre Courbot

Register the firmware operations for Trusted Foundations if the device tree indicates it is active on the device.

---
 Documentation/devicetree/bindings/arm/tegra.txt | 5 +++++
 arch/arm/mach-tegra/Kconfig                     | 1 +
 arch/arm/mach-tegra/tegra.c                     | 2 ++
 3 files changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/tegra.txt +5 -0
index ed9c853..558ed4b 100644
@@ -32,3 +32,8 @@ board-specific compatible values:
   nvidia,whistler
   toradex,colibri_t20-512
   toradex,iris
+
+Trusted Foundations
+-------------------------------------------
+Tegra supports the Trusted Foundation secure monitor. See the
+"tlm,trusted-foundations" binding's documentation for more details.
arch/arm/mach-tegra/Kconfig +1 -0
index 09e740f..00b85fd 100644
@@ -2,6 +2,7 @@ config ARCH_TEGRA
 	bool "NVIDIA Tegra" if ARCH_MULTI_V7
 	select ARCH_HAS_CPUFREQ
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
 	select ARM_GIC
 	select CLKSRC_MMIO
 	select CLKSRC_OF
arch/arm/mach-tegra/tegra.c +2 -0
index 7336817..09a1f8d 100644
@@ -40,6 +40,7 @@
 #include <asm/mach/arch.h>
 #include <asm/mach/time.h>
 #include <asm/setup.h>
+#include <asm/trusted_foundations.h>
 
 #include "apbio.h"
 #include "board.h"
@@ -90,6 +91,7 @@ static void __init tegra_init_cache(void)
 
 static void __init tegra_init_early(void)
 {
+	of_register_trusted_foundations();
 	tegra_apb_io_init();
 	tegra_init_fuse();
 	tegra_cpu_reset_handler_init();
Signature · 1 line
1.8.4.2
#5 lore raw

PATCH v11 5/7 ARM: tegra: split setting of CPU reset handler

In reply to Alexandre Courbot

Not all Tegra devices can set the CPU reset handler in the same way. In particular, devices using a TrustZone secure monitor cannot set it up directly and need to ask the firmware to do it.

This patch separates the act of setting the reset handler from its preparation, so the former can be implemented in a different way.

---
 arch/arm/mach-tegra/reset.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)
arch/arm/mach-tegra/reset.c +17 -10
index 568f5bb..17c4b6d 100644
@@ -33,26 +33,18 @@
 
 static bool is_enabled;
 
-static void __init tegra_cpu_reset_handler_enable(void)
+static void __init tegra_cpu_reset_handler_set(const u32 reset_address)
 {
-	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
 	void __iomem *evp_cpu_reset =
 		IO_ADDRESS(TEGRA_EXCEPTION_VECTORS_BASE + 0x100);
 	void __iomem *sb_ctrl = IO_ADDRESS(TEGRA_SB_BASE);
 	u32 reg;
 
-	BUG_ON(is_enabled);
-	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
-
-	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
-			tegra_cpu_reset_handler_size);
-
 	/*
 	 * NOTE: This must be the one and only write to the EVP CPU reset
 	 *       vector in the entire system.
 	 */
-	writel(TEGRA_IRAM_RESET_BASE + tegra_cpu_reset_handler_offset,
-			evp_cpu_reset);
+	writel(reset_address, evp_cpu_reset);
 	wmb();
 	reg = readl(evp_cpu_reset);
 
@@ -66,6 +58,21 @@ static void __init tegra_cpu_reset_handler_enable(void)
 		writel(reg, sb_ctrl);
 		wmb();
 	}
+}
+
+static void __init tegra_cpu_reset_handler_enable(void)
+{
+	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
+	const u32 reset_address = TEGRA_IRAM_RESET_BASE +
+						tegra_cpu_reset_handler_offset;
+
+	BUG_ON(is_enabled);
+	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
+
+	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
+			tegra_cpu_reset_handler_size);
+
+	tegra_cpu_reset_handler_set(reset_address);
 
 	is_enabled = true;
 }
Signature · 1 line
1.8.4.2
#6 lore raw

PATCH v11 6/7 ARM: tegra: set CPU reset handler using firmware

In reply to Alexandre Courbot

Use a firmware operation to set the CPU reset handler and only resort to doing it ourselves if there is none defined.

This supports the booting of secondary CPUs on devices using a TrustZone secure monitor.

---
 arch/arm/mach-tegra/reset.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
arch/arm/mach-tegra/reset.c +14 -3
index 17c4b6d..146fe8e 100644
@@ -21,6 +21,7 @@
 
 #include <asm/cacheflush.h>
 #include <asm/hardware/cache-l2x0.h>
+#include <asm/firmware.h>
 
 #include "iomap.h"
 #include "irammap.h"
@@ -65,6 +66,7 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
 	const u32 reset_address = TEGRA_IRAM_RESET_BASE +
 						tegra_cpu_reset_handler_offset;
+	int err;
 
 	BUG_ON(is_enabled);
 	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
@@ -72,9 +74,18 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
 			tegra_cpu_reset_handler_size);
 
-	tegra_cpu_reset_handler_set(reset_address);
-
-	is_enabled = true;
+	err = call_firmware_op(set_cpu_boot_addr, 0, reset_address);
+	switch (err) {
+	case -ENOSYS:
+		tegra_cpu_reset_handler_set(reset_address);
+		/* pass-through */
+	case 0:
+		is_enabled = true;
+		break;
+	default:
+		pr_crit("Cannot set CPU reset handler: %d\n", err);
+		BUG();
+	}
 }
 
 void __init tegra_cpu_reset_handler_init(void)
Signature · 1 line
1.8.4.2
#7 lore raw

PATCH v11 7/7 ARM: tegra: support Trusted Foundations by default

In reply to Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/tegra_defconfig +1 -0
index 4934295..da753e3 100644
@@ -33,6 +33,7 @@ CONFIG_PCI=y
 CONFIG_PCI_MSI=y
 CONFIG_PCI_TEGRA=y
 CONFIG_PCIEPORTBUS=y
+CONFIG_TRUSTED_FOUNDATIONS=y
 CONFIG_SMP=y
 CONFIG_PREEMPT=y
 CONFIG_AEABI=y
Signature · 1 line
1.8.4.2
#8 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

-Olof

#9 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 11 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 2 lines

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Will do.

Thanks,
Alex.

#10 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 12 lines · Alexandre Courbot
Quoted 11 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 2 lines

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Will do.

Should it just be default y if one of the relevant CONFIG_ARCH_TEGRA_*_SOC is selected?

That way, it's automatically included if relevant, and automatically excluded if not -- regardless of whether the kernel is multiplatform or not.

Cheers
---Dave

#11 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 16 lines · Dave Martin
Quoted 15 lines · Alexandre Courbot
Quoted 13 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Quoted 8 lines
Quoted 1 line

Will do.

Should it just be default y if one of the relevant CONFIG_ARCH_TEGRA_*_SOC is selected?

That way, it's automatically included if relevant, and automatically excluded if not -- regardless of whether the kernel is multiplatform or not.

So basically, that would mean setting the default to 'y' since the option is not available unless a supported platform is included?

I'm fine this way too, if Stephen also agrees.

#12 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 22 lines · Alexandre Courbot
Quoted 21 lines · Dave Martin
Quoted 12 lines · Alexandre Courbot
Quoted 11 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 2 lines

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Will do.

Should it just be default y if one of the relevant CONFIG_ARCH_TEGRA_*_SOC is selected?

Quoted 8 lines
Quoted 3 lines

That way, it's automatically included if relevant, and automatically excluded if not -- regardless of whether the kernel is multiplatform or not.

So basically, that would mean setting the default to 'y' since the option is not available unless a supported platform is included?

I'm fine this way too, if Stephen also agrees.

Fine by me.

#13 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 27 lines · Stephen Warren
Quoted 26 lines · Alexandre Courbot
Quoted 24 lines · Dave Martin
Quoted 12 lines · Alexandre Courbot
Quoted 11 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 2 lines

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Will do.

Should it just be default y if one of the relevant CONFIG_ARCH_TEGRA_*_SOC is selected?

That way, it's automatically included if relevant, and automatically excluded if not -- regardless of whether the kernel is multiplatform or not.

Quoted 6 lines
Quoted 4 lines

So basically, that would mean setting the default to 'y' since the option is not available unless a supported platform is included?

I'm fine this way too, if Stephen also agrees.

Fine by me.

Sure, as long as the result is right, that should be fine.

Cheers
---Dave

#14 lore raw

Re: [PATCH v11 7/7] ARM: tegra: support Trusted Foundations by default

Quoted 28 lines · Dave Martin
Quoted 27 lines · Stephen Warren
Quoted 26 lines · Alexandre Courbot
Quoted 24 lines · Dave Martin
Quoted 12 lines · Alexandre Courbot
Quoted 11 lines · Olof Johansson
Quoted 9 lines · Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
  arch/arm/configs/tegra_defconfig | 1 +
  1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 2 lines

I think we want this enabled on multi_v7_defconfig too? Send a separate patch for that once this is merged though.

Will do.

Should it just be default y if one of the relevant CONFIG_ARCH_TEGRA_*_SOC is selected?

That way, it's automatically included if relevant, and automatically excluded if not -- regardless of whether the kernel is multiplatform or not.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

So basically, that would mean setting the default to 'y' since the option is not available unless a supported platform is included?

I'm fine this way too, if Stephen also agrees.

Fine by me.

Sure, as long as the result is right, that should be fine.

Ok, then please ignore this patch in this series and I will send a new one that changes the CONFIG_TRUSTED_FOUNDATION's default setting once we have confirmation from Russell that this series can be merged.

Thanks,
Alex.

#15 lore raw
In reply to Alexandre Courbot
Quoted 15 lines · Alexandre Courbot

New rebase that should be ready-to-apply on the latest Tegra tree. The last remaining blocker is Russell's approval for this series and it is my hope to obtain it with this version.

There has been quite some debate around this series, notably about the SMC calling conventions and whether the firmware interface should be moved out of arch/arm. I hope that all the questions have been answered and that we can move forward with this series that enables NVIDIA-branded retail Tegra devices to run mainline.

Changes since v10:
- Rebased on top of more recent sources since some files have been renamed in mach-tegra.
- Gave a final proof-read and extensive testing.

Quoted 8 lines

Alexandre Courbot (7):
ARM: add basic support for Trusted Foundations
of: add vendor prefix for Trusted Logic Mobility
of: add Trusted Foundations bindings documentation
ARM: tegra: add support for Trusted Foundations
ARM: tegra: split setting of CPU reset handler
ARM: tegra: set CPU reset handler using firmware
ARM: tegra: support Trusted Foundations by default

Ok, this looks good to me. Russell, do you want the first patch in your tree or are you ok with acking that and we can take everything through arm-soc?

The alternative is that we can have Stephen provide a stable branch with the first patch on it and we both merge that, then the rest goes on top of that through arm-soc.

Thanks!

-Olof

#16 lore raw
Quoted 25 lines · Olof Johansson
Quoted 15 lines · Alexandre Courbot

New rebase that should be ready-to-apply on the latest Tegra tree. The last remaining blocker is Russell's approval for this series and it is my hope to obtain it with this version.

There has been quite some debate around this series, notably about the SMC calling conventions and whether the firmware interface should be moved out of arch/arm. I hope that all the questions have been answered and that we can move forward with this series that enables NVIDIA-branded retail Tegra devices to run mainline.

Changes since v10:
- Rebased on top of more recent sources since some files have been renamed in mach-tegra.
- Gave a final proof-read and extensive testing.

Quoted 8 lines

Alexandre Courbot (7):
ARM: add basic support for Trusted Foundations
of: add vendor prefix for Trusted Logic Mobility
of: add Trusted Foundations bindings documentation
ARM: tegra: add support for Trusted Foundations
ARM: tegra: split setting of CPU reset handler
ARM: tegra: set CPU reset handler using firmware
ARM: tegra: support Trusted Foundations by default

Quoted 7 lines

Ok, this looks good to me. Russell, do you want the first patch in your tree or are you ok with acking that and we can take everything through arm-soc?

The alternative is that we can have Stephen provide a stable branch with the first patch on it and we both merge that, then the rest goes on top of that through arm-soc.

Russell, ping?

#17 lore raw
Quoted 30 lines · Alexandre Courbot
Quoted 29 lines · Olof Johansson
Quoted 15 lines · Alexandre Courbot

New rebase that should be ready-to-apply on the latest Tegra tree. The last remaining blocker is Russell's approval for this series and it is my hope to obtain it with this version.

There has been quite some debate around this series, notably about the SMC calling conventions and whether the firmware interface should be moved out of arch/arm. I hope that all the questions have been answered and that we can move forward with this series that enables NVIDIA-branded retail Tegra devices to run mainline.

Changes since v10:
- Rebased on top of more recent sources since some files have been renamed in mach-tegra.
- Gave a final proof-read and extensive testing.

Quoted 8 lines

Alexandre Courbot (7):
ARM: add basic support for Trusted Foundations
of: add vendor prefix for Trusted Logic Mobility
of: add Trusted Foundations bindings documentation
ARM: tegra: add support for Trusted Foundations
ARM: tegra: split setting of CPU reset handler
ARM: tegra: set CPU reset handler using firmware
ARM: tegra: support Trusted Foundations by default

Ok, this looks good to me. Russell, do you want the first patch in your tree or are you ok with acking that and we can take everything through arm-soc?

Quoted 5 lines
Quoted 3 lines

The alternative is that we can have Stephen provide a stable branch with the first patch on it and we both merge that, then the rest goes on top of that through arm-soc.

Russell, ping?

Russell, are you OK with this series? If you could ack patch 1, that would be great.

If I don't hear otherwise by Friday, I think the best thing is to merge the whole series through the Tegra tree, although I'll structure it so that patch 1 can be merged into other branches separately if needed.

#18 lore raw
In reply to Alexandre Courbot
Quoted 9 lines · Alexandre Courbot

New rebase that should be ready-to-apply on the latest Tegra tree. The last remaining blocker is Russell's approval for this series and it is my hope to obtain it with this version.

There has been quite some debate around this series, notably about the SMC calling conventions and whether the firmware interface should be moved out of arch/arm. I hope that all the questions have been answered and that we can move forward with this series that enables NVIDIA-branded retail Tegra devices to run mainline.

I have applied this series to Tegra's for-3.14/trusted-foundations branch. This is based directly on v3.13-rc1, so that if anyone needs to merge patch 1 anywhere else to resolve conflicts, it'll be easy. I can create a signed tag for that purpose if required.