Skip to contentSkip to conversation

input: ixp4xx-beeper: don't use symbols from <mach/timex.h>

PATCH New Uwe Kleine-König 2 participants 2 messages Nov 26, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: ixp4xx-beeper: don't use symbols from <mach/timex.h>

mach/timex.h is about to be dropped so don't use symbols defined in there. For ixp4xx there is a suitable substitute for IXP4XX_TIMER_FREQ, i.e. a global and exported variable that holds the same value.

---

Hello,

I'd like to keep that patch in a series for the arm-soc people to pull that get's rid of <mach/timex.h>, so please don't take this patch but only ack to keep coordinating the series as easy as possible.

I don't know who's Ack is good enough to be counted as maintainer ack, so please point that out in your reply, too.

Thanks
Uwe

 drivers/input/misc/ixp4xx-beeper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/ixp4xx-beeper.c +1 -1
index 17ccba8..ed8e5e8 100644
@@ -67,7 +67,7 @@ static int ixp4xx_spkr_event(struct input_dev *dev, unsigned int type, unsigned
 	}
 
 	if (value > 20 && value < 32767)
-		count = (IXP4XX_TIMER_FREQ / (value * 4)) - 1;
+		count = (ixp4xx_timer_freq / (value * 4)) - 1;
 
 	ixp4xx_spkr_control(pin, count);
 
Signature · 1 line
1.8.4.2
maintainer
#1 lore raw

PATCH 1/1 input: ixp4xx-beeper: don't use symbols from <mach/timex.h>

Quoted 5 lines · Uwe Kleine-K?nig

mach/timex.h is about to be dropped so don't use symbols defined in there. For ixp4xx there is a suitable substitute for IXP4XX_TIMER_FREQ, i.e. a global and exported variable that holds the same value.

Please feel free to merge through soc tree.

Quoted 33 lines

---

Hello,

I'd like to keep that patch in a series for the arm-soc people to pull that get's rid of <mach/timex.h>, so please don't take this patch but only ack to keep coordinating the series as easy as possible.

I don't know who's Ack is good enough to be counted as maintainer ack, so please point that out in your reply, too.

Thanks
Uwe

 drivers/input/misc/ixp4xx-beeper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/ixp4xx-beeper.c +1 -1
index 17ccba8..ed8e5e8 100644
@@ -67,7 +67,7 @@ static int ixp4xx_spkr_event(struct input_dev *dev, unsigned int type, unsigned
 	}
 
 	if (value > 20 && value < 32767)
-		count = (IXP4XX_TIMER_FREQ / (value * 4)) - 1;
+		count = (ixp4xx_timer_freq / (value * 4)) - 1;
 
 	ixp4xx_spkr_control(pin, count);
 
Signature · 1 line
1.8.4.2
Signature · 1 line
Dmitry