Skip to contentSkip to conversation

Versatile LEDs initialise to off state

PATCH New Russell King - ARM Linux 2 participants 3 messages Nov 26, 2013 – Nov 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Versatile LEDs initialise to off state

There really is no excuse to turn on all 8 LEDs at boot time, such that on the Versatile PB/926 we end up with 6 LEDs on continuously and forever. We're not a christmas decoration!

---
 arch/arm/plat-versatile/leds.c |    4 +-
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-versatile/leds.c +2 -2
index d2490d00b46c..c74aa5707dab 100644
@@ -73,7 +73,7 @@ static int __init versatile_leds_init(void)
 {
 	int i;
 
-	/* All ON */
-	writel(0xff, LEDREG);
+	/* All off */
+	writel(0, LEDREG);
 	for (i = 0; i < ARRAY_SIZE(versatile_leds); i++) {
 		struct versatile_led *led;
#1 lore raw

PATCH 1/1 Versatile LEDs initialise to off state

Quoted 5 lines · Russell King - ARM Linux

There really is no excuse to turn on all 8 LEDs at boot time, such that on the Versatile PB/926 we end up with 6 LEDs on continuously and forever. We're not a christmas decoration!

Do you want me to queue this patch thru ARM SoC or are you taking it through your tree?

Yours,
Linus Walleij

#2 lore raw

PATCH 1/1 Versatile LEDs initialise to off state

Quoted 7 lines · Linus Walleij
Quoted 4 lines · Russell King - ARM Linux

There really is no excuse to turn on all 8 LEDs at boot time, such that on the Versatile PB/926 we end up with 6 LEDs on continuously and forever. We're not a christmas decoration!

Quoted 6 lines
Quoted 1 line

Do you want me to queue this patch thru ARM SoC or are you taking it through your tree?

I don't mind. If you want to queue it please use rmk+kernel in the author address, thanks.