Skip to contentSkip to conversation

libnspr: Add dependency on !BR2_xtensa

PATCH Superseded Baruch Siach 2 participants 4 messages Nov 27, 2013

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libnspr: Add dependency on !BR2_xtensa

From: Chris Zankel <[email protected]>

Xtensa is not yet supported in libnspr. Also add dependencies to libnss, which requires libnspr, and ecryptfs-utils, which requires libnss.

Fixes
http://autobuild.buildroot.net/results/14b/14ba6426edbffa100de924aa69157b3f59368ff2/

[baruch: fix summary, add autobuild referench, add comment dependency]

---
 package/ecryptfs-utils/Config.in | 2 +-
 package/libnspr/Config.in        | 4 ++--
 package/libnss/Config.in         | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
package/ecryptfs-utils/Config.in +1 -1
index 480aedd..4d00069 100644
@@ -6,7 +6,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
 	depends on !BR2_avr32 && !BR2_microblaze # keyutils
 	depends on BR2_LARGEFILE # libnss
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr
-	depends on !BR2_arc # libnss -> libnspr
+	depends on !BR2_arc && !BR2_xtensa # libnss -> libnspr
 	help
 	  eCryptfs is a POSIX-compliant enterprise cryptographic
 	  filesystem for Linux. It is stacked on top of any other
package/libnspr/Config.in +2 -2
index 4ef3a51..a44bf8a 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBNSPR
 	bool "libnspr"
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_arc
+	depends on !BR2_arc && !BR2_xtensa
 	help
 	  NSPR is the Netscape Portable Runtime library which provides
 	  a platform-neutral API for system level and libc like
@@ -12,5 +12,5 @@ config BR2_PACKAGE_LIBNSPR
 	  http://www.mozilla.org/projects/nspr/
 
 comment "libnspr needs a toolchain w/ largefile, threads"
-	depends on !BR2_arc
+	depends on !BR2_arc && !BR2_xtensa
 	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
package/libnss/Config.in +2 -2
index 88b1fde..f0c90ed 100644
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LIBNSS
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
-	depends on !BR2_arc # libnspr
+	depends on !BR2_arc && !BR2_xtensa # libnspr
 	help
 	  Network Security Services (NSS) is a set of libraries designed
 	  to support development of security-enabled client and server
@@ -16,6 +16,6 @@ config BR2_PACKAGE_LIBNSS
 	  http://www.mozilla.org/projects/security/pki/nss/
 
 comment "libnss needs a toolchain w/ largefile, threads"
-	depends on !BR2_arc
+	depends on !BR2_arc && !BR2_xtensa
 	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
 
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH v2 1/1 libnspr: Add dependency on !BR2_xtensa

Dear Baruch Siach,

Quoted 6 lines · Baruch Siach

From: Chris Zankel <[email protected]>

Xtensa is not yet supported in libnspr. Also add dependencies to libnss, which requires libnspr, and ecryptfs-utils, which requires libnss.

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/14b/14ba6426edbffa100de924aa69157b3f59368ff2/

[baruch: fix summary, add autobuild referench, add comment dependency]

Thanks! However, I wonder if it's not actually easier to include a patch to libnspr to add Xtensa support. See
http://patchwork.ozlabs.org/patch/291080/ for a patch that adds NIOS2 support, for example.

That being said, I'm fine with having libnspr disabled on Xtensa, as I don't believe that many people will care about libnspr/libnss/ecryptfs-utils.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 libnspr: Add dependency on !BR2_xtensa

Hi Thomas,

Quoted 12 lines · Thomas Petazzoni
Quoted 11 lines · Baruch Siach

From: Chris Zankel <[email protected]>

Xtensa is not yet supported in libnspr. Also add dependencies to libnss, which requires libnspr, and ecryptfs-utils, which requires libnss.

Fixes
http://autobuild.buildroot.net/results/14b/14ba6426edbffa100de924aa69157b3f59368ff2/

[baruch: fix summary, add autobuild referench, add comment dependency]

Quoted 7 lines
Quoted 2 lines

Thanks! However, I wonder if it's not actually easier to include a patch to libnspr to add Xtensa support. See
http://patchwork.ozlabs.org/patch/291080/ for a patch that adds NIOS2 support, for example.

That would obviously be better, but I can't properly test a patch adding libnspr xtensa support at the moment. Note that xtensa has BE and LE variants, so it's a little more involved that the nios patch.

Quoted 3 lines

That being said, I'm fine with having libnspr disabled on Xtensa, as I don't believe that many people will care about libnspr/libnss/ecryptfs-utils.

It seems like blackfin needs the same treatment
(http://autobuild.buildroot.net/results/dd353703ed94cec48cd126d80cd2f1b039811be4/).

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH v2 1/1 libnspr: Add dependency on !BR2_xtensa

Dear Baruch Siach,

Quoted 9 lines · Baruch Siach
Quoted 4 lines

Thanks! However, I wonder if it's not actually easier to include a patch to libnspr to add Xtensa support. See
http://patchwork.ozlabs.org/patch/291080/ for a patch that adds NIOS2 support, for example.

That would obviously be better, but I can't properly test a patch adding libnspr xtensa support at the moment. Note that xtensa has BE and LE variants, so it's a little more involved that the nios patch.

Quoted 6 lines
Quoted 3 lines

That being said, I'm fine with having libnspr disabled on Xtensa, as I don't believe that many people will care about libnspr/libnss/ecryptfs-utils.

It seems like blackfin needs the same treatment
(http://autobuild.buildroot.net/results/dd353703ed94cec48cd126d80cd2f1b039811be4/).

Ok, then maybe we want something similar to what I've done for Qt:
http://git.buildroot.net/buildroot/commit/package/qt?id=01f99d284fd51bd149e7a92d0e9e7fc368cd0e99.
So a BR2_PACKAGE_LIBNSPR_ARCH_SUPPORTED hidden kconfig knob that is only enabled for those architectures that support nspr. Therefore, when we need to change which architectures are supported by nspr, we don't have to go edit all the reverse dependencies of nspr.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com