tty: atmel_serial: include <mach/hardware.h> explicitly
Subsystems (3)
PATCH 1/1 tty: atmel_serial: include <mach/hardware.h> explicitly
When compiled for at91rm9200 (i.e. ARM) the driver needs among others the symbol AT91RM9200_BASE_US0 which is defined in arch/arm/mach-at91/include/mach/at91rm9200.h. This file is included implicitly via several steps. As ARM's <asm/timex.h> will stop including <mach/hardware.h> later in this series explicitly include <mach/hardware.h>
---
Notes:
Hello,
I want to send this patch as part of a series dropping <mach/timex.h> altogether. So please don't take this patch but only give your Ack if you're OK with me sending this patch via arm-soc.
Thanks
Uwe
drivers/tty/serial/atmel_serial.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/atmel_serial.c +1 -0
@@ -47,6 +47,7 @@#ifdef CONFIG_ARM #include <mach/cpu.h> +#include <mach/hardware.h> #include <asm/gpio.h> #endif
Signature · 1 line
1.8.4.2
PATCH 1/1 tty: atmel_serial: include <mach/hardware.h> explicitly
On 27/11/2013 10:38, Uwe Kleine-K?nig :
Quoted 8 lines
When compiled for at91rm9200 (i.e. ARM) the driver needs among others the symbol
AT91RM9200_BASE_US0which is defined inarch/arm/mach-at91/include/mach/at91rm9200.h. This file is included implicitly via several steps. As ARM's <asm/timex.h> will stop including <mach/hardware.h> later in this series explicitly include <mach/hardware.h>Signed-off-by Uwe Kleine-K?nig <[email protected]>
Uwe, this AT91RM9200_BASE_US0 value is supposed to disappear in 3.14 tanks to a patch from Linus W. ([PATCH v4] ARM/serial: at91: switch atmel serial to use gpiolib) (not in linux-next yet).
So I think that this patch is not needed for 3.14.
Bye,
Quoted 28 lines
---
Notes:
Hello,I want to send this patch as part of a series dropping <
mach/timex.h> altogether. So please don't take this patch but only give your Ack if you're OK with me sending this patch via arm-soc.Thanks
Uwedrivers/tty/serial/atmel_serial.c | 1 + 1 file changed, 1 insertion(+)drivers/tty/serial/atmel_serial.c +1
-0@@ -47,6 +47,7 @@#ifdef CONFIG_ARM #include <mach/cpu.h> +#include <mach/hardware.h> #include <asm/gpio.h> #endif
Signature · 1 line
Nicolas Ferre
PATCH 1/1 tty: atmel_serial: include <mach/hardware.h> explicitly
Quoted 8 lines · Nicolas Ferre
On 27/11/2013 10:38, Uwe Kleine-K?nig :
Quoted 7 lines
When compiled for at91rm9200 (i.e. ARM) the driver needs among others the symbol
AT91RM9200_BASE_US0which is defined inarch/arm/mach-at91/include/mach/at91rm9200.h. This file is included implicitly via several steps. As ARM's <asm/timex.h> will stop including <mach/hardware.h> later in this series explicitly include <mach/hardware.h>
Quoted 7 lines
Quoted 1 line
Signed-off-by Uwe Kleine-K?nig <[email protected]>Uwe, this
AT91RM9200_BASE_US0value is supposed to disappear in 3.14 tanks to a patch from Linus W. ([PATCH v4] ARM/serial: at91: switch atmel serial to use gpiolib) (not in linux-next yet).So I think that this patch is not needed for 3.14.
So I'll keep this patch in my queue for now, but keep an eye on this one. The other symbols were dropped, too?
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 tty: atmel_serial: include <mach/hardware.h> explicitly
Quoted 11 lines · Uwe Kleine-K?nig
Quoted 10 lines · Nicolas Ferre
On 27/11/2013 10:38, Uwe Kleine-K?nig :
Quoted 8 lines
When compiled for at91rm9200 (i.e. ARM) the driver needs among others the symbol
AT91RM9200_BASE_US0which is defined inarch/arm/mach-at91/include/mach/at91rm9200.h. This file is included implicitly via several steps. As ARM's <asm/timex.h> will stop including <mach/hardware.h> later in this series explicitly include <mach/hardware.h>Signed-off-by Uwe Kleine-K?nig <[email protected]>
Quoted 7 lines
Quoted 5 lines
Uwe, this
AT91RM9200_BASE_US0value is supposed to disappear in 3.14 tanks to a patch from Linus W. ([PATCH v4] ARM/serial: at91: switch atmel serial to use gpiolib) (not in linux-next yet).So I think that this patch is not needed for 3.14.
So I'll keep this patch in my queue for now, but keep an eye on this one. The other symbols were dropped, too?
I just verified that Linus W.'s patch is good enough for me.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |