Skip to contentSkip to conversation

drm/sysfs: testing the wrong variable in drm_sysfs_device_add()

PATCH New Dan Carpenter 1 participant 1 message Nov 27, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/sysfs: testing the wrong variable in drm_sysfs_device_add()

There is a typo here so we don't check for allocation failure properly.

Fixes 760c960bd688 ('drm/sysfs: fix hotplug regression since lifetime changes')
drivers/gpu/drm/drm_sysfs.c +1 -1
index bd2bca395792..c22c3097c3e8 100644
@@ -516,7 +516,7 @@ int drm_sysfs_device_add(struct drm_minor *minor)
                 minor_str = "card%d";
 
 	minor->kdev = kzalloc(sizeof(*minor->kdev), GFP_KERNEL);
-	if (!minor->dev) {
+	if (!minor->kdev) {
 		r = -ENOMEM;
 		goto error;
 	}