Skip to contentSkip to conversation

ARM: shmobile: Use SoC suffix for INTC compat string

PATCH New Magnus Damm 2 participants 9 messages Nov 27, 2013 – Dec 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: shmobile: Use SoC suffix for INTC compat string

ARM: shmobile: Use SoC suffix for INTC compat string

[PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string

Update the DTS for INTC irqpin devices to include the SoC in the compat string.

Both IRQC and INTC irqpin need documentation for the DT bindings, and this will happen in incremental patches.

---

Written against renesas.git tag renesas-devel-v3.13-rc1-20131125

 arch/arm/boot/dts/r8a7740.dtsi |    8 ++++----
 arch/arm/boot/dts/r8a7778.dtsi |    2 +-
 arch/arm/boot/dts/r8a7779.dtsi |    2 +-
 arch/arm/boot/dts/sh73a0.dtsi  |    8 ++++----
 4 files changed, 10 insertions(+), 10 deletions(-)
#1 lore raw

PATCH 1/4 ARM: shmobile: Use sh73a0 suffix for INTC compat string

From: Magnus Damm <[email protected]>

Add "renesas,intc-irqpin-sh73a0" to the compatible string for the IRQ pins in case of sh73a0 INTC. This makes the INTC irqpin follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/sh73a0.dtsi |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/sh73a0.dtsi +4 -4
@@ -47,7 +47,7 @@
 	};
 
 	irqpin0: irqpin at e6900000 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900000 4>,
@@ -67,7 +67,7 @@
 	};
 
 	irqpin1: irqpin at e6900004 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900004 4>,
@@ -88,7 +88,7 @@
 	};
 
 	irqpin2: irqpin at e6900008 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900008 4>,
@@ -108,7 +108,7 @@
 	};
 
 	irqpin3: irqpin at e690000c {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe690000c 4>,
#2 lore raw

PATCH 2/4 ARM: shmobile: Use r8a7740 suffix for INTC compat string

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add "renesas,intc-irqpin-r8a7740" to the compatible string for the IRQ pins in case of r8a7740 INTC. This makes the INTC irqpin follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/r8a7740.dtsi |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a7740.dtsi +4 -4
@@ -41,7 +41,7 @@
 
 	/* irqpin0: IRQ0 - IRQ7 */
 	irqpin0: irqpin at e6900000 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900000 4>,
@@ -62,7 +62,7 @@
 
 	/* irqpin1: IRQ8 - IRQ15 */
 	irqpin1: irqpin at e6900004 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900004 4>,
@@ -83,7 +83,7 @@
 
 	/* irqpin2: IRQ16 - IRQ23 */
 	irqpin2: irqpin at e6900008 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe6900008 4>,
@@ -104,7 +104,7 @@
 
 	/* irqpin3: IRQ24 - IRQ31 */
 	irqpin3: irqpin at e690000c {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0xe690000c 4>,
#3 lore raw

PATCH 3/4 ARM: shmobile: Use r8a7778 suffix for INTC compat string

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add "renesas,intc-irqpin-r8a7778" to the compatible string for the IRQ pins in case of r8a7778 INTC. This makes the INTC irqpin follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/r8a7778.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7778.dtsi +1 -1
@@ -43,7 +43,7 @@
 
 	/* irqpin: IRQ0 - IRQ3 */
 	irqpin: irqpin at fe78001c {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7778", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		status = "disabled"; /* default off */
#4 lore raw

PATCH 4/4 ARM: shmobile: Use r8a7779 suffix for INTC compat string

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add "renesas,intc-irqpin-r8a7779" to the compatible string for the IRQ pins in case of r8a7779 INTC. This makes the INTC irqpin follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/r8a7779.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7779.dtsi +1 -1
@@ -135,7 +135,7 @@
 	};
 
 	irqpin0: irqpin at fe780010 {
-		compatible = "renesas,intc-irqpin";
+		compatible = "renesas,intc-irqpin-r8a7779", "renesas,intc-irqpin";
 		#interrupt-cells = <2>;
 		status = "disabled";
 		interrupt-controller;
#5 lore raw

cover ARM: shmobile: Use SoC suffix for INTC compat string

In reply to Magnus Damm
Quoted 11 lines · Magnus Damm

ARM: shmobile: Use SoC suffix for INTC compat string

[PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string

Update the DTS for INTC irqpin devices to include the SoC in the compat string.

Both IRQC and INTC irqpin need documentation for the DT bindings, and this will happen in incremental patches.

I have posted some patches for that a few moments ago :)

I am curious to if it is intentional that this series replaces the use of less-specific compat strings with more specific ones while the recent update to the r8a7790 supplemented the less-specific renesas,irqc comat string with the more-specific renesas,irqc-r8a7790 compat string.

i.e.

	before: "renesas,intc-irqpin"
	after:  "renesas,intc-irqpin-sh73a0"

	as opposed to

	before: "renesas,irqc"
	after: "renesas,irqc-r8a7790", "renesas,irqc"
#6 lore raw

cover ARM: shmobile: Use SoC suffix for INTC compat string

Quoted 8 lines · Simon Horman
Quoted 7 lines · Magnus Damm

ARM: shmobile: Use SoC suffix for INTC compat string

[PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string

Quoted 6 lines
Quoted 4 lines

Update the DTS for INTC irqpin devices to include the SoC in the compat string.

Both IRQC and INTC irqpin need documentation for the DT bindings, and this will happen in incremental patches.

I have posted some patches for that a few moments ago :)

Thanks for that!

Quoted 6 lines

I am curious to if it is intentional that this series replaces the use of less-specific compat strings with more specific ones while the recent update to the r8a7790 supplemented the less-specific renesas,irqc comat string with the more-specific renesas,irqc-r8a7790 compat string.

Quoted 8 lines

i.e.
before: "renesas,intc-irqpin"
after: "renesas,intc-irqpin-sh73a0"

as opposed to

before: "renesas,irqc"
after: "renesas,irqc-r8a7790", "renesas,irqc"

My intention is to keep them the same. I just checked the intc-irqpin patches but they seem to be following the same style as IRQC. On which SoC did you observe this difference?

Thanks,

/ magnus

#7 lore raw

cover ARM: shmobile: Use SoC suffix for INTC compat string

Quoted 28 lines · Magnus Damm
Quoted 8 lines · Simon Horman
Quoted 7 lines · Magnus Damm

ARM: shmobile: Use SoC suffix for INTC compat string

[PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string

Quoted 6 lines
Quoted 4 lines

Update the DTS for INTC irqpin devices to include the SoC in the compat string.

Both IRQC and INTC irqpin need documentation for the DT bindings, and this will happen in incremental patches.

I have posted some patches for that a few moments ago :)

Thanks for that!

Quoted 10 lines

I am curious to if it is intentional that this series replaces the use of less-specific compat strings with more specific ones while the recent update to the r8a7790 supplemented the less-specific renesas,irqc comat string with the more-specific renesas,irqc-r8a7790 compat string.

i.e.
before: "renesas,intc-irqpin"
after: "renesas,intc-irqpin-sh73a0"

Quoted 8 lines
Quoted 4 lines

as opposed to

before: "renesas,irqc"
after: "renesas,irqc-r8a7790", "renesas,irqc"

My intention is to keep them the same. I just checked the intc-irqpin patches but they seem to be following the same style as IRQC. On which SoC did you observe this difference?

Sorry, ignore this. I was confused.

#8 lore raw

cover ARM: shmobile: Use SoC suffix for INTC compat string

Quoted 31 lines · Simon Horman
Quoted 30 lines · Magnus Damm
Quoted 8 lines · Simon Horman
Quoted 7 lines · Magnus Damm

ARM: shmobile: Use SoC suffix for INTC compat string

[PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string

Quoted 6 lines
Quoted 4 lines

Update the DTS for INTC irqpin devices to include the SoC in the compat string.

Both IRQC and INTC irqpin need documentation for the DT bindings, and this will happen in incremental patches.

I have posted some patches for that a few moments ago :)

Thanks for that!

Quoted 12 lines

I am curious to if it is intentional that this series replaces the use of less-specific compat strings with more specific ones while the recent update to the r8a7790 supplemented the less-specific renesas,irqc comat string with the more-specific renesas,irqc-r8a7790 compat string.

i.e.
before: "renesas,intc-irqpin"
after: "renesas,intc-irqpin-sh73a0"

as opposed to

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
        before: "renesas,irqc"
        after: "renesas,irqc-r8a7790", "renesas,irqc"

My intention is to keep them the same. I just checked the intc-irqpin patches but they seem to be following the same style as IRQC. On which SoC did you observe this difference?

Sorry, ignore this. I was confused.

Now that I am not longer confused I will queue up these patches.