Skip to contentSkip to conversation

e2fsprogs: Install libraries to staging

PATCH New Daniel Nyström 5 participants 6 messages Nov 28, 2013 – Jan 22, 2014

lore
Share & tools
lore

Daniel Nyström

author
#0 lore raw

PATCH v2 1/1 e2fsprogs: Install libraries to staging

Signed-off-by Daniel Nystr?m <[email protected]>
---
 package/e2fsprogs/e2fsprogs.mk | 2 ++
 1 file changed, 2 insertions(+)
package/e2fsprogs/e2fsprogs.mk +2 -0
index 0670c74..31e671b 100644
@@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
 E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
 E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
 E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
+E2FSPROGS_INSTALL_STAGING = YES
+E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
 
 E2FSPROGS_CONF_OPT = \
 	--disable-tls \
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH v2 1/1 e2fsprogs: Install libraries to staging

Dear Daniel Nystr?m,

Quoted 10 lines · Daniel Nystr?m
Signed-off-by Daniel Nystr?m <[email protected]>
---
 package/e2fsprogs/e2fsprogs.mk | 2 ++
 1 file changed, 2 insertions(+)
package/e2fsprogs/e2fsprogs.mk +0 -0
index 0670c74..31e671b 100644

package/e2fsprogs/e2fsprogs.mk E2FSPROGS_VERSION = 1.42.8 · line 12

Quoted 5 lines
package/e2fsprogs/e2fsprogs.mk +2 -0
@@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
 E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
 E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
 E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
+E2FSPROGS_INSTALL_STAGING = YES
+E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs

I must say I'd like to know *why* the normal "install" rule does not install the .pc file. It seems to install everything else, including the libraries, but not the .pc file, for some reason.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 e2fsprogs: Install libraries to staging

Quoted 8 lines · Thomas Petazzoni

Dear Daniel Nystr?m,

Quoted 5 lines · Daniel Nystr?m
Signed-off-by Daniel Nystr?m <[email protected]>
---
  package/e2fsprogs/e2fsprogs.mk | 2 ++
  1 file changed, 2 insertions(+)
Quoted 14 lines

package/e2fsprogs/e2fsprogs.mk E2FSPROGS_VERSION = 1.42.8 · line 12

Quoted 10 lines
package/e2fsprogs/e2fsprogs.mk +2 -0
index 0670c74..31e671b 100644
@@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
  E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
  E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
  E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
+E2FSPROGS_INSTALL_STAGING = YES
+E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs

I must say I'd like to know *why* the normal "install" rule does not install the .pc file. It seems to install everything else, including the libraries, but not the .pc file, for some reason.

I would actually prefer an (upstreamable) patch to e2fsprogs that fixes
the install rule, rather than overriding the install commands.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH v2 1/1 e2fsprogs: Install libraries to staging

In reply to Thomas Petazzoni
Quoted 6 lines · Thomas Petazzoni

package/e2fsprogs/e2fsprogs.mk E2FSPROGS_VERSION = 1.42.8 · line 12

Quoted 2 lines
package/e2fsprogs/e2fsprogs.mk +2 -0
+E2FSPROGS_INSTALL_STAGING = YES
+E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs

I must say I'd like to know *why* the normal "install" rule does not install the .pc file. It seems to install everything else, including the libraries, but not the .pc file, for some reason.

Fair enough, when calling install in the toplevel Makefile.in calling install-libs has some conditions:

if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi

Since those directories exist install-libs is never called internally, just install-shlibs-recursive which doesn't install the pc files.

My $.02 guess is that rule was written for e2fsprogs-libs which is the recommended way to get the libs (blkid/et/quota/ss/uuid) since it lacks those directories and has the same condition on the toplevel Makefile.in

It might be worth analyzing if we want to split, some distros do it that way and it would reduce build times a bit in some scenarios.

Regards.