nftables: add slash to chain syntax
RFC PATCH 1/1 nftables: add slash to chain syntax
The current syntax when handling chains seems counterintuitive to me. I would expect that "add chain" would have the name of the chain directly after the keyword "chain". But instead, the name of the table is there, with the chain after. I think a better syntax might be this:
add chain <table>/<chain>
which seems clearer to me. And it has the added benefit of following the "everything is a file" paradigm. Who knows - maybe someday we can add a sysfs interface for nftables, and this will fit nicely within a tree:
nftables
tables
chains
rules
Thoughts? Attached patch is a general proof of concept.
Phil
<v2: attach the patch this time...>
The current syntax when handling chains seems counterintuitive to me. I would expect that "add chain" would have the name of the chain directly after the keyword "chain". But instead, the name of the table is there, with the chain after. I think a better syntax might be this:
add chain <table>/<chain>
which seems clearer to me. And it has the added benefit of following the "everything is a file" paradigm. Who knows - maybe someday we can add a sysfs interface for nftables, and this will fit nicely within a tree:
nftables
tables
chains
rules
Thoughts? Attached patch is a general proof of concept.
Phil
src/parser.y +2 -2
@@ -833,10 +833,10 @@ tables_spec : family_spec } ; -chain_spec : table_spec identifier +chain_spec : table_spec SLASH identifier { $$ = $1; - $$.chain = $2; + $$.chain = $3; } ;
src/scanner.l +1 -1
@@ -111,7 +111,7 @@ decstring {digit}+ hexstring 0[xX]{hexdigit}+ range ({decstring}?:{decstring}?) letter [a-zA-Z] -string ({letter})({letter}|{digit}|[/\-_\.])* +string ({letter})({letter}|{digit}|[\-_\.])* quotedstring \"[^"]*\" comment #.*$ slash \/
Pablo Neira Ayuso
maintainerQuoted 8 lines · Phil Oester
<v2: attach the patch this time...>
The current syntax when handling chains seems counterintuitive to me. I would expect that "add chain" would have the name of the chain directly after the keyword "chain". But instead, the name of the table is there, with the chain after. I think a better syntax might be this:
add chain <table>/<chain>
Frankly, I prefer to leave the syntax as is in that regard.
But there are a couple of syntax aspect that would be worth discussing before this is set in stone, eg. the `=>' in verdict maps.
The > symbol in the bash shell, if not escaped, results in a redirection. We could replace it by ':', so the maps will look like:
add rule ip filter OUTPUT tcp dport vmap { \
22 : jump chain1, \
23 : jump chain2, \
}Just in case we consider it worth to make it easier to run nft commands from the bash shell.
Quoted 10 lines · Pablo Neira Ayuso
The > symbol in the bash shell, if not escaped, results in a redirection. We could replace it by ':', so the maps will look like:
add rule ip filter OUTPUT tcp dport vmap { \
22 : jump chain1, \ 23 : jump chain2, \ }Just in case we consider it worth to make it easier to run nft commands from the bash shell.
I totally like this approach.
Why not to ease the life of bash users? I guess they are many :-)
Signature · 5 lines
Arturo Borrero González -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html