Skip to contentSkip to conversation

serial: lpc32xx: send CR before LF

PATCH In review Vladimir Zapolskiy 4 participants 10 messages Nov 30, 2013 – Dec 16, 2013 Arm/LPC32XX SoC support

lore
Share & tools
lore

Vladimir Zapolskiy

author maintainer
#0 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed. The problem was introduced in e503f90a commit.

---
 drivers/serial/lpc32xx_hsuart.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/serial/lpc32xx_hsuart.c +3 -0
index 9c7c621..c8926a8 100644
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
 static void lpc32xx_serial_putc(const char c)
 {
+	if (c == '\n')
+		serial_putc('\r');
+
 	writel(c, &hsuart->tx);
 
 	/* Wait for character to be sent */
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Quoted 14 lines

The problem was introduced in e503f90a
commit.

---
 drivers/serial/lpc32xx_hsuart.c |    3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c static int lpc32xx_serial_getc(void) · line 46

Quoted 9 lines
drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
 static void lpc32xx_serial_putc(const char c)
 {
+	if (c == '\n')
+		serial_putc('\r');
+
 	writel(c, &hsuart->tx);
 
 	/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

Best regards,
Marek Vasut

author maintainer
#2 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Hi Marek,

Quoted 6 lines · Marek Vasut

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

good question, that's given in experience.

Without CR symbol the output is crumpled:

----8<----
DRAM: 64 MiB
WARNING: Caches not enabled
Flash: 4 MiB
Using default
environment
----8<----

Also note there are similar hooks in several other serial drivers.

Quoted 22 lines
Quoted 22 lines

The problem was introduced in e503f90a
commit.

---
  drivers/serial/lpc32xx_hsuart.c |    3 +++
  1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
  static void lpc32xx_serial_putc(const char c)
  {
+	if (c == '\n')
+		serial_putc('\r');
+
  	writel(c,&hsuart->tx);
 
Quoted 8 lines

drivers/serial/lpc32xx_hsuart.c static int lpc32xx_serial_getc(void) · line 46

Quoted 1 line
drivers/serial/lpc32xx_hsuart.c +0 -0
  	/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

Best regards,
Marek Vasut

With best wishes,
Vladimir

author maintainer
#3 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

In reply to Marek Vasut
Quoted 29 lines · Marek Vasut

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Quoted 22 lines

The problem was introduced in e503f90a
commit.

---
  drivers/serial/lpc32xx_hsuart.c |    3 +++
  1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
  static void lpc32xx_serial_putc(const char c)
  {
+	if (c == '\n')
+		serial_putc('\r');
+
  	writel(c,&hsuart->tx);
 
Quoted 5 lines

drivers/serial/lpc32xx_hsuart.c static int lpc32xx_serial_getc(void) · line 46

Quoted 1 line
drivers/serial/lpc32xx_hsuart.c +0 -0
  	/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

No objections from my side, however it seems that not every particular serial
controller requires such a hook, for code generalization it may be good to have
it for all drivers, but strict enforcement may be redundant for some subset.

Quoted 3 lines

Best regards,
Marek Vasut

With best wishes,
Vladimir

#4 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Dear Vladimir Zapolskiy,

Quoted 39 lines · Marek Vasut
Quoted 30 lines

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Quoted 23 lines

The problem was introduced in e503f90a
commit.

---

  drivers/serial/lpc32xx_hsuart.c |    3 +++
  1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
  static void lpc32xx_serial_putc(const char c)
  {
 
+	if (c == '\n')
+		serial_putc('\r');
+
 
Quoted 7 lines
Quoted 3 lines
drivers/serial/lpc32xx_hsuart.c +0 -0
  	writel(c,&hsuart->tx);

/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

Quoted 6 lines

No objections from my side, however it seems that not every particular serial
controller requires such a hook, for code generalization it may be good to have
it for all drivers, but strict enforcement may be redundant for some subset.

This would need further investigation, very detailed one.

Best regards,
Marek Vasut

author maintainer
#5 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Dear Marek Vasut,

Quoted 41 lines · Marek Vasut

Dear Vladimir Zapolskiy,

Quoted 39 lines · Marek Vasut
Quoted 37 lines

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Quoted 25 lines

The problem was introduced in e503f90a
commit.

---

   drivers/serial/lpc32xx_hsuart.c |    3 +++
   1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
   static void lpc32xx_serial_putc(const char c)
   {
 
+	if (c == '\n')
+		serial_putc('\r');
+
 
   	writel(c,&hsuart->tx);
Quoted 1 line
   	/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

Quoted 8 lines
Quoted 6 lines

No objections from my side, however it seems that not every particular serial
controller requires such a hook, for code generalization it may be good to have
it for all drivers, but strict enforcement may be redundant for some subset.

This would need further investigation, very detailed one.

if you anticipate that such investigation and testing will take significant amount of time, I'd be glad, if you let the regression fix in before doing code generalization.

With best wishes,
Vladimir

#6 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Dear Vladimir Zapolskiy,

Quoted 51 lines

Dear Marek Vasut,

Quoted 48 lines · Marek Vasut

Dear Vladimir Zapolskiy,

Quoted 45 lines · Marek Vasut
Quoted 30 lines

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Quoted 23 lines

The problem was introduced in e503f90a
commit.

---

   drivers/serial/lpc32xx_hsuart.c |    3 +++
   1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/serial/lpc32xx_hsuart.c index 9c7c621..c8926a8 100644

drivers/serial/lpc32xx_hsuart.c +3 -0
@@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)
 
   static void lpc32xx_serial_putc(const char c)
   {
 
+	if (c == '\n')
+		serial_putc('\r');
+
 
Quoted 7 lines
Quoted 3 lines
drivers/serial/lpc32xx_hsuart.c +0 -0
   	writel(c,&hsuart->tx);
   	
   	/* Wait for character to be sent */

btw. I have a feeling each and every driver does send CR-LF combo and emulates it this way. Maybe this should eventually go into common code ? But that's just a suggestion for future improvement.

No objections from my side, however it seems that not every particular serial
controller requires such a hook, for code generalization it may be good to have
it for all drivers, but strict enforcement may be redundant for some subset.

Quoted 5 lines
Quoted 1 line

This would need further investigation, very detailed one.

if you anticipate that such investigation and testing will take significant amount of time, I'd be glad, if you let the regression fix in before doing code generalization.

By all means,

Best regards,
Marek Vasut

#7 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

In reply to Marek Vasut

Dear Marek Vasut,

Quoted 6 lines · In message <[email protected]> you wrote:

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Because we are actually emulating a classical type writer here, and to start printing at the beginning of a new line requires two separate
actions: performing a line feed (i. e. scrolling the paper one line up) and a crriage return (i. e. repositioning the drum such that the next character will be printed in column 1.

In the strict sense, the ASCII characters represent the line feed and '\r' the carriage return, respectively. To print the equivalent of the "new line" as it is interpreted by the C standard, we have to translate the single C character into a two-character sequence. You can trace this back to the very beginnings of Unix; you can see the same in Unix version 6 drivers, for example.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A well-written program is its own heaven; a poorly-written program is
its own hell.             -- Geoffrey James, "The Tao of Programming"
#8 lore raw

PATCH 1/1 serial: lpc32xx: send CR before LF

Dear Wolfgang Denk,

Quoted 16 lines

Dear Marek Vasut,

Quoted 6 lines · In message <[email protected]> you wrote:

Dear Vladimir Zapolskiy,

Quoted 2 lines

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed.

Why ?

Because we are actually emulating a classical type writer here, and to start printing at the beginning of a new line requires two separate
actions: performing a line feed (i. e. scrolling the paper one line up) and a crriage return (i. e. repositioning the drum such that the next character will be printed in column 1.

Quoted 6 lines

In the strict sense, the ASCII characters represent the line feed and '\r' the carriage return, respectively. To print the equivalent of the "new line" as it is interpreted by the C standard, we have to translate the single C character into a two-character sequence. You can trace this back to the very beginnings of Unix; you can see the same in Unix version 6 drivers, for example.

Thanks for such a nice explanations ;-) I still have to wonder, why do we not do this emulation in the serial subsystem core now, but still have such a duplication of code in drivers ? I guess I can answer this myself though:

a) We didn't clean this up, even if we do now have a CONFIG_SERIAL_MULTI enabled by default
b) There might still be people invoking the driver functions directly

There might be even more reasons, but OK, I guess I get it now.

Best regards,
Marek Vasut

#9 lore raw
In reply to Vladimir Zapolskiy
Quoted 7 lines · Vladimir Zapolskiy

For LPC32XX high-speed UART it is required to send a carriage return symbol along with line feed. The problem was introduced in e503f90a commit.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131216/667ec170/attachment.pgp>