Skip to contentSkip to conversation

mfd: pcf50633: Correct device name for pcf50633 regulator

PATCH Applied Axel Lin 3 participants 3 messages Nov 30, 2013 – Dec 2, 2013

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: pcf50633: Correct device name for pcf50633 regulator

Change the device name of the regulator function to the one chosen for MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.

---
Hi,
I don't have the hardware to test, but I think this needs fix.
We have a similar fix in
commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".

 drivers/mfd/pcf50633-core.c            | 2 +-
 drivers/regulator/pcf50633-regulator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/pcf50633-core.c +1 -1
index 6841d68..41ab5e3 100644
@@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
 	for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
 		struct platform_device *pdev;
 
-		pdev = platform_device_alloc("pcf50633-regltr", i);
+		pdev = platform_device_alloc("pcf50633-regulator", i);
 		if (!pdev) {
 			dev_err(pcf->dev, "Cannot create regulator %d\n", i);
 			continue;
drivers/regulator/pcf50633-regulator.c +1 -1
index d7da1c1..134f90e 100644
@@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)
 
 static struct platform_driver pcf50633_regulator_driver = {
 	.driver = {
-		.name = "pcf50633-regltr",
+		.name = "pcf50633-regulator",
 	},
 	.probe = pcf50633_regulator_probe,
 };
Signature · 1 line
1.8.1.2
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Axel Lin

Change the device name of the regulator function to the one chosen for MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.

---
Hi,
I don't have the hardware to test, but I think this needs fix.
We have a similar fix in
commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".

Quoted 3 lines
 drivers/mfd/pcf50633-core.c            | 2 +-
 drivers/regulator/pcf50633-regulator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Patch looks fine to me and I can't fine any other instances of the name.

Quoted 26 lines
drivers/mfd/pcf50633-core.c +1 -1
index 6841d68..41ab5e3 100644
@@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
 	for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
 		struct platform_device *pdev;
 
-		pdev = platform_device_alloc("pcf50633-regltr", i);
+		pdev = platform_device_alloc("pcf50633-regulator", i);
 		if (!pdev) {
 			dev_err(pcf->dev, "Cannot create regulator %d\n", i);
 			continue;
drivers/regulator/pcf50633-regulator.c +1 -1
index d7da1c1..134f90e 100644
@@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)
 
 static struct platform_driver pcf50633_regulator_driver = {
 	.driver = {
-		.name = "pcf50633-regltr",
+		.name = "pcf50633-regulator",
 	},
 	.probe = pcf50633_regulator_probe,
 };
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

Change the device name of the regulator function to the one chosen for MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.

Applied, thanks.