Skip to contentSkip to conversation

toolchain: Allow ld64.so linker

PATCH New Anton Blanchard 2 participants 6 messages Dec 2, 2013 – Dec 3, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

From: Jeremy Kerr <[email protected]>

Expand the glibc dynamic linker check to allow ld64.so.

---

toolchain/helpers.mk +1 -1
index a8944ce..faa9d90 100644
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \
#1 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

Dear Anton Blanchard,

Quoted 3 lines · Anton Blanchard

From: Jeremy Kerr <[email protected]>

Expand the glibc dynamic linker check to allow ld64.so.

Can you add to the commit log the specific toolchain/situation for which this is needed? The external toolchain logic is full of special cases, and I very often read the commit logs to find out why such or such special case was added.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

Hi Thomas,

Quoted 4 lines

Can you add to the commit log the specific toolchain/situation for which this is needed? The external toolchain logic is full of special cases, and I very often read the commit logs to find out why such or such special case was added.

Definitely. How does this look?

--
From: Jeremy Kerr <[email protected]>

The glibc dynamic linkers for ppc64 and s390x are named ld64.so.* so modify the check_glibc check to match them.

---

toolchain/helpers.mk +1 -1
index a8944ce..faa9d90 100644
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \
#3 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

Dear Anton Blanchard,

Quoted 9 lines · Anton Blanchard

Hi Thomas,

Quoted 4 lines

Can you add to the commit log the specific toolchain/situation for which this is needed? The external toolchain logic is full of special cases, and I very often read the commit logs to find out why such or such special case was added.

Definitely. How does this look?

Perfect. Can you just resubmit just the patch (without this discussion above it), so that our patchwork picks up a good version of it, that the BR maintainer can apply?

Also, just curious, are you actually using Buildroot for ppc64 or s390x machines?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

Hi Thomas,

Quoted 3 lines

Perfect. Can you just resubmit just the patch (without this discussion above it), so that our patchwork picks up a good version of it, that the BR maintainer can apply?

Sure, I just resubmitted and it looks to have hit patchwork already.

Quoted 2 lines

Also, just curious, are you actually using Buildroot for ppc64 or s390x machines?

Yes, we used buildroot to bootstrap ppc64le.

Anton

#5 lore raw

PATCH 1/1 toolchain: Allow ld64.so linker

Dear Anton Blanchard,

Quoted 5 lines · Anton Blanchard
Quoted 3 lines

Perfect. Can you just resubmit just the patch (without this discussion above it), so that our patchwork picks up a good version of it, that the BR maintainer can apply?

Sure, I just resubmitted and it looks to have hit patchwork already.

Thanks!

Quoted 4 lines
Quoted 2 lines

Also, just curious, are you actually using Buildroot for ppc64 or s390x machines?

Yes, we used buildroot to bootstrap ppc64le.

Cool. Will you submit other patches to enable ppc64/ppc64le ?

Another question: is it possible to mention under the umbrella of which company this work has been done, in a public way? We're always looking for some good success stories around Buildroot usage.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com