mmc: omap: Fix error introduced by fix to release_mem_region() path
Subsystems (2)
PATCH 1/1 mmc: omap: Fix error introduced by fix to release_mem_region() path
Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of the free_mem_region() error path by reusing the struct resource *res for the DMA resources.
Fix the error the same way omap_hsmmc.c driver handles it, which is to restore the resource before using the values to call release_mem_region().
---
Chris, looks like the patch introducing this error is queued in arm-soc fixes branch.. Care to ack this one too and I'll merge it via arm-soc as well?
After that, no need for me to patch this driver for my mach-omap2 device tree conversion I hope :)
drivers/mmc/host/omap.c +4 -1
@@ -1465,7 +1465,10 @@ err_free_mmc_host: err_ioremap:kfree (host); err_free_mem_region: -release_mem_region (res->start,resource_size (res)); + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (res) +release_mem_region (res->start,resource_size (res)); +return ret; }
Quoted 6 lines · Tony Lindgren
Commit
31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of thefree_mem_region()error path by reusing the struct resource *res for the DMA resources.
Quoted 7 lines
Fix the error the same way
omap_hsmmc.cdriver handles it, which is to restore the resource before using the values to callrelease_mem_region().Reported-by Dan Carpenter <[email protected]>Signed-off-by Tony Lindgren <[email protected]>
I guess my devm_ioremap conversion would have fixed this?
http://www.spinics.net/lists/linux-mmc/msg23317.html
Does not help now but I'm thinking if queuing some of those my patches (3-5) on top of yours as a fix? Especially fix to NULL pointer dereference:
http://www.spinics.net/lists/linux-mmc/msg23320.html
Signature · 1 line
Jarkko
Quoted 11 lines · Jarkko Nikula
Quoted 10 lines · Tony Lindgren
Commit
31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of thefree_mem_region()error path by reusing the struct resource *res for the DMA resources.Fix the error the same way
omap_hsmmc.cdriver handles it, which is to restore the resource before using the values to callrelease_mem_region().
Quoted 6 lines
Quoted 3 lines
Reported-by Dan Carpenter <[email protected]>Signed-off-by Tony Lindgren <[email protected]>I guess my
devm_ioremapconversion would have fixed this?
Probably..
Quoted 4 lines
Does not help now but I'm thinking if queuing some of those my patches (3-5) on top of yours as a fix? Especially fix to NULL pointer dereference:
Yeah please do, how about also adding the error log to the description?
Regards,
Tony
Quoted 13 lines · Tony Lindgren
Commit
31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of thefree_mem_region()error path by reusing the struct resource *res for the DMA resources.Fix the error the same way
omap_hsmmc.cdriver handles it, which is to restore the resource before using the values to callrelease_mem_region().Reported-by Dan Carpenter <[email protected]>Signed-off-by Tony Lindgren <[email protected]>
Quoted 8 lines
---
Chris, looks like the patch introducing this error is queued in arm-soc fixes branch.. Care to ack this one too and I'll merge it via arm-soc as well?
After that, no need for me to patch this driver for my mach-omap2 device tree conversion I hope :)
OK the previous fixes just hit the mainline, no need for me to queue this any longer. Please feel free to pick this one up for the -rc cycle.
Regards,
Tony
Quoted 18 lines
drivers/mmc/host/omap.c +4
-2@@ -1465,7 +1465,10 @@ err_free_mmc_host: err_ioremap:kfree (host); err_free_mem_region: -release_mem_region (res->start,resource_size (res)); + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (res) +release_mem_region (res->start,resource_size (res)); +return ret; } --To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
cover mmc: omap: Fixes, cleanup and add ERASE capability
In reply to Tony LindgrenHi
I've sent these patches earlier to linux-mmc list. This time set is one patch smaller since commit 31ee9181eb92
("mmc: omap: Fix DMA configuration to not rely on device id") does practically same what one of my patch did.
Patch 1 is an obvious fix. 2-4 are preparing for 5 which also should fix the error introduced by 31ee9181eb92:
http://www.spinics.net/lists/linux-omap/msg100790.html
Patch 6 continue cleanup and 7 adds the ERASE capability to the driver so one could utilize discards with mkfs, mount option or with the fstrim.
Set goes on top of v3.13-rc2-208-g8ecffd791448.
Jarkko Nikula (7):
mmc: omap: Fix NULL pointer dereference due uninitialized
cover_tasklet
mmc: omap: Convert to devm_kzalloc
mmc: omap: Remove duplicate host->irq assignment
mmc: omap: Remove mem_res field from struct mmc_omap_host
mmc: omap: Convert to devm_ioremap_resource
mmc: omap: Remove always set use_dma flag from struct mmc_omap_host
mmc: omap: Add erase capability
drivers/mmc/host/omap.c | 93 +++++++++++++++++++------------------------------ 1 file changed, 36 insertions(+), 57 deletions(-)
Signature · 1 line
1.8.4.3
PATCH 1/7 mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet
Omap MMC driver initialization can cause a NULL pointer dereference in tasklet_hi_action on Nokia N810 if its miniSD cover is open during driver initialization.
[ 1.070000] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 1.080000] pgd = c0004000 [ 1.080000] [00000000] *pgd=00000000 [ 1.080000] Internal error: Oops: 80000005 [#1] PREEMPT ARM [ 1.080000] Modules linked in: [ 1.080000] CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 3.13.0-rc2+ #95 [ 1.080000] Workqueue: events menelaus_work [ 1.080000] task: c7863340 ti: c7878000 task.ti: c7878000 [ 1.080000] PC is at 0x0 [ 1.080000] LR is at tasklet_hi_action+0x68/0xa4 ... [ 1.080000] [<c003543c>] (tasklet_hi_action+0x68/0xa4) from [<c0034dd0>] (__do_softirq+0xbc/0x208) [ 1.080000] [<c0034dd0>] (__do_softirq+0xbc/0x208) from [<c003521c>] (irq_exit+0x84/0xac) [ 1.080000] [<c003521c>] (irq_exit+0x84/0xac) from [<c00135cc>] (handle_IRQ+0x64/0x84) [ 1.080000] [<c00135cc>] (handle_IRQ+0x64/0x84) from [<c000859c>] (omap2_intc_handle_irq+0x54/0x68) [ 1.080000] [<c000859c>] (omap2_intc_handle_irq+0x54/0x68) from [<c0015be0>] (__irq_svc+0x40/0x74) [ 1.080000] Exception stack(0xc7879d70 to 0xc7879db8) [ 1.080000] 9d60: 000003f1 0000000a 00000009 0000001c [ 1.080000] 9d80: c7879e70 c780bc10 c780bc10 00000000 00000001 00008603 c780bc78 c7879e4e [ 1.080000] 9da0: 00000002 c7879db8 c00343b0 c0160c9c 20000113 ffffffff [ 1.080000] [<c0015be0>] (__irq_svc+0x40/0x74) from [<c0160c9c>] (__aeabi_uidiv+0x20/0x9c) [ 1.080000] [<c0160c9c>] (__aeabi_uidiv+0x20/0x9c) from [<c00343b0>] (msecs_to_jiffies+0x18/0x24) [ 1.080000] [<c00343b0>] (msecs_to_jiffies+0x18/0x24) from [<c01ec3ec>] (omap_i2c_xfer+0x30c/0x458) [ 1.080000] [<c01ec3ec>] (omap_i2c_xfer+0x30c/0x458) from [<c01e9724>] (__i2c_transfer+0x3c/0x74) [ 1.080000] [<c01e9724>] (__i2c_transfer+0x3c/0x74) from [<c01eac4c>] (i2c_transfer+0x78/0x94) [ 1.080000] [<c01eac4c>] (i2c_transfer+0x78/0x94) from [<c01eb0bc>] (i2c_smbus_xfer+0x3c0/0x4f8) [ 1.080000] [<c01eb0bc>] (i2c_smbus_xfer+0x3c0/0x4f8) from [<c01eb414>] (i2c_smbus_write_byte_data+0x34/0x3c) [ 1.080000] [<c01eb414>] (i2c_smbus_write_byte_data+0x34/0x3c) from [<c01bb308>] (menelaus_write_reg+0x1c/0x40) [ 1.080000] [<c01bb308>] (menelaus_write_reg+0x1c/0x40) from [<c01bb904>] (menelaus_work+0xa0/0xc4) [ 1.080000] [<c01bb904>] (menelaus_work+0xa0/0xc4) from [<c00439c4>] (process_one_work+0x1fc/0x334) [ 1.080000] [<c00439c4>] (process_one_work+0x1fc/0x334) from [<c0043d6c>] (worker_thread+0x244/0x380) [ 1.080000] [<c0043d6c>] (worker_thread+0x244/0x380) from [<c0049d04>] (kthread+0xc0/0xd4) [ 1.080000] [<c0049d04>] (kthread+0xc0/0xd4) from [<c0012758>] (ret_from_fork+0x14/0x3c) [ 1.080000] Code: bad PC value [ 1.090000] ---[ end trace 7bc2fc7cd14f1d95 ]--- [ 1.100000] Kernel panic - not syncing: Fatal exception in interrupt
Reason for this is that omap_notify_cover_event which calls tasklet_hi_schedule gets called before struct cover_tasklet is initialized.
Call to omap_notify_cover_event on Nokia N810 happens from menelaus.c PMIC driver via board-n8x0.c during execution of mmc_add_host in case of open miniSD cover.
Fix this by moving cover_timer and cover_tasklet initialization before mmc_add_host call in mmc_omap_new_slot.
---
v2: a snip of stack dump added to commit log
--- drivers/mmc/host/omap.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/omap.c +7 -5
@@ -1262,6 +1262,13 @@ static int mmc_omap_new_slot(struct mmc_omap_host *host, int id) mmc->max_req_size = mmc->max_blk_size * mmc->max_blk_count; mmc->max_seg_size = mmc->max_req_size; +if (slot->pdata->get_cover_state !=NULL ) { +setup_timer (&slot->cover_timer, mmc_omap_cover_timer, + (unsigned long )slot); +tasklet_init (&slot->cover_tasklet, mmc_omap_cover_handler, + (unsigned long )slot); + } + r =mmc_add_host (mmc);if (r <0 ) goto err_remove_host;
@@ -1278,11 +1285,6 @@ static int mmc_omap_new_slot(struct mmc_omap_host *host, int id) &dev_attr_cover_switch);if (r <0 ) goto err_remove_slot_name; - -setup_timer (&slot->cover_timer, mmc_omap_cover_timer, - (unsigned long )slot); -tasklet_init (&slot->cover_tasklet, mmc_omap_cover_handler, - (unsigned long )slot);tasklet_schedule (&slot->cover_tasklet); }
Signature · 1 line
1.8.4.3
PATCH 2/7 mmc: omap: Convert to devm_kzalloc
In reply to Jarkko Nikula--- drivers/mmc/host/omap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/omap.c +2 -4
@@ -1345,7 +1345,8 @@ static int mmc_omap_probe(struct platform_device *pdev)if (res ==NULL )return -EBUSY ; - host =kzalloc (sizeof (struct mmc_omap_host ),GFP_KERNEL ); + host =devm_kzalloc (&pdev->dev,sizeof (struct mmc_omap_host ), +GFP_KERNEL );if (host ==NULL ) { ret = -ENOMEM ; goto err_free_mem_region;
@@ -1465,7 +1466,6 @@ err_free_iclk: err_free_mmc_host:iounmap (host->virt_base); err_ioremap: -kfree (host); err_free_mem_region:release_mem_region (res->start,resource_size (res));return ret;
@@ -1500,8 +1500,6 @@ static int mmc_omap_remove(struct platform_device *pdev) pdev->resource[0].end - pdev->resource[0].start + 1);destroy_workqueue (host->mmc_omap_wq); -kfree (host); -return 0 ; }
Signature · 1 line
1.8.4.3
PATCH 3/7 mmc: omap: Remove duplicate host->irq assignment
In reply to Jarkko Nikulahost-irq is set twice so remove needless one.
--- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-)
drivers/mmc/host/omap.c +0 -1
@@ -1375,7 +1375,6 @@ static int mmc_omap_probe(struct platform_device *pdev) host->mem_res = res; host->irq = irq; host->use_dma =1 ; - host->irq = irq; host->phys_base = host->mem_res->start; host->virt_base =ioremap (res->start,resource_size (res));if (!host->virt_base)
Signature · 1 line
1.8.4.3
PATCH 4/7 mmc: omap: Remove mem_res field from struct mmc_omap_host
In reply to Jarkko NikulaField mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res.
--- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mmc/host/omap.c +1 -3
@@ -130,7 +130,6 @@ struct mmc_omap_host {u32 dma_rx_burst;struct dma_chan *dma_tx;u32 dma_tx_burst; -struct resource *mem_res;void __iomem *virt_base;unsigned int phys_base;int irq;
@@ -1372,10 +1371,9 @@ static int mmc_omap_probe(struct platform_device *pdev)platform_set_drvdata (pdev, host); host->id = pdev->id; - host->mem_res = res; host->irq = irq; host->use_dma =1 ; - host->phys_base = host->mem_res->start; + host->phys_base = res->start; host->virt_base =ioremap (res->start,resource_size (res));if (!host->virt_base) goto err_ioremap;
Signature · 1 line
1.8.4.3
PATCH 5/7 mmc: omap: Convert to devm_ioremap_resource
In reply to Jarkko NikulaSimplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style.
--- drivers/mmc/host/omap.c | 41 ++++++++++++----------------------------- 1 file changed, 12 insertions(+), 29 deletions(-)
drivers/mmc/host/omap.c +12 -29
@@ -1334,22 +1334,19 @@ static int mmc_omap_probe(struct platform_device *pdev)return -EPROBE_DEFER ; } - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); + host =devm_kzalloc (&pdev->dev,sizeof (struct mmc_omap_host ), +GFP_KERNEL ); +if (host ==NULL ) +return -ENOMEM ; + irq =platform_get_irq (pdev,0 ); -if (res ==NULL || irq <0 ) +if (irq <0 )return -ENXIO ; - res =request_mem_region (res->start,resource_size (res), - pdev->name); -if (res ==NULL ) -return -EBUSY ; - - host =devm_kzalloc (&pdev->dev,sizeof (struct mmc_omap_host ), -GFP_KERNEL ); -if (host ==NULL ) { - ret = -ENOMEM ; - goto err_free_mem_region; - } + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); + host->virt_base =devm_ioremap_resource (&pdev->dev, res); +if (IS_ERR (host->virt_base)) +return PTR_ERR (host->virt_base);INIT_WORK (&host->slot_release_work, mmc_omap_slot_release_work);INIT_WORK (&host->send_stop_work, mmc_omap_send_stop_work);
@@ -1374,15 +1371,9 @@ static int mmc_omap_probe(struct platform_device *pdev) host->irq = irq; host->use_dma =1 ; host->phys_base = res->start; - host->virt_base =ioremap (res->start,resource_size (res)); -if (!host->virt_base) - goto err_ioremap; - host->iclk =clk_get (&pdev->dev,"ick" ); -if (IS_ERR (host->iclk)) { - ret =PTR_ERR (host->iclk); - goto err_free_mmc_host; - } +if (IS_ERR (host->iclk)) +return PTR_ERR (host->iclk);clk_enable (host->iclk); host->fclk =clk_get (&pdev->dev,"fck" );
@@ -1460,11 +1451,6 @@ err_free_dma: err_free_iclk:clk_disable (host->iclk);clk_put (host->iclk); -err_free_mmc_host: -iounmap (host->virt_base); -err_ioremap: -err_free_mem_region: -release_mem_region (res->start,resource_size (res));return ret; }
@@ -1492,9 +1478,6 @@ static int mmc_omap_remove(struct platform_device *pdev)if (host->dma_rx)dma_release_channel (host->dma_rx); -iounmap (host->virt_base); -release_mem_region (pdev->resource[0 ].start, - pdev->resource[0 ].end - pdev->resource[0 ].start +1 );destroy_workqueue (host->mmc_omap_wq);return 0 ;
Signature · 1 line
1.8.4.3
PATCH 6/7 mmc: omap: Remove always set use_dma flag from struct mmc_omap_host
In reply to Jarkko NikulaBecause use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function.
--- drivers/mmc/host/omap.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
drivers/mmc/host/omap.c +5 -10
@@ -152,7 +152,6 @@ struct mmc_omap_host {u32 total_bytes_left;unsigned features; - unsigned use_dma:1; unsigned brs_received:1, dma_done:1; unsigned dma_in_use:1;spinlock_t dma_lock;
@@ -944,7 +943,7 @@ static void mmc_omap_prepare_data(struct mmc_omap_host *host, struct mmc_request *req) { struct mmc_data *data = req->data; -int i, use_dma, block_size; +int i, use_dma =1 , block_size;unsigned sg_len; host->data = data;
@@ -969,13 +968,10 @@ mmc_omap_prepare_data(struct mmc_omap_host *host, struct mmc_request *req) sg_len = (data->blocks ==1 ) ?1 : data->sg_len;/* Only do DMA for entire blocks */ - use_dma = host->use_dma; -if (use_dma) { -for (i =0 ; i < sg_len; i++) { -if ((data->sg[i].length % block_size) !=0 ) { - use_dma =0 ; -break ; - } +for (i =0 ; i < sg_len; i++) { +if ((data->sg[i].length % block_size) !=0 ) { + use_dma =0 ; +break ; } }
@@ -1369,7 +1365,6 @@ static int mmc_omap_probe(struct platform_device *pdev) host->id = pdev->id; host->irq = irq; - host->use_dma =1 ; host->phys_base = res->start; host->iclk =clk_get (&pdev->dev,"ick" );if (IS_ERR (host->iclk))
Signature · 1 line
1.8.4.3
PATCH 7/7 mmc: omap: Add erase capability
In reply to Jarkko NikulaThis patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e ("omap_hsmmc: add erase capability") that we disable the data timeout interrupt for erases.
--- drivers/mmc/host/omap.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/mmc/host/omap.c +11 -7
@@ -26,6 +26,7 @@#include <linux/omap-dma.h> #include <linux/mmc/host.h> #include <linux/mmc/card.h> +#include <linux/mmc/mmc.h> #include <linux/clk.h> #include <linux/scatterlist.h> #include <linux/slab.h>
@@ -336,6 +337,7 @@ mmc_omap_start_command(struct mmc_omap_host *host, struct mmc_command *cmd)u32 cmdreg;u32 resptype;u32 cmdtype; +u16 irq_mask; host->cmd = cmd;
@@ -388,12 +390,14 @@ mmc_omap_start_command(struct mmc_omap_host *host, struct mmc_command *cmd)OMAP_MMC_WRITE (host,CTO ,200 );OMAP_MMC_WRITE (host,ARGL , cmd->arg &0xffff );OMAP_MMC_WRITE (host,ARGH , cmd->arg >>16 ); -OMAP_MMC_WRITE (host,IE , -OMAP_MMC_STAT_A_EMPTY |OMAP_MMC_STAT_A_FULL | -OMAP_MMC_STAT_CMD_CRC |OMAP_MMC_STAT_CMD_TOUT | -OMAP_MMC_STAT_DATA_CRC |OMAP_MMC_STAT_DATA_TOUT | -OMAP_MMC_STAT_END_OF_CMD |OMAP_MMC_STAT_CARD_ERR | -OMAP_MMC_STAT_END_OF_DATA ); + irq_mask =OMAP_MMC_STAT_A_EMPTY |OMAP_MMC_STAT_A_FULL | +OMAP_MMC_STAT_CMD_CRC |OMAP_MMC_STAT_CMD_TOUT | +OMAP_MMC_STAT_DATA_CRC |OMAP_MMC_STAT_DATA_TOUT | +OMAP_MMC_STAT_END_OF_CMD |OMAP_MMC_STAT_CARD_ERR | +OMAP_MMC_STAT_END_OF_DATA ; +if (cmd->opcode ==MMC_ERASE ) + irq_mask &= ~OMAP_MMC_STAT_DATA_TOUT ; +OMAP_MMC_WRITE (host,IE , irq_mask);OMAP_MMC_WRITE (host,CMD , cmdreg); }
@@ -1234,7 +1238,7 @@ static int mmc_omap_new_slot(struct mmc_omap_host *host, int id) mmc->caps =0 ;if (host->pdata->slots[id].wires >=4 ) - mmc->caps |=MMC_CAP_4_BIT_DATA ; + mmc->caps |=MMC_CAP_4_BIT_DATA |MMC_CAP_ERASE ; mmc->ops = &mmc_omap_ops; mmc->f_min =400000 ;
Signature · 1 line
1.8.4.3
Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability
In reply to Jarkko NikulaQuoted 7 lines · Jarkko Nikula
Hi
I've sent these patches earlier to linux-mmc list. This time set is one patch smaller since commit
31ee9181eb92
("mmc: omap: Fix DMA configuration to not rely on device id") does practically same what one of my patch did.
Quoted 8 lines
Patch 1 is an obvious fix. 2-4 are preparing for 5 which also should fix the error introduced by
31ee9181eb92:
http://www.spinics.net/lists/linux-omap/msg100790.htmlPatch 6 continue cleanup and 7 adds the ERASE capability to the driver so one could utilize discards with mkfs, mount option or with the fstrim.
Set goes on top of v3.13-rc2-208-g8ecffd791448.
Great they look good to me:
Quoted 16 lines
Jarkko Nikula (7):
mmc: omap: Fix NULL pointer dereference due uninitialized
cover_tasklet
mmc: omap: Convert todevm_kzalloc
mmc: omap: Remove duplicatehost->irqassignment
mmc: omap: Removemem_resfield from structmmc_omap_host
mmc: omap: Convert todevm_ioremap_resource
mmc: omap: Remove always setuse_dmaflag from structmmc_omap_host
mmc: omap: Add erase capabilitydrivers/mmc/host/omap.c | 93 +++++++++++++++++++------------------------------ 1 file changed, 36 insertions(+), 57 deletions(-)Signature · 1 line
1.8.4.3
Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability
In reply to Jarkko NikulaHi,
Quoted 5 lines · Jarkko Nikula
I've sent these patches earlier to linux-mmc list. This time set is one patch smaller since commit
31ee9181eb92
("mmc: omap: Fix DMA configuration to not rely on device id") does practically same what one of my patch did.
Quoted 8 lines
Patch 1 is an obvious fix. 2-4 are preparing for 5 which also should fix the error introduced by
31ee9181eb92:
http://www.spinics.net/lists/linux-omap/msg100790.htmlPatch 6 continue cleanup and 7 adds the ERASE capability to the driver so one could utilize discards with mkfs, mount option or with the fstrim.
Set goes on top of v3.13-rc2-208-g8ecffd791448.
Patch 5 had some fuzz with plain 3.13-rc2. Otherwise these look fine. I tested these on 770 and N800, so for all patches:
A.
Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability
Quoted 7 lines · Aaro Koskinen
Quoted 1 line
Set goes on top of v3.13-rc2-208-g8ecffd791448.
Patch 5 had some fuzz with plain 3.13-rc2. Otherwise these look fine. I tested these on 770 and N800, so for all patches:
Tested-by Aaro Koskinen <[email protected]>
Yes, reason for your fuzz observation is that 3.13-rc2 don't have those two patches from Tony but 8ecffd791448 had.
Signature · 1 line
Jarkko