xfstests: introduce xfs/324 to verify turn group/project quota off along with fsstress
PATCH 3/3 xfstests: introduce xfs/324 to verify turn group/project quota off along with fsstress
From: Jie Liu <[email protected]>
Introduce xfs/324 to verify that we can turn group/project quotas off while user quota is on and fsstress is running.
--- tests/xfs/324 | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/324.out | 7 +++++ tests/xfs/group | 1 + 3 files changed, 97 insertions(+) create mode 100755 tests/xfs/324 create mode 100644 tests/xfs/324.out
tests/xfs/324 new file +89 -0
@@ -0,0 +1,89 @@ +#! /bin/bash +# FS QA Test No. 324 +# +# Test to verify that turn group/project quotas off while fstress and +# user quotas are left on. +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Oracle, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/quota + +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux + +_require_scratch +_require_xfs_quota +_require_xfs_crc_sb + +_qmount_option "uquota,gquota,pquota" + +STRESS_DIR=$SCRATCH_MNT/testdir + +_exercise() +{ + type=$1 + + _qmount + mkdir -p $STRESS_DIR + + $FSSTRESS_PROG -d $STRESS_DIR -n 100 -p 1000 $FSSTRESS_AVOID >>/dev/null 2>&1 & + + xfs_quota -x -c "off -$type" $SCRATCH_DEV + + killall -q $FSSTRESS_PROG + wait + + rm -rf $STRESS_DIR + umount $SCRATCH_MNT +} + +echo "*** turn off group quotas" +_exercise g +echo "*** done" + +echo "*** turn off project quotas" +_exercise p +echo "*** done" + +echo "*** turn off group/project quotas" +_exercise gp +echo "*** done" + +# success, all done +status=0 +exit
tests/xfs/324.out new file +7 -0
@@ -0,0 +1,7 @@ +QA output created by 324 +*** turn off group quotas +*** done +*** turn off project quotas +*** done +*** turn off group/project quotas +*** done
tests/xfs/group +1 -0
@@ -184,3 +184,4 @@ 302 auto dump 322 auto quick quota 323 auto quick quota +324 auto quota
Signature · 6 lines
1.8.3.2 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Jeff Liu
From: Jie Liu <[email protected]>
Introduce xfs/324 to verify that we can turn group/project quotas off while user quota is on and fsstress is running.
Signed-off-by Jie Liu <[email protected]>
....
tests/xfs/324 line 51
Quoted 8 lines
tests/xfs/324 new file +8
-0+ +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux + +_require_scratch +_require_xfs_quota +_require_xfs_crc_sb
Hmmm, now that I look at the way you are using _require_xfs_crc_sb, it's broken. The scratch device is in an undefined state until a test runs _scratch_mkfs on it.
What you need to do is check whether mkfs supports "-m crc=1", and then mkfs the scratch device with that option set.
tests/xfs/324 line 56
Quoted 5 lines
tests/xfs/324 new file +5
-0+ +_qmount_option "uquota,gquota,pquota" + +STRESS_DIR=$SCRATCH_MNT/testdir +
Where do you mkfs the scratch device?
tests/xfs/324 line 64
Quoted 8 lines
tests/xfs/324 new file +8
-0+_exercise() +{ + type=$1 + + _qmount + mkdir -p $STRESS_DIR + + $FSSTRESS_PROG -d $STRESS_DIR -n 100 -p 1000 $FSSTRESS_AVOID >>/dev/null 2>&1 &
There's no real reason for creating a load of 1000 processes here. Half of them won't even get started before this:
tests/xfs/324 line 66
Quoted 1 line
tests/xfs/324 new file +1
-0+ xfs_quota -x -c "off -$type" $SCRATCH_DEV
is run.
tests/xfs/324 line 69
Quoted 2 lines
tests/xfs/324 new file +2
-0+ killall -q $FSSTRESS_PROG + wait
and then you kill them straight away.
tests/xfs/324 line 72
Quoted 2 lines
tests/xfs/324 new file +2
-0+ rm -rf $STRESS_DIR + umount $SCRATCH_MNT
You don't need this if you just scratch_mkfs the device between tests.
So, wouldn't it be better to do:
scratch_mkfs -m crc=1
_qmount
mkdir -p $STRESS_DIR
$FSSTRESS_PROG -d $STRESS_DIR -n 1000 -p 100 $FSSTRESS_AVOID >>/dev/null 2>&1 & sleep 10
xfs_quota -x -c "off -$type" $SCRATCH_DEV
sleep 5
killall -q $FSSTRESS_PROG
wait
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 21 lines · Dave Chinner
Quoted 6 lines · Jeff Liu
From: Jie Liu <[email protected]>
Introduce xfs/324 to verify that we can turn group/project quotas off while user quota is on and fsstress is running.
Signed-off-by Jie Liu <[email protected]>....
tests/xfs/324 line 51
Quoted 8 lines
tests/xfs/324 new file +8
-0+ +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux + +_require_scratch +_require_xfs_quota +_require_xfs_crc_sbHmmm, now that I look at the way you are using
_require_xfs_crc_sb, it's broken. The scratch device is in an undefined state until a test runs_scratch_mkfson it.
Quoted 2 lines
What you need to do is check whether mkfs supports "-m crc=1", and then mkfs the scratch device with that option set.
Got it.
Quoted 8 lines
tests/xfs/324 line 56
Quoted 6 lines
tests/xfs/324 new file +5
-0+ +_qmount_option "uquota,gquota,pquota" + +STRESS_DIR=$SCRATCH_MNT/testdir +Where do you mkfs the scratch device?
Oops, this problem must be concealed as it has ran against the environment from previous test.
Quoted 30 lines
tests/xfs/324 line 64
Quoted 9 lines
tests/xfs/324 new file +8
-0+_exercise() +{ + type=$1 + + _qmount + mkdir -p $STRESS_DIR + + $FSSTRESS_PROG -d $STRESS_DIR -n 100 -p 1000 $FSSTRESS_AVOID >>/dev/null 2>&1 &There's no real reason for creating a load of 1000 processes here. Half of them won't even get started before this:
tests/xfs/324 line 66
Quoted 1 line
tests/xfs/324 new file +1
-0+ xfs_quota -x -c "off -$type" $SCRATCH_DEVis run.
tests/xfs/324 line 69
Quoted 2 lines
tests/xfs/324 new file +2
-0+ killall -q $FSSTRESS_PROG + waitand then you kill them straight away.
tests/xfs/324 line 72
Quoted 2 lines
tests/xfs/324 new file +2
-0+ rm -rf $STRESS_DIR + umount $SCRATCH_MNTYou don't need this if you just
scratch_mkfsthe device between tests.So, wouldn't it be better to do:
Quoted 9 lines
scratch_mkfs-m crc=1
_qmount
mkdir -p $STRESS_DIR
$FSSTRESS_PROG -d $STRESS_DIR -n 1000 -p 100 $FSSTRESS_AVOID >>/dev/null 2>&1 & sleep 10
xfs_quota-x -c "off -$type" $SCRATCH_DEV
sleep 5
killall -q $FSSTRESS_PROG
wait
Above problems will be fixed in next round of post.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs