arm64: dts: Add a virtio disk to the RTSM motherboard
PATCH 1/1 arm64: dts: Add a virtio disk to the RTSM motherboard
From: Mark Hambleton <[email protected]>
Describe the virtio device so we can mount disk images in the simulator.
--- arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +6 -0
@@ -183,6 +183,12 @@ clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; }; + + virtio_block at 0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x1000>; + interrupts = <0x2a>; + }; }; v2m_fixed_3v3: fixedregulator at 0 {
Signature · 1 line
1.8.4.4
PATCH 1/1 arm64: dts: Add a virtio disk to the RTSM motherboard
Quoted 15 lines · Mark Brown
From: Mark Hambleton <[email protected]>
Describe the virtio device so we can mount disk images in the simulator.
Signed-off-by Mark Hambleton <[email protected]>Signed-off-by Mark Brown <[email protected]>--- arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +0
-0
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 189
Quoted 7 lines
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +4
-0@@ -183,6 +183,12 @@ clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; }; + + virtio_block at 0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x1000>;
4k? That seems pretty big to me...
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 190
Quoted 1 line
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +1
-0+ interrupts = <0x2a>;
Any reason this is in hex?
Will
PATCH 1/1 arm64: dts: Add a virtio disk to the RTSM motherboard
Quoted 7 lines · Will Deacon
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 189
Quoted 3 lines · Mark Brown
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +3
-0+ virtio_block at 0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x1000>;4k? That seems pretty big to me...
Yeah, it looks like a page size to me though it does also seem like the sort of nice round number devices tend to offer. The binding document is depressingly silent on the topic of the size of the region but the only existing in tree user (the ARMv8 foundation model DTS) also picks the same number.
Quoted 3 lines
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 190
Quoted 1 line
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +1
-0+ interrupts = <0x2a>;Any reason this is in hex?
That's what it was in Mark's original patch, easy enough to update.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131203/8335c3c2/attachment-0001.sig>
PATCH 1/1 arm64: dts: Add a virtio disk to the RTSM motherboard
In reply to Will DeaconWill,
This patch comes from the ATF: https://github.com/ARM-software/arm-trusted-firmware/blob/master/fdts/rtsm_ve-motherboard.dtsi
I suspect Achin Gupta has the answers to the questions...
Mark
-----Original Message-----
From: Will Deacon [mailto:will.deacon at arm.com]
Sent: 03 December 2013 11:42
To: Mark Brown
Cc: Catalin Marinas; linaro-kernel at lists.linaro.org; Mark Hambleton; linux-arm-kernel at lists.infradead.org; Mark Brown; mark.rutland at arm.com
Subject: Re: [PATCH] arm64: dts: Add a virtio disk to the RTSM motherboard
Quoted 15 lines · Mark Brown
From: Mark Hambleton <[email protected]>
Describe the virtio device so we can mount disk images in the simulator.
Signed-off-by Mark Hambleton <[email protected]>Signed-off-by Mark Brown <[email protected]>--- arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +0
-0
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 189
Quoted 7 lines
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +4
-0@@ -183,6 +183,12 @@ clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; }; + + virtio_block at 0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x1000>;
4k? That seems pretty big to me...
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi line 190
Quoted 1 line
arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +1
-0+ interrupts = <0x2a>;
Any reason this is in hex?
Will