Skip to contentSkip to conversation

blktrace bno_plot.py: output comprehensive message when gnuplot not found

PATCH Applied Eiichi Tsukata 2 participants 2 messages Dec 3, 2013 – Dec 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blktrace bno_plot.py: output comprehensive message when gnuplot not found

Currently, bno_plot.py uses os.execvp which does not show enough information when executed command is not found. For example, when gnuplot is not found bno_plot.py shows the following messages:

    Traceback (most recent call last):
      File "/usr/local/bin/bno_plot.py", line 123, in <module>
        os.execvp(cmd[0], cmd)
      File "/usr/lib64/python2.7/os.py", line 344, in execvp
        _execvpe(file, args)
      File "/usr/lib64/python2.7/os.py", line 368, in _execvpe
        func(file, *argrest)
    OSError: [Errno 2] No such file or directory

Users can't understand what happend directly from the message.

Instead of os.execvp, this patch uses os.system which shows the following messages when gnuplot not found:

sh: gnuplot: command not found

---
 btt/bno_plot.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
btt/bno_plot.py +2 -3
index 19dfdfd..aa92480 100644
@@ -114,13 +114,12 @@ if __name__ = '__main__':
 
 	pid = os.fork()
 	if pid = 0:
-		cmd = '/usr/bin/gnuplot %s/plot.cmds -' % tmpdir
+		cmd = 'gnuplot %s/plot.cmds -' % tmpdir
 
 		if verbose: print 'Executing %s' % cmd
 
-		cmd = cmd.split(None)
 		os.chdir(tmpdir)
-		os.execvp(cmd[0], cmd)
+		os.system(cmd)
 		sys.exit(1)
 
 	os.waitpid(pid, 0)
Signature · 1 line
1.8.3.1
Applied
#1 lore raw
Quoted 13 lines · Eiichi Tsukata

Currently, bno_plot.py uses os.execvp which does not show enough information when executed command is not found. For example, when gnuplot is not found bno_plot.py shows the following messages:

    Traceback (most recent call last):
      File "/usr/local/bin/bno_plot.py", line 123, in <module>
        os.execvp(cmd[0], cmd)
      File "/usr/lib64/python2.7/os.py", line 344, in execvp
        _execvpe(file, args)
      File "/usr/lib64/python2.7/os.py", line 368, in _execvpe
        func(file, *argrest)
    OSError: [Errno 2] No such file or directory
Quoted 6 lines

Users can't understand what happend directly from the message.

Instead of os.execvp, this patch uses os.system which shows the following messages when gnuplot not found:

sh: gnuplot: command not found

Thanks, applied.

Signature · 1 line
Jens Axboe