usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
PATCH 1/2 usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
From: Daniel Tang <[email protected]>
The SoC name was mistakenly used instead of the vendor name in the device tree binding for nspire-usb.
This patch fixes this before the driver becomes widely adopted.
--- Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++-- drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +2 -2
@@ -1,7 +1,7 @@ * TI-Nspire USB OTG Controller Required properties: -- compatible: Should be "zevio,nspire-usb" +- compatible: Should be "lsi,nspire-usb" - reg: Should contain registers location and length - interrupts: Should contain controller interrupt
@@ -11,7 +11,7 @@ Recommended properies: Examples: usb0: usb@B0000000 { reg = <0xB0000000 0x1000>; - compatible = "zevio,nspire-usb"; + compatible = "lsi,nspire-usb"; interrupts = <8>; vbus-supply = <&vbus_reg>; };
drivers/usb/chipidea/ci_hdrc_nspire.c +1 -1
@@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) }static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { - { .compatible ="zevio,nspire-usb" , }, + { .compatible ="lsi,nspire-usb" , }, {/* sentinel */ } };
Signature · 1 line
1.7.10.4
PATCH 2/2 arm: nspire: modify device tree to use the nspire-usb driver
From: Daniel Tang <[email protected]>
This patch adds the needed compatible key to the device tree for TI-Nspires.
--- arch/arm/boot/dts/nspire.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/nspire.dtsi +1 -0
@@ -65,6 +65,7 @@ }; usb0: usb at B0000000 { + compatible = "lsi,nspire-usb"; reg = <0xB0000000 0x1000>; interrupts = <8>; };
Signature · 1 line
1.7.10.4
Quoted 6 lines · On Wed, Dec 04, 2013 at 09:20:07AM +0000, [email protected] wrote:
From: Daniel Tang <[email protected]>
The SoC name was mistakenly used instead of the vendor name in the device tree binding for nspire-usb.
This patch fixes this before the driver becomes widely adopted.
How widely adopted is it so far?
I can't see the binding in mainline yet.
Quoted 12 lines
Signed-off-by Daniel Tang <[email protected]>--- Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++-- drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +0
-0
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt line 4
Quoted 5 lines
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +1
-1@@ -1,7 +1,7 @@ * TI-Nspire USB OTG Controller Required properties: -- compatible: Should be "zevio,nspire-usb" +- compatible: Should be "lsi,nspire-usb"
Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer binding?
Thanks,
Mark.
Hi,
Quoted 8 lines · Mark Rutland
Quoted 5 lines
Required properties:
-- compatible: Should be "zevio,nspire-usb"
+- compatible: Should be "lsi,nspire-usb"Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer binding?
You're right. I'll fix up the patch and send it back in.
Quoted 3 lines
Thanks,
Mark.
Cheers,
Daniel Tang
Quoted 18 lines · On Wed, Dec 04, 2013 at 08:20:07PM +1100, [email protected] wrote:
From: Daniel Tang <[email protected]>
The SoC name was mistakenly used instead of the vendor name in the device tree binding for nspire-usb.
This patch fixes this before the driver becomes widely adopted.
Signed-off-by Daniel Tang <[email protected]>--- Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++-- drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +0
-0
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt line 4
Quoted 5 lines
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +1
-1@@ -1,7 +1,7 @@ * TI-Nspire USB OTG Controller Required properties: -- compatible: Should be "zevio,nspire-usb" +- compatible: Should be "lsi,nspire-usb"
lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"
Quoted 33 lines
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +1
-1- reg: Should contain registers location and length - interrupts: Should contain controller interrupt@@ -11,7 +11,7 @@ Recommended properies: Examples: usb0: usb@B0000000 { reg = <0xB0000000 0x1000>; - compatible = "zevio,nspire-usb"; + compatible = "lsi,nspire-usb"; interrupts = <8>; vbus-supply = <&vbus_reg>; };drivers/usb/chipidea/ci_hdrc_nspire.c +1
-1@@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) }static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { - { .compatible ="zevio,nspire-usb" , }, + { .compatible ="lsi,nspire-usb" , }, {/* sentinel */ } };Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Best Regards, Peter Chen
Hi,
Quoted 4 lines · Peter Chen
lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"
Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).
Quoted 25 lines
Quoted 25 lines
- reg: Should contain registers location and length
- interrupts: Should contain controller interrupt(quoted diff) +0
-0@@ -11,7 +11,7 @@ Recommended properies:Examples:
usb0: usb@B0000000 { reg = <0xB0000000 0x1000>;Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +1
-1- compatible = "zevio,nspire-usb"; + compatible = "lsi,nspire-usb";interrupts = <8>; vbus-supply = <&vbus_reg>; };drivers/usb/chipidea/ci_hdrc_nspire.c +1
-1@@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) }static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { - { .compatible ="zevio,nspire-usb" , }, + { .compatible ="lsi,nspire-usb" , }, {/* sentinel */ } };
Quoted 14 lines
Quoted 8 lines
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.htmlSignature · 2 lines
Best Regards, Peter Chen
Cheers,
Daniel Tang
Quoted 11 lines · Daniel Tang
Hi,
Quoted 4 lines · Peter Chen
lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
Please wrap the line to 80 characters.
The driver is written for the TI-Nspire, and you port this driver for SoC Zevio platform? Since you use chipidea ip, we don't care the usb module name at your platform, we only care the soc name which you are running, it can detect the SoC platform at runtime.
At your dts patch, it still uses nspire-usb.
http://marc.info/?l=linux-usb&m=138614886720024&w=2
Peter
Quoted 44 lines
If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).
Quoted 25 lines
Quoted 25 lines
- reg: Should contain registers location and length
- interrupts: Should contain controller interrupt(quoted diff) +0
-0@@ -11,7 +11,7 @@ Recommended properies:Examples:
usb0: usb@B0000000 { reg = <0xB0000000 0x1000>;Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +1
-1- compatible = "zevio,nspire-usb"; + compatible = "lsi,nspire-usb";interrupts = <8>; vbus-supply = <&vbus_reg>; };drivers/usb/chipidea/ci_hdrc_nspire.c +1
-1@@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) }static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { - { .compatible ="zevio,nspire-usb" , }, + { .compatible ="lsi,nspire-usb" , }, {/* sentinel */ } };Quoted 14 lines
Quoted 8 lines
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.htmlSignature · 2 lines
Best Regards, Peter ChenCheers,
Daniel Tang
Signature · 2 lines
Best Regards, Peter Chen
Hi,
Quoted 10 lines · Peter Chen
Quoted 9 lines · Daniel Tang
Hi,
Quoted 4 lines · Peter Chen
lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"
Quoted 7 lines
Quoted 2 lines
Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
Please wrap the line to 80 characters.
The driver is written for the TI-Nspire, and you port this driver for SoC Zevio platform?
The TI-Nspire runs on the Zevio SoC.
Quoted 4 lines
Since you use chipidea ip, we don't care the usb
module name at your platform, we only care the soc name which you are running, it can detect the SoC platform at runtime.
Yep, that's why the latest patch I sent in renames the device tree binding to "lsi,zevio-usb" since zevio is the name of the SoC that the TI-Nspire uses.
Quoted 2 lines
At your dts patch, it still uses nspire-usb.
http://marc.info/?l=linux-usb&m=138614886720024&w=2
I'll send a new one in right now.
Quoted 2 lines
Peter
Cheers,
Daniel Tang--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 35 lines
Hi,
Quoted 4 lines · Peter Chen
Quoted 3 lines · Daniel Tang
Hi,
On 05/12/2013, at 12:44 AM, Peter Chen <[email protected]>
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines
lsi is vendor name, what are zevio and nspire? Usually, the compatible string should be "vendor_name,soc_name-
module_name"Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Because this port uses documentation from reverse engineering, it's
difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
Quoted 6 lines
Quoted 1 line
Please wrap the line to 80 characters.
The driver is written for the TI-Nspire, and you port this driver for SoC Zevio platform?
The TI-Nspire runs on the Zevio SoC.
Quoted 4 lines
Since you use chipidea ip, we don't care the usb
module name at your platform, we only care the soc name which you are running, it can detect the SoC platform at runtime.
Quoted 8 lines
Yep, that's why the latest patch I sent in renames the device tree binding to "lsi,zevio-usb" since zevio is the name of the SoC that the TI-Nspire uses.
Quoted 2 lines
At your dts patch, it still uses nspire-usb.
http://marc.info/?l=linux-usb&m=138614886720024&w=2I'll send a new one in right now.
OK, in order to avoid changing name again, I will queue your patch at my pending chipidea tree until your dts has applied by arch or dts maintainer, notify me when they are ready.
Peter