Input: define KEY_WWAN for Wireless WAN
Subsystems (2)
PATCH 1/1 Input: define KEY_WWAN for Wireless WAN
Some devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense to add KEY_WWAN as well.
--- include/uapi/linux/input.h | 2 ++ 1 file changed, 2 insertions(+)
include/uapi/linux/input.h +2 -0
@@ -749,6 +749,8 @@ struct input_keymap_entry {#define BTN_TRIGGER_HAPPY39 0x2e6#define BTN_TRIGGER_HAPPY40 0x2e7 +#define KEY_WWAN 0x2e8/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +/* We avoid low common keys in module aliases so they don't get huge. */ #define KEY_MIN_INTERESTING KEY_MUTE#define KEY_MAX 0x2ff
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov
maintainerHi Rafal,
Quoted 5 lines · Rafał Miłecki
Some devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already haveKEY_BLUETOOTH,KEY_WLANandKEY_UWBso it makes sense to addKEY_WWANas well.
Isn't WiMAX an implementation of WWAN? Maybe instead of adding a new keycode we should use KEY_WIMAX code and alias KEY_WIMAX to KEY_WWAN to preserve ABI?
Thanks.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
2013/12/4 Dmitry Torokhov <[email protected]>:
Quoted 9 lines
Hi Rafal,
Quoted 5 lines · Rafał Miłecki
Some devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already haveKEY_BLUETOOTH,KEY_WLANandKEY_UWBso it makes sense to addKEY_WWANas well.
Quoted 3 lines
Isn't WiMAX an implementation of WWAN? Maybe instead of adding a new keycode we should use
KEY_WIMAXcode and aliasKEY_WIMAXtoKEY_WWANto preserve ABI?
I didn't think about it but if WiMAX is indeed kind of WWAN, it makes a perfect sense to me!
Signature · 5 lines
Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 1/1 Input: define KEY_WWAN for Wireless WAN
In reply to Rafał MiłeckiSome devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense to add KEY_WWAN as well.
As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an alias.
---
V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
--- include/uapi/linux/input.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/linux/input.h +2 -1
@@ -464,7 +464,8 @@ struct input_keymap_entry {#define KEY_BRIGHTNESS_ZERO 244/* brightness off, use ambient */ #define KEY_DISPLAY_OFF 245/* display device to off state */ -#define KEY_WIMAX 246 +#define KEY_WWAN 246/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +#define KEY_WIMAX KEY_WWAN#define KEY_RFKILL 247/* Key that controls all radios */ #define KEY_MICMUTE 248/* Mute / unmute the microphone */
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 20 lines · Rafał Miłecki
Some devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already haveKEY_BLUETOOTH,KEY_WLANandKEY_UWBso it makes sense to addKEY_WWANas well.
As we already haveKEY_WIMAX, use it's value forKEY_WWANand make it an alias.Signed-off-by Rafał Miłecki <[email protected]>---
V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN--- include/uapi/linux/input.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/uapi/linux/input.h +0
-0
include/uapi/linux/input.h struct input_keymap_entry { · line 471
Quoted 9 lines
include/uapi/linux/input.h +2
-1@@ -464,7 +464,8 @@ struct input_keymap_entry {#define KEY_BRIGHTNESS_ZERO 244/* brightness off, use ambient */ #define KEY_DISPLAY_OFF 245/* display device to off state */ -#define KEY_WIMAX 246 +#define KEY_WWAN 246/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +#define KEY_WIMAX KEY_WWAN#define KEY_RFKILL 247/* Key that controls all radios */ #define KEY_MICMUTE 248/* Mute / unmute the microphone */
Adding Dmitry to CC
Signature · 6 lines
Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 25 lines · Jiri Kosina
Quoted 23 lines · Rafał Miłecki
Some devices with support for mobile networks may have buttons for enabling/disabling such connection. An example can be Linksys router 54G3G.
We already haveKEY_BLUETOOTH,KEY_WLANandKEY_UWBso it makes sense to addKEY_WWANas well.
As we already haveKEY_WIMAX, use it's value forKEY_WWANand make it an alias.Signed-off-by Rafał Miłecki <[email protected]>---
V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN--- include/uapi/linux/input.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/uapi/linux/input.h +0
-0@@ -464,7 +464,8 @@ struct input_keymap_entry {#define KEY_BRIGHTNESS_ZERO 244/* brightness off, use ambient */ #define KEY_DISPLAY_OFF 245/* display device to off state */
Quoted 8 lines
include/uapi/linux/input.h struct input_keymap_entry { · line 471
Quoted 6 lines
include/uapi/linux/input.h +2
-1-#define KEY_WIMAX 246 +#define KEY_WWAN 246/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +#define KEY_WIMAX KEY_WWAN#define KEY_RFKILL 247/* Key that controls all radios */ #define KEY_MICMUTE 248/* Mute / unmute the microphone */ Adding Dmitry to CC
Applied, thank you.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html