Skip to contentSkip to conversation

ARM: mx6: Remove the FDT loading address to avoid overlaping

PATCH New Otavio Salvador 4 participants 8 messages Nov 26, 2013 – Dec 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

This patch fixes allow for the DeviceTree and initrd relocation fixing the boot of FSL 3.10.9-1.0.0-alpha kernel.

This changes following boards:

- mx6sabreauto
- mx6sabresd
- wandboard
- udoo
- nitrogen6x
- cgtqmx6eval

The reasoning, as explained by Hui Liu, is:

,----

| The FDT blob will be placed at DDR physical addr: 0x11000000. When Linux kernel
| Boot up, it will decompress the compressed kernel image and place the decompressed
| kernel image at the low end of the DDR memory and start running from it. If the
| decompressed kernel image is bigger for example than 16M, it may over written the
| fdt blob which u-boot loaded to the DDR memory @0x11000000 with fdt_addr=0x11000000
|
| To expand the fdt_addr from 0x11000000 to 0x18000000, which can avoid the override
| Since we will not likely have one kernel image larger than 128MB.

`----

Removing the fdt_high and initrd_high this allows for those to be relocated.

---
 include/configs/cgtqmx6eval.h     | 2 --
 include/configs/mx6sabre_common.h | 2 --
 include/configs/nitrogen6x.h      | 2 --
 include/configs/udoo.h            | 2 --
 include/configs/wandboard.h       | 2 --
 5 files changed, 10 deletions(-)
include/configs/cgtqmx6eval.h +0 -2
index d5db8f5..48acf50 100644
@@ -79,8 +79,6 @@
 	"fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \
 	"boot_dir=/boot\0" \
 	"console=ttymxc1\0" \
-	"fdt_high=0xffffffff\0" \
-	"initrd_high=0xffffffff\0" \
 	"fdt_addr=0x11000000\0" \
 	"boot_fdt=try\0" \
 	"mmcdev=1\0" \
include/configs/mx6sabre_common.h +0 -2
index 4b4f640..01acd7f 100644
@@ -108,8 +108,6 @@
 	"boot_fdt=try\0" \
 	"ip_dyn=yes\0" \
 	"console=" CONFIG_CONSOLE_DEV "\0" \
-	"fdt_high=0xffffffff\0"	  \
-	"initrd_high=0xffffffff\0" \
 	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
 	"mmcpart=1\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
include/configs/nitrogen6x.h +0 -2
index 3df8de0..93c88c9 100644
@@ -186,8 +186,6 @@
 	"script=boot.scr\0" \
 	"uimage=uImage\0" \
 	"console=ttymxc1\0" \
-	"fdt_high=0xffffffff\0" \
-	"initrd_high=0xffffffff\0" \
 	"fdt_file=imx6q-sabrelite.dtb\0" \
 	"fdt_addr=0x11000000\0" \
 	"boot_fdt=try\0" \
include/configs/udoo.h +0 -2
index 78df071..e38a598 100644
@@ -74,8 +74,6 @@
 	"uimage=uImage\0" \
 	"console=ttymxc1\0" \
 	"splashpos=m,m\0" \
-	"fdt_high=0xffffffff\0" \
-	"initrd_high=0xffffffff\0" \
 	"fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \
 	"fdt_addr=0x11000000\0" \
 	"boot_fdt=try\0" \
include/configs/wandboard.h +0 -2
index 68ff724..8d9b5d8 100644
@@ -118,8 +118,6 @@
 	"uimage=uImage\0" \
 	"console=ttymxc0\0" \
 	"splashpos=m,m\0" \
-	"fdt_high=0xffffffff\0" \
-	"initrd_high=0xffffffff\0" \
 	"fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \
 	"fdt_addr=0x11000000\0" \
 	"boot_fdt=try\0" \
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

Quoted 23 lines · Otavio Salvador

This patch fixes allow for the DeviceTree and initrd relocation fixing the boot of FSL 3.10.9-1.0.0-alpha kernel.

This changes following boards:

- mx6sabreauto
- mx6sabresd
- wandboard
- udoo
- nitrogen6x
- cgtqmx6eval

The reasoning, as explained by Hui Liu, is:

,----

| The FDT blob will be placed at DDR physical addr: 0x11000000. When Linux kernel
| Boot up, it will decompress the compressed kernel image and place the decompressed
| kernel image at the low end of the DDR memory and start running from it. If the
| decompressed kernel image is bigger for example than 16M, it may over written the
| fdt blob which u-boot loaded to the DDR memory @0x11000000 with fdt_addr=0x11000000
|
| To expand the fdt_addr from 0x11000000 to 0x18000000, which can avoid the override
| Since we will not likely have one kernel image larger than 128MB.
Quoted 4 lines

`----

Removing the fdt_high and initrd_high this allows for those to be relocated.

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131126/779033ee/attachment.pgp>
#2 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

Quoted 27 lines · Tom Rini
Quoted 25 lines · Otavio Salvador

This patch fixes allow for the DeviceTree and initrd relocation fixing the boot of FSL 3.10.9-1.0.0-alpha kernel.

This changes following boards:

- mx6sabreauto
- mx6sabresd
- wandboard
- udoo
- nitrogen6x
- cgtqmx6eval

The reasoning, as explained by Hui Liu, is:

,----

| The FDT blob will be placed at DDR physical addr: 0x11000000. When Linux kernel
| Boot up, it will decompress the compressed kernel image and place the decompressed
| kernel image at the low end of the DDR memory and start running from it. If the
| decompressed kernel image is bigger for example than 16M, it may over written the
| fdt blob which u-boot loaded to the DDR memory @0x11000000 with fdt_addr=0x11000000
|
| To expand the fdt_addr from 0x11000000 to 0x18000000, which can avoid the override
| Since we will not likely have one kernel image larger than 128MB.

`----

Quoted 6 lines
Quoted 2 lines

Removing the fdt_high and initrd_high this allows for those to be relocated.

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

I didn't catch this case but it is a valid problem, indeed :-(

Fabio/Stefano what is your call here? I think moving it to 128MB is good for now.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

Hi Otavio,

Quoted 5 lines · Otavio Salvador
Quoted 3 lines

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

I didn't catch this case but it is a valid problem, indeed :-(

I missed this issue, too :-(

Does it work with your patch ? Most supported i.MX6 boards have more as 768MB, and I am wondering that all kernels can boot.

Quoted 3 lines

Fabio/Stefano what is your call here? I think moving it to 128MB is good for now.

Yes, it seems this becomes our choice.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

Quoted 11 lines · Stefano Babic

Hi Otavio,

Quoted 5 lines · Otavio Salvador
Quoted 3 lines

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

I didn't catch this case but it is a valid problem, indeed :-(

I missed this issue, too :-(

Quoted 8 lines

Does it work with your patch ? Most supported i.MX6 boards have more as 768MB, and I am wondering that all kernels can boot.

Quoted 3 lines

Fabio/Stefano what is your call here? I think moving it to 128MB is good for now.

Yes, it seems this becomes our choice.

Ok; I will send a new patch later today.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

In reply to Stefano Babic

El Wed, 27 Nov 2013 08:53:55 +0100
Stefano Babic <[email protected]> escribi?:

Quoted 8 lines

Hi Otavio,

Quoted 5 lines · Otavio Salvador
Quoted 4 lines

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

Quoted 6 lines
Quoted 1 line

I didn't catch this case but it is a valid problem, indeed :-(

I missed this issue, too :-(

Does it work with your patch ? Most supported i.MX6 boards have more as 768MB, and I am wondering that all kernels can boot.

In fedora land we have not seen issues booting 3.10 3.11 3.12 or 3.13 in regards to things getting clobbered. but it does bring me back to my thought that u-boot should be calculating where to place everything to ensure that things do not get clobbered.

Most fedora i.MX6 users are using wandboards with a few utilites.

our wandboard config uses

fdt_high=0xffffffff
initrd_high=0xffffffff
fdt_addr=0x11100000
fdt_addr_r=0x11200000
pxefile_addr_r=0x11300000
scr_addr_r=0x11400000
kernel_addr_r=0x11500000
ramdisk_addr_r=0x13500000

I put 32M between the kernel and initramfs which can be wildly variable in size the install version is currently at 27M while our kernel is 4.6M

Dennis

#6 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

Quoted 14 lines · Dennis Gilmore

El Wed, 27 Nov 2013 08:53:55 +0100
Stefano Babic <[email protected]> escribi?:

Quoted 12 lines

Hi Otavio,

Quoted 6 lines · Otavio Salvador
Quoted 4 lines

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

I didn't catch this case but it is a valid problem, indeed :-(

I missed this issue, too :-(

Quoted 7 lines
Quoted 2 lines

Does it work with your patch ? Most supported i.MX6 boards have more as 768MB, and I am wondering that all kernels can boot.

In fedora land we have not seen issues booting 3.10 3.11 3.12 or 3.13 in regards to things getting clobbered. but it does bring me back to my thought that u-boot should be calculating where to place everything to ensure that things do not get clobbered.

I know we talked on IRC yesterday, and this email predates that, but there's a lot of (potential) problems with "oh just let someone else figure out where to place things", such as "what is that thing going to do once it runs" ? I'm fine with (and would encourage) standardized names and a suggested base layout (ie memory base + 0x$FOO for ...)

Quoted 5 lines

Most fedora i.MX6 users are using wandboards with a few utilites.

our wandboard config uses

fdt_high=0xffffffff

Note that this disables relocation of the DT, which is what I was saying is the problem in the original patch, not the location.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131204/05667977/attachment.pgp>
#7 lore raw

PATCH 1/1 ARM: mx6: Remove the FDT loading address to avoid overlaping

In reply to Stefano Babic

El Wed, 27 Nov 2013 08:53:55 +0100
Stefano Babic <[email protected]> escribi?:

Quoted 8 lines

Hi Otavio,

Quoted 5 lines · Otavio Salvador
Quoted 4 lines

I'm going to suggest this is the wrong path. Once you see i.MX systems with > 768MB DDR you're going to have initrd/fdt placed into memory Linux can't access without HIGHMEM on, and you need the FDT before then.

Quoted 6 lines
Quoted 1 line

I didn't catch this case but it is a valid problem, indeed :-(

I missed this issue, too :-(

Does it work with your patch ? Most supported i.MX6 boards have more as 768MB, and I am wondering that all kernels can boot.

In fedora land we have not seen issues booting 3.10 3.11 3.12 or 3.13 in regards to things getting clobbered. but it does bring me back to my thought that u-boot should be calculating where to place everything to ensure that things do not get clobbered.

Most fedora i.MX6 users are using wandboards with a few utilites.

our wandboard config uses

fdt_high=0xffffffff
initrd_high=0xffffffff
fdt_addr=0x11100000
fdt_addr_r=0x11200000
pxefile_addr_r=0x11300000
scr_addr_r=0x11400000
kernel_addr_r=0x11500000
ramdisk_addr_r=0x13500000

I put 32M between the kernel and initramfs which can be wildly variable in size the install version is currently at 27M while our kernel is 4.6M

Dennis