xfs_repair: suggest reboot after dangerous repair
PATCH 1/1 xfs_repair: suggest reboot after dangerous repair
If a "dangerous" repair (repair of a readonly mounted fs) has been done, suggest an immediate reboot upon completion.
---
TBH, I don't know how "dangerous" dangerous is. Is this still required?
repair/xfs_repair.c +5 -0
@@ -884,6 +884,11 @@ _("Note - stripe unit (%d) and width (%d) fields have been reset.\n"if (verbose)summary_report ();do_log (_ ("done\n" )); + +if (dangerously && !no_modify) +do_warn ( +_ ("Repair of readonly mount complete. Immediate reboot encouraged.\n" )); +pftrace_done ();return (0 );
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Eric Sandeen
If a "dangerous" repair (repair of a readonly mounted fs) has been done, suggest an immediate reboot upon completion.
Signed-off-by Eric Sandeen <[email protected]>---
TBH, I don't know how "dangerous" dangerous is. Is this still required?
Was there a crash or something after a repair that led to this patch?
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Ben Myers
Quoted 6 lines · Eric Sandeen
If a "dangerous" repair (repair of a readonly mounted fs) has been done, suggest an immediate reboot upon completion.
Signed-off-by Eric Sandeen <[email protected]>---
Quoted 8 lines
Quoted 2 lines
TBH, I don't know how "dangerous" dangerous is. Is this still required?
Was there a crash or something after a repair that led to this patch?
Reviewed-by Ben Myers <[email protected]>
No, it was generated by a "bug" saying that it was impossible to run fsck.xfs on a root filesystem.
That was largely an RTFM kind of thing but since it's normal for some systems to come up w/ RO-root in rescue mode, and people are used to being able to run e2fsck in that mode, it might be worth adding a little help to our tool to accomplish the same thing.
-Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
This has been committed.
Thanks
--Rich
commit 3ae81520e91945454f35fa75833a45b5b000fe33
Author: Eric Sandeen <[email protected]> Date: Tue Nov 12 17:14:46 2013 +0000
xfs_repair: suggest reboot after dangerous repair
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs