Skip to contentSkip to conversation

config.mk: Do not include include/config.mk

PATCH New Masahiro Yamada 1 participant 2 messages Dec 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config.mk: Do not include include/config.mk

Board configuration creates include/config.mk, which is included from both $(TOPDIR)/Makefile and $(TOPDIR)/config.mk. This is rudandant.

Because $(TOPDIR)/Makefile exports ARCH, CPU, BOARD, VENDOR, SOC, $(TOPDIR)/config.mk does not need to include include/config.mk.

---

Please see around line 158 of $(TOPDIR)/Makefile:

  # load ARCH, BOARD, and CPU configuration
  include $(obj)include/config.mk
  export  ARCH CPU BOARD VENDOR SOC

And see also around line 168 of $(TOPDIR)/config.mk:

  sinclude $(OBJTREE)/include/config.mk
 config.mk | 1 -
 1 file changed, 1 deletion(-)
config.mk +0 -1
index d5b09a0..2ce5b84 100644
@@ -165,7 +165,6 @@ else
 sinclude $(OBJTREE)/include/autoconf.mk
 endif
 endif
-sinclude $(OBJTREE)/include/config.mk
 
 # Some architecture config.mk files need to know what CPUDIR is set to,
 # so calculate CPUDIR before including ARCH/SOC/CPU config.mk files.
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 config.mk: Do not include include/config.mk

Hi.

Quoted 8 lines

Board configuration creates include/config.mk, which is included from both $(TOPDIR)/Makefile and $(TOPDIR)/config.mk. This is rudandant.

Because $(TOPDIR)/Makefile exports ARCH, CPU, BOARD, VENDOR, SOC, $(TOPDIR)/config.mk does not need to include include/config.mk.

It turned out this patch does not work for Tegra.
Please ignore this.

Best Regards
Masahiro Yamada