Skip to contentSkip to conversation

mei: add 9 series PCH mei device ids

char-misc-next Tomas Winkler 2 participants 3 messages Dec 3, 2013 – Dec 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

And Lynx Point H Refresh and Wildcat Point LP
device ids.

---
 drivers/misc/mei/hw-me-regs.h | 4 ++++
 drivers/misc/mei/pci-me.c     | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
drivers/misc/mei/hw-me-regs.h +4 -0
index 6c0fde5..f83bc80 100644
@@ -110,8 +110,12 @@
 #define MEI_DEV_ID_PPT_3      0x1DBA  /* Panther Point */
 
 #define MEI_DEV_ID_LPT        0x8C3A  /* Lynx Point */
+#define MEI_DEV_ID_LPT_H      0x8C3A  /* Lynx Point H */
 #define MEI_DEV_ID_LPT_W      0x8D3A  /* Lynx Point - Wellsburg */
 #define MEI_DEV_ID_LPT_LP     0x9C3A  /* Lynx Point LP */
+#define MEI_DEV_ID_LPT_HR     0x8CBA  /* Lynx Point H Refresh */
+
+#define MEI_DEV_ID_WPT_LP     0x9CBA  /* Wildcat Point LP */
 /*
  * MEI HW Section
  */
drivers/misc/mei/pci-me.c +3 -1
index 3bfae38..7dfaa32 100644
@@ -76,9 +76,11 @@ static DEFINE_PCI_DEVICE_TABLE(mei_me_pci_tbl) = {
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_1)},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_2)},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_3)},
-	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT)},
+	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_H)},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_W)},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_LP)},
+	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_HR)},
+	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_WPT_LP)},
 
 	/* required last entry */
 	{0, }
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 14 lines · Tomas Winkler

And Lynx Point H Refresh and Wildcat Point LP
device ids.

---
 drivers/misc/mei/hw-me-regs.h | 4 ++++
 drivers/misc/mei/pci-me.c     | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
drivers/misc/mei/hw-me-regs.h +0 -0
index 6c0fde5..f83bc80 100644

drivers/misc/mei/hw-me-regs.h line 113

Quoted 4 lines
drivers/misc/mei/hw-me-regs.h +1 -0
@@ -110,8 +110,12 @@
 #define MEI_DEV_ID_PPT_3      0x1DBA  /* Panther Point */
 
 #define MEI_DEV_ID_LPT        0x8C3A  /* Lynx Point */
+#define MEI_DEV_ID_LPT_H      0x8C3A  /* Lynx Point H */

Why duplicate this #define?

And, now that you changed it, why keep the "old" one around, it's no longer used anywhere else?

thanks,

greg k-h

#2 lore raw
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hw-me-regs.h +0 -0
index 6c0fde5..f83bc80 100644
@@ -110,8 +110,12 @@
 #define MEI_DEV_ID_PPT_3      0x1DBA  /* Panther Point */
 
Quoted 8 lines

drivers/misc/mei/hw-me-regs.h line 113

Quoted 2 lines
drivers/misc/mei/hw-me-regs.h +1 -0
 #define MEI_DEV_ID_LPT        0x8C3A  /* Lynx Point */
+#define MEI_DEV_ID_LPT_H      0x8C3A  /* Lynx Point H */

Why duplicate this #define?

And, now that you changed it, why keep the "old" one around, it's no longer used anywhere else?

The correct name is LPT_H so I've just missed to remove the line, sending V2.

Thanks
Tomas