libfreefare: Fix build on static
PATCH 1/1 libfreefare: Fix build on static
This patch makes this package building correctly on static.
Fixes:
http://autobuild.buildroot.net/results/f09/f09d515f0e7b6d78010f1ce624336ceaef624989/
--- .../libfreefare-001-fix-static-build.patch | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 package/libfreefare/libfreefare-001-fix-static-build.patch
package/libfreefare/libfreefare-001-fix-static-build.patch new file +10 -0
@@ -0,0 +1,10 @@ +--- libfreefare-0.3.4/examples/Makefile.am.orig 2013-12-05 17:08:16.058185440 +0000 ++++ libfreefare-0.3.4/examples/Makefile.am 2013-12-05 17:14:02.270548090 +0000 +@@ -2,6 +2,7 @@ + + AM_CFLAGS = -I. -I$(top_srcdir)/libfreefare @LIBNFC_CFLAGS@ + AM_LDFLAGS = @LIBNFC_LIBS@ ++LIBS = -lcrypto -lz + + bin_PROGRAMS = mifare-classic-format \ + mifare-classic-write-ndef \
Signature · 1 line
1.7.1
PATCH 1/1 libfreefare: Fix build on static
Vicente, All,
On 2013-12-05 18:17 +0000, Vicente Olivert Riera spake thusly:
Quoted 18 lines
This patch makes this package building correctly on static.
Fixes:
http://autobuild.buildroot.net/results/f09/f09d515f0e7b6d78010f1ce624336ceaef624989/Signed-off-by Vicente Olivert Riera <[email protected]>--- .../libfreefare-001-fix-static-build.patch | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 package/libfreefare/libfreefare-001-fix-static-build.patchpackage/libfreefare/libfreefare-001-fix-static-build.patch new file +0
-0
package/libfreefare/libfreefare-001-fix-static-build.patch line 7
Quoted 7 lines
package/libfreefare/libfreefare-001-fix-static-build.patch new file +7
-0@@ -0,0 +1,10 @@ +--- libfreefare-0.3.4/examples/Makefile.am.orig 2013-12-05 17:08:16.058185440 +0000 ++++ libfreefare-0.3.4/examples/Makefile.am 2013-12-05 17:14:02.270548090 +0000 +@@ -2,6 +2,7 @@ + + AM_CFLAGS = -I. -I$(top_srcdir)/libfreefare @LIBNFC_CFLAGS@ + AM_LDFLAGS = @LIBNFC_LIBS@ ++LIBS = -lcrypto -lz
Note that libfreefare itself does not use libz, but libcrypto does.
The reason why -lz is missing is because libfreefare uses AC_CHECK_LIB to check for libcrypto, when it should use PKG_CHECK_MODULES (which correctly has" Libs.private: -ldl -lz )
So, if a fix was to be bopushed upstream, it would be to fix libfreefare to use PKG_CHECK_MODULES, not this.
package/libfreefare/libfreefare-001-fix-static-build.patch line 10
Quoted 2 lines
package/libfreefare/libfreefare-001-fix-static-build.patch new file +2
-0+ bin_PROGRAMS = mifare-classic-format \ + mifare-classic-write-ndef \
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 libfreefare: Fix build on static
Vicente, All,
On 2013-12-05 19:51 +0100, Yann E. MORIN spake thusly:
Quoted 29 lines
On 2013-12-05 18:17 +0000, Vicente Olivert Riera spake thusly:
Quoted 18 lines
This patch makes this package building correctly on static.
Fixes:
http://autobuild.buildroot.net/results/f09/f09d515f0e7b6d78010f1ce624336ceaef624989/Signed-off-by Vicente Olivert Riera <[email protected]>--- .../libfreefare-001-fix-static-build.patch | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 package/libfreefare/libfreefare-001-fix-static-build.patchpackage/libfreefare/libfreefare-001-fix-static-build.patch new file +0
-0package/libfreefare/libfreefare-001-fix-static-build.patch line 7
Quoted 7 lines
package/libfreefare/libfreefare-001-fix-static-build.patch new file +7
-0@@ -0,0 +1,10 @@ +--- libfreefare-0.3.4/examples/Makefile.am.orig 2013-12-05 17:08:16.058185440 +0000 ++++ libfreefare-0.3.4/examples/Makefile.am 2013-12-05 17:14:02.270548090 +0000 +@@ -2,6 +2,7 @@ + + AM_CFLAGS = -I. -I$(top_srcdir)/libfreefare @LIBNFC_CFLAGS@ + AM_LDFLAGS = @LIBNFC_LIBS@ ++LIBS = -lcrypto -lzNote that libfreefare itself does not use libz, but libcrypto does.
Quoted 3 lines
The reason why -lz is missing is because libfreefare uses
AC_CHECK_LIBto check for libcrypto, when it should usePKG_CHECK_MODULES(which correctly has" Libs.private: -ldl -lz )
Gah. No, it does not. I was looking at my host's libcrypto.pc. The one we install is missing -lz. So it should be fixed.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 libfreefare: Fix build on static
In reply to Vicente Olivert RieraQuoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Vicente" == Vicente Olivert Riera <[email protected]> writes:
This patch makes this package building correctly on static. Fixes:
http://autobuild.buildroot.net/results/f09/f09d515f0e7b6d78010f1ce624336ceaef624989/Signed-off-by Vicente Olivert Riera <[email protected]>--- .../libfreefare-001-fix-static-build.patch | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 package/libfreefare/libfreefare-001-fix-static-build.patchpackage/libfreefare/libfreefare-001-fix-static-build.patch new file +0
-0
package/libfreefare/libfreefare-001-fix-static-build.patch line 7
Quoted 7 lines
package/libfreefare/libfreefare-001-fix-static-build.patch new file +7
-0@@ -0,0 +1,10 @@ +--- libfreefare-0.3.4/examples/Makefile.am.orig 2013-12-05 17:08:16.058185440 +0000 ++++ libfreefare-0.3.4/examples/Makefile.am 2013-12-05 17:14:02.270548090 +0000 +@@ -2,6 +2,7 @@ + + AM_CFLAGS = -I. -I$(top_srcdir)/libfreefare @LIBNFC_CFLAGS@ + AM_LDFLAGS = @LIBNFC_LIBS@ ++LIBS = -lcrypto -lz
Thanks, but it's nicer to just pass LIBS= to configure instead of patching the Makefile.am (and running autoreconf).
As far as I can see from the autobuild error (and local testing), it's only missing -lz, so I left out -lcrypto.
Signature · 1 line
Bye, Peter Korsgaard