Skip to contentSkip to conversation

Enable Calxeda cpufreq driver on arm64

PATCH In review Rob Herring 3 participants 7 messages Dec 5, 2013 – Dec 16, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Enable Calxeda cpufreq driver on arm64

From: Rob Herring <[email protected]>

This series enables cpufreq subsystem and the highbank-cpufreq driver for arm64. Nothing more really than sorting kconfig options to allow the driver to build. There's no reason for the driver to depend on ARCH_HIGHBANK and I'm trying to avoid adding that (or a new option) for arm64.

Rob

Rob Herring (2):
cpufreq: enable ARM drivers on arm64
cpufreq: highbank: rework the kconfig dependencies for arm64

 arch/arm64/Kconfig          |  8 ++++++++
 drivers/cpufreq/Kconfig     |  2 +-
 drivers/cpufreq/Kconfig.arm | 14 ++++++--------
 3 files changed, 15 insertions(+), 9 deletions(-)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/2 cpufreq: enable ARM drivers on arm64

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 arch/arm64/Kconfig      | 8 ++++++++
 drivers/cpufreq/Kconfig | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
arch/arm64/Kconfig +8 -0
index 88c8b6c1..1808dd1 100644
@@ -276,6 +276,14 @@ config SYSVIPC_COMPAT
 
 endmenu
 
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu
+
 source "net/Kconfig"
 
 source "drivers/Kconfig"
drivers/cpufreq/Kconfig +1 -1
index 38093e2..e26fdcd 100644
@@ -195,7 +195,7 @@ source "drivers/cpufreq/Kconfig.x86"
 endmenu
 
 menu "ARM CPU frequency scaling drivers"
-depends on ARM
+depends on ARM || ARM64
 source "drivers/cpufreq/Kconfig.arm"
 endmenu
 
Signature · 1 line
1.8.3.2
#2 lore raw

Re: [PATCH 1/2] cpufreq: enable ARM drivers on arm64

Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

If this needs any revisions (I'd be surprised but...) can you please keep me on the CCs? I intend to pull this into LSK if that's OK since I was about to do roughly the same thing for it and upstream the result.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

Re: [PATCH 1/2] cpufreq: enable ARM drivers on arm64

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 8 lines · Mark Brown
Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

Quoted 4 lines

If this needs any revisions (I'd be surprised but...) can you please keep me on the CCs? I intend to pull this into LSK if that's OK since I was about to do roughly the same thing for it and upstream the result.

Will do, but I'm surprised we're at the point on arm64 of needing LSK. There's a couple of subsystems that need enabling. I've posted EDAC patches (need to send v3). cpuidle is another. Probably some more I haven't looked at.

Rob

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSoNwoAAoJEMhvYp4jgsXiZmMH/0h6Zubjcqhkrx/UGYa47j7r EU0stg3/sJvyNGlo+jDV7ljEEtHVmJyxINORDFCGBlYLnsVisYLY9Q+YRZH7PSrJ O7eloK2LdceYabpoe0QFBXuB+VQ5uUiVH5ts9I3JLp3bxvBwjjM6rsYdKHwx4VHp IAkCgRZZAC9WLi+F4vteC9oh+S5UoXIKpTr1ei/y21czZ6Gw8tGhrGX4fc3IcFSy 4OPFb41/RQkJL5U4KCRUrMS+8wOmJy3rLcTvjxXz85b5ht9+i01AUt6yN9mwGrjp a/Y5pFzADIXvhlJDYt4KBK+xgYyL6keWSc2cQyW08MhyNRjr2qXzOaw3qb3VvhI= =SJ+q
-----END PGP SIGNATURE-----

#4 lore raw

Re: [PATCH 1/2] cpufreq: enable ARM drivers on arm64

Quoted 1 line · Rob Herring

Will do, but I'm surprised we're at the point on arm64 of needing LSK.

ARMv8 isn't just for servers, and of course there's the desire to have the software as ready as early as it can be!

Quoted 3 lines

There's a couple of subsystems that need enabling. I've posted EDAC patches (need to send v3). cpuidle is another. Probably some more I haven't looked at.

Right, cpuidle is in progress - Lorenzo has been posting patches for that:

http://lwn.net/Articles/574950/

There's some active work in the trace and debug area too.

#5 lore raw

PATCH 2/2 cpufreq: highbank: rework the kconfig dependencies for arm64

In reply to Rob Herring

From: Rob Herring <[email protected]>

Make ARM_HIGHBANK_CPUFREQ not depend on ARCH_HIGHBANK to enable on arm64 and also give better build converage. Change the selects to be same depends as the cpu0 driver. Otherwise, we can get kconfig select errors. Also, add missing depends for PL320_MBOX.

---
 drivers/cpufreq/Kconfig.arm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/cpufreq/Kconfig.arm +6 -8
index ce52ed9..0d7130d 100644
@@ -65,16 +65,14 @@ config ARM_EXYNOS5440_CPUFREQ
 	  If in doubt, say N.
 
 config ARM_HIGHBANK_CPUFREQ
-	tristate "Calxeda Highbank-based"
-	depends on ARCH_HIGHBANK
-	select GENERIC_CPUFREQ_CPU0
+	tristate "Calxeda ECX based"
+	depends on HAVE_CLK && REGULATOR && OF
+	depends on PL320_MBOX
+	select ARCH_HAS_OPP
 	select PM_OPP
-	select REGULATOR
-
-	default m
+	select GENERIC_CPUFREQ_CPU0
 	help
-	  This adds the CPUFreq driver for Calxeda Highbank SoC
-	  based boards.
+	  This adds the CPUFreq driver for Calxeda based SoCs.
 
 	  If in doubt, say N.
 
Signature · 1 line
1.8.3.2
maintainer Acked-by on v1 2/2
#6 lore raw

Re: [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64

Quoted 4 lines · Rob Herring

From: Rob Herring <[email protected]>

Make ARM_HIGHBANK_CPUFREQ not depend on ARCH_HIGHBANK to enable on arm64 and also give better build converage. Change the selects to be

s/converage/coverage

Quoted 28 lines

same depends as the cpu0 driver. Otherwise, we can get kconfig select errors. Also, add missing depends for PL320_MBOX.

---
 drivers/cpufreq/Kconfig.arm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/cpufreq/Kconfig.arm +4 -3
index ce52ed9..0d7130d 100644
@@ -65,16 +65,14 @@ config ARM_EXYNOS5440_CPUFREQ
          If in doubt, say N.
 
 config ARM_HIGHBANK_CPUFREQ
-       tristate "Calxeda Highbank-based"
-       depends on ARCH_HIGHBANK
-       select GENERIC_CPUFREQ_CPU0
+       tristate "Calxeda ECX based"
+       depends on HAVE_CLK && REGULATOR && OF
+       depends on PL320_MBOX
+       select ARCH_HAS_OPP
        select PM_OPP

drivers/cpufreq/Kconfig.arm config ARM_EXYNOS5440_CPUFREQ · line 77

Quoted 10 lines
drivers/cpufreq/Kconfig.arm +2 -5
-       select REGULATOR
-
-       default m
+       select GENERIC_CPUFREQ_CPU0
        help
-         This adds the CPUFreq driver for Calxeda Highbank SoC
-         based boards.
+         This adds the CPUFreq driver for Calxeda based SoCs.
 
          If in doubt, say N.