Skip to contentSkip to conversation

cfg80211: set regulatory request processed for initiator core

RFC NAK Avinash Patil 2 participants 4 messages Dec 6, 2013 – Dec 13, 2013 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

RFC 1/1 cfg80211: set regulatory request processed for initiator core

During cfg80211 init, cfg80211 initializes regulatory to set to world domain. Here we dont set last request processed flag. This results into further request set to pending indefinitely.

This patch fixes this by setting last request to processed.

---
 net/wireless/reg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/wireless/reg.c +2 -0
index ec54e1a..70a8f0a 100644
@@ -1670,6 +1670,8 @@ static void reg_process_hint(struct regulatory_request *reg_request)
 	switch (reg_request->initiator) {
 	case NL80211_REGDOM_SET_BY_CORE:
 		reg_process_hint_core(reg_request);
+		nl80211_send_reg_change_event(reg_request);
+		reg_set_request_processed();
 		return;
 	case NL80211_REGDOM_SET_BY_USER:
 		treatment = reg_process_hint_user(reg_request);
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 16 lines · Avinash Patil

During cfg80211 init, cfg80211 initializes regulatory to set to world domain. Here we dont set last request processed flag. This results into further request set to pending indefinitely.

This patch fixes this by setting last request to processed.

---
 net/wireless/reg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/wireless/reg.c +0 -0
index ec54e1a..70a8f0a 100644

net/wireless/reg.c static void reg_process_hint(struct regulatory_request *reg_request) · line 1677

Quoted 8 lines
net/wireless/reg.c +2 -0
@@ -1670,6 +1670,8 @@ static void reg_process_hint(struct regulatory_request *reg_request)
        switch (reg_request->initiator) {
        case NL80211_REGDOM_SET_BY_CORE:
                reg_process_hint_core(reg_request);
+               nl80211_send_reg_change_event(reg_request);
+               reg_set_request_processed();
                return;
        case NL80211_REGDOM_SET_BY_USER:
                treatment = reg_process_hint_user(reg_request);

NACK, the reg_process_hint() is supposed to *process* a request, and then call the internal regdb if its there and also call CRDA. Later whoever sends the regulatory domain and gets cfg80211 to process it will have reg_set_request_processed() called.

Can you verify if CRDA is sending the regulatory domains to cfg80211?

Luis

#2 lore raw
Quoted 31 lines · Luis R. Rodriguez
Quoted 16 lines · Avinash Patil

During cfg80211 init, cfg80211 initializes regulatory to set to world domain. Here we dont set last request processed flag. This results into further request set to pending indefinitely.

This patch fixes this by setting last request to processed.

---
 net/wireless/reg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/wireless/reg.c +0 -0
index ec54e1a..70a8f0a 100644

net/wireless/reg.c static void reg_process_hint(struct regulatory_request *reg_request) · line 1677

Quoted 8 lines
net/wireless/reg.c +2 -0
@@ -1670,6 +1670,8 @@ static void reg_process_hint(struct regulatory_request *reg_request)
        switch (reg_request->initiator) {
        case NL80211_REGDOM_SET_BY_CORE:
                reg_process_hint_core(reg_request);
+               nl80211_send_reg_change_event(reg_request);
+               reg_set_request_processed();
                return;
        case NL80211_REGDOM_SET_BY_USER:
                treatment = reg_process_hint_user(reg_request);

NACK, the reg_process_hint() is supposed to *process* a request, and then call the internal regdb if its there and also call CRDA. Later whoever sends the regulatory domain and gets cfg80211 to process it will have reg_set_request_processed() called.

Quoted 1 line

Can you verify if CRDA is sending the regulatory domains to cfg80211?

Also are you seeing this with wireless-testing ?

Luis

#3 lore raw

Hi Luis,

I am using 3.13rc2 kernel; last commit on this branch is "ad17d104284ea4a301126b475df3bef03258142a".

If we set regulatory domain via "iw reg set US" we see following in dmesg logs:
cfg80211: Pending regulatory request, waiting for it to be processed...
Udevm monitor (via udevadm monitor --environment kernel) also does not print any CRDA domain change messages.

I have pasted dmesg logs at following location:
http://pastebin.com/kkNagpSu

If we apply below mentioned patch, last request is set to processed enabling cfg80211 to send further requests.

Thanks,
Avinash Patil

________________________________________
From: [email protected] [[email protected]] On Behalf Of Luis R. Rodriguez [[email protected]]
Sent: Wednesday, December 11, 2013 11:31 PM
To: Avinash Patil
Cc: Johannes Berg; linux-wireless
Subject: Re: [RFC] cfg80211: set regulatory request processed for initiator core

Quoted 31 lines · Luis R. Rodriguez
Quoted 16 lines · Avinash Patil

During cfg80211 init, cfg80211 initializes regulatory to set to world domain. Here we dont set last request processed flag. This results into further request set to pending indefinitely.

This patch fixes this by setting last request to processed.

---
 net/wireless/reg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/wireless/reg.c +0 -0
index ec54e1a..70a8f0a 100644

net/wireless/reg.c static void reg_process_hint(struct regulatory_request *reg_request) · line 1677

Quoted 8 lines
net/wireless/reg.c +2 -0
@@ -1670,6 +1670,8 @@ static void reg_process_hint(struct regulatory_request *reg_request)
        switch (reg_request->initiator) {
        case NL80211_REGDOM_SET_BY_CORE:
                reg_process_hint_core(reg_request);
+               nl80211_send_reg_change_event(reg_request);
+               reg_set_request_processed();
                return;
        case NL80211_REGDOM_SET_BY_USER:
                treatment = reg_process_hint_user(reg_request);

NACK, the reg_process_hint() is supposed to *process* a request, and then call the internal regdb if its there and also call CRDA. Later whoever sends the regulatory domain and gets cfg80211 to process it will have reg_set_request_processed() called.

Quoted 1 line

Can you verify if CRDA is sending the regulatory domains to cfg80211?

Also are you seeing this with wireless-testing ?

Luis