Skip to contentSkip to conversation

Staging: android: fix parantheses coding style issue in alarm-dev.c

PATCH In review Preetam D'Souza 2 participants 5 messages Dec 7, 2013 – Dec 10, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: android: fix parantheses coding style issue in alarm-dev.c

This patch fixes an unecessary return statement parantheses error found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has no more errors/warnings!

---
 drivers/staging/android/alarm-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/android/alarm-dev.c +2 -2
index 647694f..ccf74ee 100644
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
  */
 static int is_wakeup(enum android_alarm_type type)
 {
-	return (type == ANDROID_ALARM_RTC_WAKEUP ||
-		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+	return type == ANDROID_ALARM_RTC_WAKEUP ||
+		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
 }
 
 
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 8 lines · Preetam D'Souza

This patch fixes an unecessary return statement parantheses error found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has no more errors/warnings!

---
 drivers/staging/android/alarm-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This was already fixed a while ago, what tree are you working against?

sorry, I can't apply this again.

greg k-h

#2 lore raw

Hey Greg--I'm working against Linus' latest tree on
https://github.com/torvalds/linux.git ... which tree should I be using for the updated code?

Thanks!
Preetam

Quoted 15 lines · Greg KH
Quoted 8 lines · Preetam D'Souza

This patch fixes an unecessary return statement parantheses error found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has no more errors/warnings!

---
 drivers/staging/android/alarm-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This was already fixed a while ago, what tree are you working against?

sorry, I can't apply this again.

greg k-h

maintainer
#3 lore raw

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 3 lines · Preetam D'Souza

Hey Greg--I'm working against Linus' latest tree on
https://github.com/torvalds/linux.git ... which tree should I be using for the updated code?

linux-next or the subsystem-specific tree (for drivers/staging/ that would be the staging.git tree at git.kernel.org, and use the staging-next branch.)

hope this helps,

greg k-h

#4 lore raw
Quoted 8 lines · Greg KH

linux-next or the subsystem-specific tree (for drivers/staging/ that would be the staging.git tree at git.kernel.org, and use the staging-next branch.)

hope this helps,

greg k-h

Got it! Thanks for the heads UP, will switch over to *-next.

-Preetam