Add power management support for mxs phy
Subsystems (3)
v5 cover Add power management support for mxs phy
Hi Felipe & Shawn,
The serial adds power management support for MXS PHY, it includes:
- Add three common PHY APIs, .set_wakeup, .notify_suspend, notify_resume.
- Related above API implementation at mxs phy driver
- misc changes and bug fixes for mxs phy to support low power mode and wakeup.
It is based on Greg's usb-next, 3.13-rc1.
Changes for v5:
Add Marc and Michael Grzeschik's commnets
- typo error at [2/15]
- sqhash patches which introducing mxs_phy_disconnect_line and fixed but at this function. [13/15]
- Introducing flag MXS_PHY_NEED_IP_FIX who stands for the SoCs who have IC fixes. [2/15, 8/15]
- Delete one patch for low speed connection problem at every rare situations due to the root cause has still not found.
Changes for v4:
- Using MXS_PHY_HAS_ANATOP to indicate which platform has anatop module
- Using mxs_phy_data to instead of mxs_phy_platform_flag
- Create is_xxx_phy() MACRO
- Add imx6sl support, and pass the test [5/17]
- Add one additional binding doc for compatible string [1/17]
- Introduce controller id to access un-regulator register region [14/17] [15/17]
- Add waiting stable time before phy clock switches to AHB clock (from 32K) [13/17]
- Fix one problem that only using the 1st controller register at mxs_phy_disconnect_line [16/17]
- Fix one problem for low speed connection at very rare cases [17/17]
- Some typos
Changes for v3:
- Using flag bit to indicate SoC features/bugs, so we can remove platform_device_id.
- Remove 3 unnecessary dts/doc patches due to above change
- Several comment change
Peter Chen (15):
usb: doc: phy-mxs: Add more compatible strings
usb: phy-mxs: Add platform judgement code
usb: phy-mxs: Add auto clock and power setting
usb: doc: phy-mxs: update binding for adding anatop phandle
ARM: dts: imx6: add anatop phandle for usbphy
usb: phy-mxs: Add anatop regmap
usb: phy: add notify suspend and resume callback
usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
usb: phy-mxs: Enable IC fixes for related SoCs
ARM: dts: imx: add mxs phy controller id
usb: phy-mxs: add controller id
usb: phy: Add set_wakeup API
usb: phy-mxs: Add implementation of set_wakeup
usb: phy-mxs: Add system suspend/resume API
usb: phy-mxs: Add sync time after controller clear phcd
Documentation/devicetree/bindings/usb/mxs-phy.txt | 5 +- arch/arm/boot/dts/imx23.dtsi | 1 + arch/arm/boot/dts/imx28.dtsi | 2 + arch/arm/boot/dts/imx6qdl.dtsi | 4 + arch/arm/boot/dts/imx6sl.dtsi | 4 + drivers/usb/phy/phy-mxs-usb.c | 355 ++++++++++++++++++++- include/linux/usb/phy.h | 39 +++ 7 files changed, 395 insertions(+), 15 deletions(-)
Signature · 1 line
1.7.8
PATCH v5 1/15 usb: doc: phy-mxs: Add more compatible strings
Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
"fsl,imx6sl-usbphy" for imx6sl.
--- Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Documentation/devicetree/bindings/usb/mxs-phy.txt +2 -1
@@ -1,7 +1,8 @@ * Freescale MXS USB Phy Device Required properties: -- compatible: Should be "fsl,imx23-usbphy" +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl - reg: Should contain registers location and length - interrupts: Should contain phy interrupt
Signature · 1 line
1.7.8
PATCH v5 2/15 usb: phy-mxs: Add platform judgement code
In reply to Peter ChenThe mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data.
--- drivers/usb/phy/phy-mxs-usb.c | 58 ++++++++++++++++++++++++++++++++++------ 1 files changed, 49 insertions(+), 9 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +49 -9
@@ -1,5 +1,5 @@/* -* Copyright 2012 Freescale Semiconductor, Inc. +* Copyright 2012-2013 Freescale Semiconductor, Inc. * Copyright (C) 2012 Marek Vasut <[email protected]> * on behalf of DENX Software Engineering GmbH *
@@ -20,6 +20,7 @@#include <linux/delay.h> #include <linux/err.h> #include <linux/io.h> +#include <linux/of_device.h> #define DRIVER_NAME "mxs_phy"
@@ -34,13 +35,55 @@#define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)#define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1) +#define to_mxs_phy (p) container_of((p), struct mxs_phy, phy) + +/* Do disconnection between PHY and controller without vbus */ +#define MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS BIT(0) + +/* +* The PHY will be in messy if there is a wakeup after putting +* bus to suspend (set portsc.suspendM) but before setting PHY to low +* power mode (set portsc.phcd). +*/ +#define MXS_PHY_ABNORMAL_IN_SUSPEND BIT(1) + +/* +* The SOF sends too fast after resuming, it will cause disconnection +* between host and high speed device. +*/ +#define MXS_PHY_SENDING_SOF_TOO_FAST BIT(2) + +struct mxs_phy_data { +unsigned int flags; +}; + +static const struct mxs_phy_data imx23_phy_data = { + .flags =MXS_PHY_ABNORMAL_IN_SUSPEND |MXS_PHY_SENDING_SOF_TOO_FAST , +}; + +static const struct mxs_phy_data imx6q_phy_data = { + .flags =MXS_PHY_SENDING_SOF_TOO_FAST | +MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS , +}; + +static const struct mxs_phy_data imx6sl_phy_data = { + .flags =MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS , +}; + +static const struct of_device_id mxs_phy_dt_ids[] = { + { .compatible ="fsl,imx6sl-usbphy" , .data = &imx6sl_phy_data, }, + { .compatible ="fsl,imx6q-usbphy" , .data = &imx6q_phy_data, }, + { .compatible ="fsl,imx23-usbphy" , .data = &imx23_phy_data, }, + {/* sentinel */ } +}; +MODULE_DEVICE_TABLE (of, mxs_phy_dt_ids); +struct mxs_phy {struct usb_phy phy;struct clk *clk; +const struct mxs_phy_data *data; }; -#define to_mxs_phy (p) container_of((p), struct mxs_phy, phy) -static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;
@@ -131,6 +174,8 @@ static int mxs_phy_probe(struct platform_device *pdev)struct clk *clk;struct mxs_phy *mxs_phy;int ret; +const struct of_device_id *of_id = +of_match_device (mxs_phy_dt_ids, &pdev->dev); res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); base =devm_ioremap_resource (&pdev->dev, res);
@@ -163,6 +208,7 @@ static int mxs_phy_probe(struct platform_device *pdev)ATOMIC_INIT_NOTIFIER_HEAD (&mxs_phy->phy.notifier); mxs_phy->clk = clk; + mxs_phy->data = of_id->data;platform_set_drvdata (pdev, mxs_phy);
@@ -182,12 +228,6 @@ static int mxs_phy_remove(struct platform_device *pdev)return 0 ; } -static const struct of_device_id mxs_phy_dt_ids[] = { - { .compatible ="fsl,imx23-usbphy" , }, - {/* sentinel */ } -}; -MODULE_DEVICE_TABLE (of, mxs_phy_dt_ids); -static struct platform_driver mxs_phy_driver = { .probe = mxs_phy_probe, .remove = mxs_phy_remove,
Signature · 1 line
1.7.8
PATCH v5 3/15 usb: phy-mxs: Add auto clock and power setting
In reply to Peter ChenWith the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic.
--- drivers/usb/phy/phy-mxs-usb.c | 20 +++++++++++++++++--- 1 files changed, 17 insertions(+), 3 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +17 -3
@@ -31,6 +31,11 @@#define BM_USBPHY_CTRL_SFTRST BIT(31)#define BM_USBPHY_CTRL_CLKGATE BIT(30) +#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26) +#define BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE BIT(25) +#define BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD BIT(20) +#define BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE BIT(19) +#define BM_USBPHY_CTRL_ENAUTO_PWRON_PLL BIT(18)#define BM_USBPHY_CTRL_ENUTMILEVEL3 BIT(15)#define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)#define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1)
@@ -96,9 +101,18 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)/* Power up the PHY */ writel (0 , base +HW_USBPHY_PWD ); -/* enable FS/LS device */ -writel (BM_USBPHY_CTRL_ENUTMILEVEL2 | -BM_USBPHY_CTRL_ENUTMILEVEL3 , +/* +* USB PHY Ctrl Setting +* - Auto clock/power on +* - Enable full/low speed support +*/ +writel (BM_USBPHY_CTRL_ENAUTOSET_USBCLKS | +BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE | +BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD | +BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE | +BM_USBPHY_CTRL_ENAUTO_PWRON_PLL | +BM_USBPHY_CTRL_ENUTMILEVEL2 | +BM_USBPHY_CTRL_ENUTMILEVEL3 , base +HW_USBPHY_CTRL_SET );return 0 ;
Signature · 1 line
1.7.8
PATCH v5 4/15 usb: doc: phy-mxs: update binding for adding anatop phandle
In reply to Peter ChenAdd anatop phandle which is used to access anatop registers to control PHY's power and other USB operations.
--- Documentation/devicetree/bindings/usb/mxs-phy.txt | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/usb/mxs-phy.txt +2 -0
@@ -5,10 +5,12 @@ Required properties: for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl - reg: Should contain registers location and length - interrupts: Should contain phy interrupt +- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series Example: usbphy1: usbphy at 020c9000 { compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; reg = <0x020c9000 0x1000>; interrupts = <0 44 0x04>; + fsl,anatop = <&anatop>; };
Signature · 1 line
1.7.8
PATCH v5 5/15 ARM: dts: imx6: add anatop phandle for usbphy
In reply to Peter ChenAdd anatop phandle for usbphy
--- arch/arm/boot/dts/imx6qdl.dtsi | 2 ++ arch/arm/boot/dts/imx6sl.dtsi | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +2 -0
@@ -557,6 +557,7 @@ reg = <0x020c9000 0x1000>; interrupts = <0 44 0x04>; clocks = <&clks 182>; + fsl,anatop = <&anatop>; }; usbphy2: usbphy at 020ca000 {
@@ -564,6 +565,7 @@ reg = <0x020ca000 0x1000>; interrupts = <0 45 0x04>; clocks = <&clks 183>; + fsl,anatop = <&anatop>; }; snvs at 020cc000 {
arch/arm/boot/dts/imx6sl.dtsi +2 -0
@@ -489,6 +489,7 @@ reg = <0x020c9000 0x1000>; interrupts = <0 44 0x04>; clocks = <&clks IMX6SL_CLK_USBPHY1>; + fsl,anatop = <&anatop>; }; usbphy2: usbphy at 020ca000 {
@@ -496,6 +497,7 @@ reg = <0x020ca000 0x1000>; interrupts = <0 45 0x04>; clocks = <&clks IMX6SL_CLK_USBPHY2>; + fsl,anatop = <&anatop>; }; snvs at 020cc000 {
Signature · 1 line
1.7.8
PATCH v5 6/15 usb: phy-mxs: Add anatop regmap
In reply to Peter ChenIt is needed by imx6 SoC series, but not for imx23 and imx28.
--- drivers/usb/phy/phy-mxs-usb.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +21 -2
@@ -21,6 +21,8 @@#include <linux/err.h> #include <linux/io.h> #include <linux/of_device.h> +#include <linux/regmap.h> +#include <linux/mfd/syscon.h> #define DRIVER_NAME "mxs_phy"
@@ -58,6 +60,9 @@*/ #define MXS_PHY_SENDING_SOF_TOO_FAST BIT(2) +/* The SoCs who have anatop module */ +#define MXS_PHY_HAS_ANATOP BIT(3) +struct mxs_phy_data {unsigned int flags; };
@@ -68,11 +73,13 @@ static const struct mxs_phy_data imx23_phy_data = {static const struct mxs_phy_data imx6q_phy_data = { .flags =MXS_PHY_SENDING_SOF_TOO_FAST | -MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS , +MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | +MXS_PHY_HAS_ANATOP , };static const struct mxs_phy_data imx6sl_phy_data = { - .flags =MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS , + .flags =MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | +MXS_PHY_HAS_ANATOP , };static const struct of_device_id mxs_phy_dt_ids[] = {
@@ -87,6 +94,7 @@ struct mxs_phy {struct usb_phy phy;struct clk *clk;const struct mxs_phy_data *data; +struct regmap *regmap_anatop; };static int mxs_phy_hw_init (struct mxs_phy *mxs_phy)
@@ -190,6 +198,7 @@ static int mxs_phy_probe(struct platform_device *pdev)int ret;const struct of_device_id *of_id =of_match_device (mxs_phy_dt_ids, &pdev->dev); +struct device_node *np = pdev->dev.of_node; res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); base =devm_ioremap_resource (&pdev->dev, res);
@@ -226,6 +235,16 @@ static int mxs_phy_probe(struct platform_device *pdev)platform_set_drvdata (pdev, mxs_phy); +if (mxs_phy->data->flags &MXS_PHY_HAS_ANATOP ) { + mxs_phy->regmap_anatop =syscon_regmap_lookup_by_phandle + (np,"fsl,anatop" ); +if (IS_ERR (mxs_phy->regmap_anatop)) { +dev_dbg (&pdev->dev, +"failed to find regmap for anatop\n" ); +return PTR_ERR (mxs_phy->regmap_anatop); + } + } + ret =usb_add_phy_dev (&mxs_phy->phy);if (ret)return ret;
Signature · 1 line
1.7.8
PATCH v5 7/15 usb: phy: add notify suspend and resume callback
In reply to Peter ChenThey are used to notify PHY that the controller enters suspend or finishes resume.
--- include/linux/usb/phy.h | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)
include/linux/usb/phy.h +23 -0
@@ -116,6 +116,11 @@ struct usb_phy { enum usb_device_speed speed);int (*notify_disconnect)(struct usb_phy *x,enum usb_device_speed speed); +int (*notify_suspend)(struct usb_phy *x, +enum usb_device_speed speed); +int (*notify_resume)(struct usb_phy *x, +enum usb_device_speed speed); + };/**
@@ -282,6 +287,24 @@ usb_phy_notify_disconnect(struct usb_phy *x, enum usb_device_speed speed)return 0 ; } +static inline int usb_phy_notify_suspend + (struct usb_phy *x,enum usb_device_speed speed) +{ +if (x && x->notify_suspend) +return x->notify_suspend (x, speed); +else +return 0 ; +} + +static inline int usb_phy_notify_resume + (struct usb_phy *x,enum usb_device_speed speed) +{ +if (x && x->notify_resume) +return x->notify_resume (x, speed); +else +return 0 ; +} +/* notifiers */ static inline int usb_register_notifier (struct usb_phy *x,struct notifier_block *nb)
Signature · 1 line
1.7.8
PATCH v5 8/15 usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
In reply to Peter ChenImplementation of notify_suspend and notify_resume will be different according to mxs_phy_data->flags.
--- drivers/usb/phy/phy-mxs-usb.c | 55 ++++++++++++++++++++++++++++++++++++++--- 1 files changed, 51 insertions(+), 4 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +51 -4
@@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)static int mxs_phy_on_connect (struct usb_phy *phy,enum usb_device_speed speed) { -dev_dbg (phy->dev,"%s speed device has connected\n" , - (speed ==USB_SPEED_HIGH ) ?"high" :"non-high" ); +dev_dbg (phy->dev,"%s device has connected\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" );if (speed ==USB_SPEED_HIGH ) writel(BM_USBPHY_CTRL_ENHOSTDISCONDETECT,
@@ -179,8 +179,8 @@ static int mxs_phy_on_connect(struct usb_phy *phy,static int mxs_phy_on_disconnect (struct usb_phy *phy,enum usb_device_speed speed) { -dev_dbg (phy->dev,"%s speed device has disconnected\n" , - (speed ==USB_SPEED_HIGH ) ?"high" :"non-high" ); +dev_dbg (phy->dev,"%s device has disconnected\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" );if (speed ==USB_SPEED_HIGH ) writel(BM_USBPHY_CTRL_ENHOSTDISCONDETECT,
@@ -189,6 +189,48 @@ static int mxs_phy_on_disconnect(struct usb_phy *phy,return 0 ; } +static int mxs_phy_on_suspend (struct usb_phy *phy, +enum usb_device_speed speed) +{ +struct mxs_phy *mxs_phy =to_mxs_phy (phy); + +dev_dbg (phy->dev,"%s device has suspended\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" ); + +/* delay 4ms to wait bus entering idle */ +usleep_range (4000 ,5000 ); + +if (mxs_phy->data->flags &MXS_PHY_ABNORMAL_IN_SUSPEND ) { +writel_relaxed (0xffffffff , phy->io_priv +HW_USBPHY_PWD ); +writel_relaxed (0 , phy->io_priv +HW_USBPHY_PWD ); + } + +if (speed ==USB_SPEED_HIGH ) +writel_relaxed (BM_USBPHY_CTRL_ENHOSTDISCONDETECT , + phy->io_priv +HW_USBPHY_CTRL_CLR ); + +return 0 ; +} + +/* +* The resume signal must be finished here. +*/ +static int mxs_phy_on_resume (struct usb_phy *phy, +enum usb_device_speed speed) +{ +dev_dbg (phy->dev,"%s device has resumed\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" ); + +if (speed ==USB_SPEED_HIGH ) { +/* Make sure the device has switched to High-Speed mode */ +udelay (500 ); +writel_relaxed (BM_USBPHY_CTRL_ENHOSTDISCONDETECT , + phy->io_priv +HW_USBPHY_CTRL_SET ); + } + +return 0 ; +} +static int mxs_phy_probe (struct platform_device *pdev) {struct resource *res;
@@ -235,6 +277,11 @@ static int mxs_phy_probe(struct platform_device *pdev)platform_set_drvdata (pdev, mxs_phy); +if (mxs_phy->data->flags &MXS_PHY_SENDING_SOF_TOO_FAST ) { + mxs_phy->phy.notify_suspend = mxs_phy_on_suspend; + mxs_phy->phy.notify_resume = mxs_phy_on_resume; + } +if (mxs_phy->data->flags &MXS_PHY_HAS_ANATOP ) { mxs_phy->regmap_anatop =syscon_regmap_lookup_by_phandle (np,"fsl,anatop" );
Signature · 1 line
1.7.8
PATCH v5 8/15 usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
Quoted 13 lines · Peter Chen
Implementation of
notify_suspendandnotify_resumewill be different according tomxs_phy_data->flags.Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 55 ++++++++++++++++++++++++++++++++++++++--- 1 files changed, 51 insertions(+), 4 deletions(-)drivers/usb/phy/phy-mxs-usb.c +0
-0
drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_suspend(struct usb_phy *x, int suspend) · line 170
Quoted 7 lines
drivers/usb/phy/phy-mxs-usb.c +2
-2@@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)static int mxs_phy_on_connect (struct usb_phy *phy,enum usb_device_speed speed) { -dev_dbg (phy->dev,"%s speed device has connected\n" , - (speed ==USB_SPEED_HIGH ) ?"high" :"non-high" ); +dev_dbg (phy->dev,"%s device has connected\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" );
What about creating a mxs_phy_dbg() function that adds the "HS" "FS/LS" prefix when printing?
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/13500789/attachment.sig>
PATCH v5 8/15 usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
Quoted 9 lines · Marc Kleine-Budde
Quoted 8 lines · Peter Chen
Implementation of
notify_suspendandnotify_resumewill be different according tomxs_phy_data->flags.Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 55 ++++++++++++++++++++++++++++++++++++++--- 1 files changed, 51 insertions(+), 4 deletions(-)
Quoted 16 lines
drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_suspend(struct usb_phy *x, int suspend) · line 170
Quoted 12 lines
drivers/usb/phy/phy-mxs-usb.c +2
-2@@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)static int mxs_phy_on_connect (struct usb_phy *phy,enum usb_device_speed speed) { -dev_dbg (phy->dev,"%s speed device has connected\n" , - (speed ==USB_SPEED_HIGH ) ?"high" :"non-high" ); +dev_dbg (phy->dev,"%s device has connected\n" , + (speed ==USB_SPEED_HIGH ) ?"HS" :"FS/LS" );What about creating a
mxs_phy_dbg()function that adds the "HS" "FS/LS" prefix when printing?
No, sometimes, there is no speed information when we want to debug mxs phy.
Signature · 2 lines
Best Regards, Peter Chen
PATCH v5 9/15 usb: phy-mxs: Enable IC fixes for related SoCs
In reply to Peter ChenSome PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver.
--- drivers/usb/phy/phy-mxs-usb.c | 28 ++++++++++++++++++++++++++-- 1 files changed, 26 insertions(+), 2 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +26 -2
@@ -31,6 +31,10 @@#define HW_USBPHY_CTRL_SET 0x34#define HW_USBPHY_CTRL_CLR 0x38 +#define HW_USBPHY_IP 0x90 +#define HW_USBPHY_IP_SET 0x94 +#define HW_USBPHY_IP_CLR 0x98 +#define BM_USBPHY_CTRL_SFTRST BIT(31)#define BM_USBPHY_CTRL_CLKGATE BIT(30)#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)
@@ -42,6 +46,8 @@#define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)#define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1) +#define BM_USBPHY_IP_FIX (BIT(17) | BIT(18)) +#define to_mxs_phy (p) container_of((p), struct mxs_phy, phy)/* Do disconnection between PHY and controller without vbus */
@@ -63,6 +69,9 @@/* The SoCs who have anatop module */ #define MXS_PHY_HAS_ANATOP BIT(3) +/* IC has bug fixes logic */ +#define MXS_PHY_NEED_IP_FIX BIT(4) +struct mxs_phy_data {unsigned int flags; };
@@ -74,12 +83,14 @@ static const struct mxs_phy_data imx23_phy_data = {static const struct mxs_phy_data imx6q_phy_data = { .flags =MXS_PHY_SENDING_SOF_TOO_FAST |MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | -MXS_PHY_HAS_ANATOP , +MXS_PHY_HAS_ANATOP | +MXS_PHY_NEED_IP_FIX , };static const struct mxs_phy_data imx6sl_phy_data = { .flags =MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | -MXS_PHY_HAS_ANATOP , +MXS_PHY_HAS_ANATOP | +MXS_PHY_NEED_IP_FIX , };static const struct of_device_id mxs_phy_dt_ids[] = {
@@ -97,6 +108,16 @@ struct mxs_phy {struct regmap *regmap_anatop; }; +static inline bool is_imx6q_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6q_phy_data; +} + +static inline bool is_imx6sl_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6sl_phy_data; +} +static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;
@@ -123,6 +144,9 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)BM_USBPHY_CTRL_ENUTMILEVEL3 , base + HW_USBPHY_CTRL_SET); +if (mxs_phy->data->flags &MXS_PHY_NEED_IP_FIX ) +writel (BM_USBPHY_IP_FIX , base +HW_USBPHY_IP_SET ); +return 0 ; }
Signature · 1 line
1.7.8
PATCH v5 9/15 usb: phy-mxs: Enable IC fixes for related SoCs
Quoted 2 lines · Peter Chen
Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver.
Which bugs are fixed by enabling this bit? Is it only suspend related? Can you document them or better add a pointer to the documentation.
Further I don't like the idea of adding code, or enabling a feature on certain hardware, that is broken in the first place and fixing it in a later patch. Think about squashing it into the correct patch.
Quoted 59 lines
Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 28 ++++++++++++++++++++++++++-- 1 files changed, 26 insertions(+), 2 deletions(-)drivers/usb/phy/phy-mxs-usb.c +13
-2@@ -31,6 +31,10 @@#define HW_USBPHY_CTRL_SET 0x34#define HW_USBPHY_CTRL_CLR 0x38 +#define HW_USBPHY_IP 0x90 +#define HW_USBPHY_IP_SET 0x94 +#define HW_USBPHY_IP_CLR 0x98 +#define BM_USBPHY_CTRL_SFTRST BIT(31)#define BM_USBPHY_CTRL_CLKGATE BIT(30)#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)@@ -42,6 +46,8 @@#define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)#define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1) +#define BM_USBPHY_IP_FIX (BIT(17) | BIT(18)) +#define to_mxs_phy (p) container_of((p), struct mxs_phy, phy)/* Do disconnection between PHY and controller without vbus */ @@ -63,6 +69,9 @@/* The SoCs who have anatop module */ #define MXS_PHY_HAS_ANATOP BIT(3) +/* IC has bug fixes logic */ +#define MXS_PHY_NEED_IP_FIX BIT(4) +struct mxs_phy_data {unsigned int flags; };@@ -74,12 +83,14 @@ static const struct mxs_phy_data imx23_phy_data = {static const struct mxs_phy_data imx6q_phy_data = { .flags =MXS_PHY_SENDING_SOF_TOO_FAST |MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | -MXS_PHY_HAS_ANATOP , +MXS_PHY_HAS_ANATOP | +MXS_PHY_NEED_IP_FIX , };static const struct mxs_phy_data imx6sl_phy_data = { .flags =MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | -MXS_PHY_HAS_ANATOP , +MXS_PHY_HAS_ANATOP | +MXS_PHY_NEED_IP_FIX , };static const struct of_device_id mxs_phy_dt_ids[] = {@@ -97,6 +108,16 @@ struct mxs_phy {struct regmap *regmap_anatop; };
drivers/usb/phy/phy-mxs-usb.c struct mxs_phy { · line 119
Quoted 10 lines
drivers/usb/phy/phy-mxs-usb.c +9
-0+static inline bool is_imx6q_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6q_phy_data; +} + +static inline bool is_imx6sl_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6sl_phy_data; +}
Are the two is_imx6* functions still needed?
drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_hw_init(struct mxs_phy *mxs_phy) · line 151
Quoted 13 lines
drivers/usb/phy/phy-mxs-usb.c +4
-0+static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;@@ -123,6 +144,9 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)BM_USBPHY_CTRL_ENUTMILEVEL3 , base + HW_USBPHY_CTRL_SET); +if (mxs_phy->data->flags &MXS_PHY_NEED_IP_FIX ) +writel (BM_USBPHY_IP_FIX , base +HW_USBPHY_IP_SET ); +return 0 ; }
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/9242f466/attachment.sig>
PATCH v5 9/15 usb: phy-mxs: Enable IC fixes for related SoCs
Quoted 6 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver.
Which bugs are fixed by enabling this bit? Is it only suspend related? Can you document them or better add a pointer to the documentation.
I will add more, in fact, it fixes the bug which flag BIT(1) and BIT(2) stands for.
Quoted 4 lines
Further I don't like the idea of adding code, or enabling a feature on certain hardware, that is broken in the first place and fixing it in a later patch. Think about squashing it into the correct patch.
No fixes are related with this patch, you can see there is no "-" at this patch.
Quoted 12 lines
drivers/usb/phy/phy-mxs-usb.c struct mxs_phy { · line 119
Quoted 10 lines
drivers/usb/phy/phy-mxs-usb.c +9
-0+static inline bool is_imx6q_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6q_phy_data; +} + +static inline bool is_imx6sl_phy (struct mxs_phy *mxs_phy) +{ +return mxs_phy->data == &imx6sl_phy_data; +}Are the two is_imx6* functions still needed?
Will more it to [14/15], they are needed there.
Peter
Quoted 23 lines
Quoted 6 lines
drivers/usb/phy/phy-mxs-usb.c +1
-0+static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_hw_init(struct mxs_phy *mxs_phy) · line 151
Quoted 8 lines
drivers/usb/phy/phy-mxs-usb.c +3
-0@@ -123,6 +144,9 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)BM_USBPHY_CTRL_ENUTMILEVEL3 , base + HW_USBPHY_CTRL_SET); +if (mxs_phy->data->flags &MXS_PHY_NEED_IP_FIX ) +writel (BM_USBPHY_IP_FIX , base +HW_USBPHY_IP_SET ); +return 0 ; }Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Signature · 2 lines
Best Regards, Peter Chen
PATCH v5 9/15 usb: phy-mxs: Enable IC fixes for related SoCs
Quoted 12 lines · Peter Chen
Quoted 6 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver.
Which bugs are fixed by enabling this bit? Is it only suspend related? Can you document them or better add a pointer to the documentation.
I will add more, in fact, it fixes the bug which flag BIT(1) and BIT(2) stands for.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Further I don't like the idea of adding code, or enabling a feature on certain hardware, that is broken in the first place and fixing it in a later patch. Think about squashing it into the correct patch.
No fixes are related with this patch, you can see there is no "-" at this patch.
Yes, there isn't any broken code (thus no "-"), but you first enable a feature in the hardware and in a later patch (this one) make it work properly.
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/6e0b29e2/attachment-0001.sig>
PATCH v5 9/15 usb: phy-mxs: Enable IC fixes for related SoCs
Quoted 17 lines · Marc Kleine-Budde
Quoted 16 lines · Peter Chen
Quoted 6 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver.
Which bugs are fixed by enabling this bit? Is it only suspend related? Can you document them or better add a pointer to the documentation.
I will add more, in fact, it fixes the bug which flag BIT(1) and BIT(2) stands for.
Quoted 4 lines
Further I don't like the idea of adding code, or enabling a feature on certain hardware, that is broken in the first place and fixing it in a later patch. Think about squashing it into the correct patch.
Quoted 7 lines
Quoted 2 lines
No fixes are related with this patch, you can see there is no "-" at this patch.
Yes, there isn't any broken code (thus no "-"), but you first enable a feature in the hardware and in a later patch (this one) make it work properly.
Sorry? I haven't enabled related hardware feature at previous patches. These two bits are enable bit, we just need to enable it.
Signature · 2 lines
Best Regards, Peter Chen
PATCH v5 10/15 ARM: dts: imx: add mxs phy controller id
In reply to Peter ChenWe need to use controller id to access different register regions for mxs phy.
--- arch/arm/boot/dts/imx23.dtsi | 1 + arch/arm/boot/dts/imx28.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl.dtsi | 2 ++ arch/arm/boot/dts/imx6sl.dtsi | 2 ++ 4 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/boot/dts/imx23.dtsi +1 -0
@@ -23,6 +23,7 @@ serial1 = &auart1; spi0 = &ssp0; spi1 = &ssp1; + usbphy0 = &usbphy0; }; cpus {
arch/arm/boot/dts/imx28.dtsi +2 -0
@@ -32,6 +32,8 @@ serial4 = &auart4; spi0 = &ssp1; spi1 = &ssp2; + usbphy0 = &usbphy0; + usbphy1 = &usbphy1; }; cpus {
arch/arm/boot/dts/imx6qdl.dtsi +2 -0
@@ -33,6 +33,8 @@ spi1 = &ecspi2; spi2 = &ecspi3; spi3 = &ecspi4; + usbphy0 = &usbphy1; + usbphy1 = &usbphy2; }; intc: interrupt-controller at 00a01000 {
arch/arm/boot/dts/imx6sl.dtsi +2 -0
@@ -27,6 +27,8 @@ spi1 = &ecspi2; spi2 = &ecspi3; spi3 = &ecspi4; + usbphy0 = &usbphy1; + usbphy1 = &usbphy2; }; cpus {
Signature · 1 line
1.7.8
PATCH v5 11/15 usb: phy-mxs: add controller id
In reply to Peter ChenIt is used to access un-regulator registers according to different controllers.
--- drivers/usb/phy/phy-mxs-usb.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +8 -0
@@ -106,6 +106,7 @@ struct mxs_phy {struct clk *clk;const struct mxs_phy_data *data;struct regmap *regmap_anatop; +int port_id; };static inline bool is_imx6q_phy (struct mxs_phy *mxs_phy)
@@ -284,6 +285,13 @@ static int mxs_phy_probe(struct platform_device *pdev)return -ENOMEM ; } + ret =of_alias_get_id (np,"usbphy" ); +if (ret <0 ) { +dev_err (&pdev->dev,"failed to get alias id, errno %d\n" , ret); +return ret; + } + mxs_phy->port_id = ret; + mxs_phy->phy.io_priv = base; mxs_phy->phy.dev = &pdev->dev; mxs_phy->phy.label =DRIVER_NAME ;
Signature · 1 line
1.7.8
PATCH v5 12/15 usb: phy: Add set_wakeup API
In reply to Peter ChenThis API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change.
--- include/linux/usb/phy.h | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-)
include/linux/usb/phy.h +16 -0
@@ -111,6 +111,13 @@ struct usb_phy {int (*set_suspend)(struct usb_phy *x,int suspend); +/* +* Set wakeup enable for PHY, in that case, the PHY can be +* waken up from suspend status due to external events, +* like vbus change, dp/dm change and id. +*/ +int (*set_wakeup)(struct usb_phy *x,bool enabled); +/* notify phy connect status change */ int (*notify_connect)(struct usb_phy *x,enum usb_device_speed speed);
@@ -270,6 +277,15 @@ usb_phy_set_suspend(struct usb_phy *x, int suspend) }static inline int +usb_phy_set_wakeup (struct usb_phy *x,bool enabled) +{ +if (x && x->set_wakeup) +return x->set_wakeup (x, enabled); +else +return 0 ; +} + +static inline int usb_phy_notify_connect (struct usb_phy *x,enum usb_device_speed speed) {if (x && x->notify_connect)
Signature · 1 line
1.7.8
PATCH v5 12/15 usb: phy: Add set_wakeup API
Quoted 2 lines · Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events,
I' no native speaker, but I think it's "to be woken up".
Quoted 26 lines
like vbus change, dp/dm change and id change.
Signed-off-by Peter Chen <[email protected]>--- include/linux/usb/phy.h | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-)include/linux/usb/phy.h +7
-0@@ -111,6 +111,13 @@ struct usb_phy {int (*set_suspend)(struct usb_phy *x,int suspend); +/* +* Set wakeup enable for PHY, in that case, the PHY can be +* waken up from suspend status due to external events, +* like vbus change, dp/dm change and id. +*/ +int (*set_wakeup)(struct usb_phy *x,bool enabled); +/* notify phy connect status change */ int (*notify_connect)(struct usb_phy *x,enum usb_device_speed speed);
include/linux/usb/phy.h usb_phy_set_suspend(struct usb_phy *x, int suspend) · line 282
Quoted 6 lines
include/linux/usb/phy.h +3
-0@@ -270,6 +277,15 @@ usb_phy_set_suspend(struct usb_phy *x, int suspend) }static inline int +usb_phy_set_wakeup (struct usb_phy *x,bool enabled) +{ +if (x && x->set_wakeup)
can x be NULL?
include/linux/usb/phy.h usb_phy_set_suspend(struct usb_phy *x, int suspend) · line 291
Quoted 10 lines
include/linux/usb/phy.h +6
-0+return x->set_wakeup (x, enabled); + else + return 0; +} + +static inline int usb_phy_notify_connect (struct usb_phy *x,enum usb_device_speed speed) {if (x && x->notify_connect)
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/b30773b6/attachment.sig>
PATCH v5 12/15 usb: phy: Add set_wakeup API
Quoted 5 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events,
I' no native speaker, but I think it's "to be woken up".
Thanks, will change.
Quoted 8 lines
include/linux/usb/phy.h usb_phy_set_suspend(struct usb_phy *x, int suspend) · line 282
Quoted 5 lines
static inline int
include/linux/usb/phy.h +3
-0+usb_phy_set_wakeup(struct usb_phy *x, bool enabled) +{ +if (x && x->set_wakeup)can x be NULL?
Possible, this function is PHY's API, it may be called uninitialized.
Peter
Quoted 19 lines
include/linux/usb/phy.h usb_phy_set_suspend(struct usb_phy *x, int suspend) · line 291
Quoted 10 lines
include/linux/usb/phy.h +6
-0+return x->set_wakeup (x, enabled); + else + return 0; +} + +static inline int usb_phy_notify_connect (struct usb_phy *x,enum usb_device_speed speed) {if (x && x->notify_connect)Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Signature · 2 lines
Best Regards, Peter Chen
PATCH v5 13/15 usb: phy-mxs: Add implementation of set_wakeup
In reply to Peter ChenWhen we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is SE0. Once the PHY is out of power, without calling mxs_phy_disconnect_line, there are unknown wakeups due to dp/dm floating at device mode.
--- drivers/usb/phy/phy-mxs-usb.c | 116 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 116 insertions(+), 0 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +116 -0
@@ -31,6 +31,9 @@#define HW_USBPHY_CTRL_SET 0x34#define HW_USBPHY_CTRL_CLR 0x38 +#define HW_USBPHY_DEBUG_SET 0x54 +#define HW_USBPHY_DEBUG_CLR 0x58 +#define HW_USBPHY_IP 0x90#define HW_USBPHY_IP_SET 0x94#define HW_USBPHY_IP_CLR 0x98
@@ -39,6 +42,9 @@#define BM_USBPHY_CTRL_CLKGATE BIT(30)#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)#define BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE BIT(25) +#define BM_USBPHY_CTRL_ENVBUSCHG_WKUP BIT(23) +#define BM_USBPHY_CTRL_ENIDCHG_WKUP BIT(22) +#define BM_USBPHY_CTRL_ENDPDMCHG_WKUP BIT(21)#define BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD BIT(20)#define BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE BIT(19)#define BM_USBPHY_CTRL_ENAUTO_PWRON_PLL BIT(18)
@@ -48,6 +54,25 @@#define BM_USBPHY_IP_FIX (BIT(17) | BIT(18)) +#define BM_USBPHY_DEBUG_CLKGATE BIT(30) + +/* Anatop Registers */ +#define ANADIG_USB1_VBUS_DET_STAT 0x1c0 +#define ANADIG_USB2_VBUS_DET_STAT 0x220 + +#define ANADIG_USB1_LOOPBACK_SET 0x1e4 +#define ANADIG_USB1_LOOPBACK_CLR 0x1e8 +#define ANADIG_USB2_LOOPBACK_SET 0x244 +#define ANADIG_USB2_LOOPBACK_CLR 0x248 + +#define BM_ANADIG_USB1_VBUS_DET_STAT_VBUS_VALID BIT(3) +#define BM_ANADIG_USB2_VBUS_DET_STAT_VBUS_VALID BIT(3) + +#define BM_ANADIG_USB1_LOOPBACK_UTMI_DIG_TST1 BIT(2) +#define BM_ANADIG_USB1_LOOPBACK_TSTI_TX_EN BIT(5) +#define BM_ANADIG_USB2_LOOPBACK_UTMI_DIG_TST1 BIT(2) +#define BM_ANADIG_USB2_LOOPBACK_TSTI_TX_EN BIT(5) +#define to_mxs_phy (p) container_of((p), struct mxs_phy, phy)/* Do disconnection between PHY and controller without vbus */
@@ -151,6 +176,79 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)return 0 ; } +/* Return true if the vbus is there */ +static bool mxs_phy_get_vbus_status (struct mxs_phy *mxs_phy) +{ +unsigned int vbus_value; + +if (mxs_phy->port_id ==0 ) +regmap_read (mxs_phy->regmap_anatop, +ANADIG_USB1_VBUS_DET_STAT , + &vbus_value); +else if (mxs_phy->port_id ==1 ) +regmap_read (mxs_phy->regmap_anatop, +ANADIG_USB2_VBUS_DET_STAT , + &vbus_value); + +if (vbus_value &BM_ANADIG_USB1_VBUS_DET_STAT_VBUS_VALID ) +return true; +else +return false; +} + +static void __mxs_phy_disconnect_line (struct mxs_phy *mxs_phy,bool disconnect) +{ +void __iomem *base = mxs_phy->phy.io_priv; +u32 reg; + +if (disconnect) +writel_relaxed (BM_USBPHY_DEBUG_CLKGATE , + base +HW_USBPHY_DEBUG_CLR ); + +if (mxs_phy->port_id ==0 ) { + reg = disconnect ?ANADIG_USB1_LOOPBACK_SET + :ANADIG_USB1_LOOPBACK_CLR ; +regmap_write (mxs_phy->regmap_anatop, reg, +BM_ANADIG_USB1_LOOPBACK_UTMI_DIG_TST1 | +BM_ANADIG_USB1_LOOPBACK_TSTI_TX_EN ); + }else if (mxs_phy->port_id ==1 ) { + reg = disconnect ?ANADIG_USB2_LOOPBACK_SET + :ANADIG_USB2_LOOPBACK_CLR ; +regmap_write (mxs_phy->regmap_anatop, reg, +BM_ANADIG_USB2_LOOPBACK_UTMI_DIG_TST1 | +BM_ANADIG_USB2_LOOPBACK_TSTI_TX_EN ); + } + +if (!disconnect) +writel_relaxed (BM_USBPHY_DEBUG_CLKGATE , + base +HW_USBPHY_DEBUG_SET ); + +/* Delay some time, and let Linestate be SE0 for controller */ +if (disconnect) +usleep_range (500 ,1000 ); +} + +static void mxs_phy_disconnect_line (struct mxs_phy *mxs_phy,bool on) +{ +bool vbus_is_on = false; + +/* If the SoCs don't need to disconnect line without vbus, quit */ +if (!(mxs_phy->data->flags &MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS )) +return ; + +/* If the SoCs don't have anatop, quit */ +if (!mxs_phy->regmap_anatop) +return ; + + vbus_is_on =mxs_phy_get_vbus_status (mxs_phy); + +if (on && !vbus_is_on) +__mxs_phy_disconnect_line (mxs_phy, true); +else +__mxs_phy_disconnect_line (mxs_phy, false); + +} +static int mxs_phy_init (struct usb_phy *phy) {struct mxs_phy *mxs_phy =to_mxs_phy (phy);
@@ -188,6 +286,23 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)return 0 ; } +static int mxs_phy_set_wakeup (struct usb_phy *x,bool enabled) +{ +struct mxs_phy *mxs_phy =to_mxs_phy (x); +u32 value =BM_USBPHY_CTRL_ENVBUSCHG_WKUP | +BM_USBPHY_CTRL_ENDPDMCHG_WKUP | +BM_USBPHY_CTRL_ENIDCHG_WKUP ; +if (enabled) { +mxs_phy_disconnect_line (mxs_phy, true); +writel_relaxed (value, x->io_priv +HW_USBPHY_CTRL_SET ); + }else { +writel_relaxed (value, x->io_priv +HW_USBPHY_CTRL_CLR ); +mxs_phy_disconnect_line (mxs_phy, false); + } + +return 0 ; +} +static int mxs_phy_on_connect (struct usb_phy *phy,enum usb_device_speed speed) {
@@ -301,6 +416,7 @@ static int mxs_phy_probe(struct platform_device *pdev) mxs_phy->phy.notify_connect = mxs_phy_on_connect; mxs_phy->phy.notify_disconnect = mxs_phy_on_disconnect; mxs_phy->phy.type =USB_PHY_TYPE_USB2 ; + mxs_phy->phy.set_wakeup = mxs_phy_set_wakeup;ATOMIC_INIT_NOTIFIER_HEAD (&mxs_phy->phy.notifier);
Signature · 1 line
1.7.8
PATCH v5 14/15 usb: phy-mxs: Add system suspend/resume API
In reply to Peter ChenWe need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power.
--- drivers/usb/phy/phy-mxs-usb.c | 48 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +48 -0
@@ -57,6 +57,10 @@#define BM_USBPHY_DEBUG_CLKGATE BIT(30)/* Anatop Registers */ +#define ANADIG_ANA_MISC0 0x150 +#define ANADIG_ANA_MISC0_SET 0x154 +#define ANADIG_ANA_MISC0_CLR 0x158 +#define ANADIG_USB1_VBUS_DET_STAT 0x1c0#define ANADIG_USB2_VBUS_DET_STAT 0x220
@@ -65,6 +69,9 @@#define ANADIG_USB2_LOOPBACK_SET 0x244#define ANADIG_USB2_LOOPBACK_CLR 0x248 +#define BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG BIT(12) +#define BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG_SL BIT(11) +#define BM_ANADIG_USB1_VBUS_DET_STAT_VBUS_VALID BIT(3)#define BM_ANADIG_USB2_VBUS_DET_STAT_VBUS_VALID BIT(3)
@@ -249,6 +256,22 @@ static void mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool on) } +static void mxs_phy_enable_ldo_in_suspend (struct mxs_phy *mxs_phy,bool on) +{ +unsigned int reg = on ?ANADIG_ANA_MISC0_SET :ANADIG_ANA_MISC0_CLR ; + +/* If the SoCs don't have anatop, quit */ +if (!mxs_phy->regmap_anatop) +return ; + +if (is_imx6q_phy (mxs_phy)) +regmap_write (mxs_phy->regmap_anatop, reg, +BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG ); +else if (is_imx6sl_phy (mxs_phy)) +regmap_write (mxs_phy->regmap_anatop, + reg,BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG_SL ); +} +static int mxs_phy_init (struct usb_phy *phy) {struct mxs_phy *mxs_phy =to_mxs_phy (phy);
@@ -440,6 +463,8 @@ static int mxs_phy_probe(struct platform_device *pdev) } } +device_set_wakeup_capable (&pdev->dev, true); + ret =usb_add_phy_dev (&mxs_phy->phy);if (ret)return ret;
@@ -456,6 +481,28 @@ static int mxs_phy_remove(struct platform_device *pdev)return 0 ; } +static int mxs_phy_system_suspend (struct device *dev) +{ +struct mxs_phy *mxs_phy =dev_get_drvdata (dev); + +if (device_may_wakeup (dev)) +mxs_phy_enable_ldo_in_suspend (mxs_phy, true); + +return 0 ; +} + +static int mxs_phy_system_resume (struct device *dev) +{ +struct mxs_phy *mxs_phy =dev_get_drvdata (dev); + +if (device_may_wakeup (dev)) +mxs_phy_enable_ldo_in_suspend (mxs_phy, false); + +return 0 ; +} + +SIMPLE_DEV_PM_OPS (mxs_phy_pm, mxs_phy_system_suspend, mxs_phy_system_resume); +static struct platform_driver mxs_phy_driver = { .probe = mxs_phy_probe, .remove = mxs_phy_remove,
@@ -463,6 +510,7 @@ static struct platform_driver mxs_phy_driver = { .name = DRIVER_NAME, .owner = THIS_MODULE, .of_match_table = mxs_phy_dt_ids, + .pm = &mxs_phy_pm, }, };
Signature · 1 line
1.7.8
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
In reply to Peter ChenAfter clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
--- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/usb/phy/phy-mxs-usb.c +11 -0
@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)return mxs_phy->data == &imx6sl_phy_data; } +/* +* PHY needs some 32K cycles to switch from 32K clock to +* bus (such as AHB/AXI, etc) clock. +*/ +static void mxs_phy_clock_switch (void ) +{ +usleep_range (300 ,400 ); +} +static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;
@@ -276,6 +285,7 @@ static int mxs_phy_init(struct usb_phy *phy) {struct mxs_phy *mxs_phy =to_mxs_phy (phy); +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);return mxs_phy_hw_init (mxs_phy); }
@@ -300,6 +310,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) x->io_priv + HW_USBPHY_CTRL_SET);clk_disable_unprepare (mxs_phy->clk); }else { +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);writel (BM_USBPHY_CTRL_CLKGATE , x->io_priv +HW_USBPHY_CTRL_CLR );
Signature · 1 line
1.7.8
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
Quoted 2 lines · Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
If this is a general bugbix, please move it to the start of this series and add stable on Cc. I think I hit the bug on the second USB port of a custom MX28 board, the stmp_reset_block() in the USB phy will fail.
Is the problem documented somewhere?
Is it possible to add the delay in the clock framework? I think only the regulator framework has a configurable delay for the regulator to stabilize.
Quoted 35 lines
Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)drivers/usb/phy/phy-mxs-usb.c +10
-0@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)return mxs_phy->data == &imx6sl_phy_data; } +/* +* PHY needs some 32K cycles to switch from 32K clock to +* bus (such as AHB/AXI, etc) clock. +*/ +static void mxs_phy_clock_switch (void ) +{ +usleep_range (300 ,400 ); +} +static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;@@ -276,6 +285,7 @@ static int mxs_phy_init(struct usb_phy *phy) {struct mxs_phy *mxs_phy =to_mxs_phy (phy); +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);return mxs_phy_hw_init (mxs_phy); }
drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_suspend(struct usb_phy *x, int suspend) · line 316
Quoted 7 lines
drivers/usb/phy/phy-mxs-usb.c +1
-0@@ -300,6 +310,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) x->io_priv + HW_USBPHY_CTRL_SET);clk_disable_unprepare (mxs_phy->clk); }else { +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);writel (BM_USBPHY_CTRL_CLKGATE , x->io_priv +HW_USBPHY_CTRL_CLR );
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/2a1a086e/attachment.sig>
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
Quoted 7 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
If this is a general bugbix, please move it to the start of this series and add stable on Cc. I think I hit the bug on the second USB port of a custom MX28 board, the
stmp_reset_block()in the USB phy will fail.
Not a bug-fix, just the requirement for the PHY leaves low power mode. Does the bug exists with my this patchset, or just current mainline code?
Quoted 5 lines
Is the problem documented somewhere?
Is it possible to add the delay in the clock framework? I think only the regulator framework has a configurable delay for the regulator to stabilize.
It is just related to mxs PHY's hardware timing. It is better to add it at specific driver.
Peter
Quoted 51 lines
Quoted 36 lines
Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)drivers/usb/phy/phy-mxs-usb.c +10
-0@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)return mxs_phy->data == &imx6sl_phy_data; } +/* +* PHY needs some 32K cycles to switch from 32K clock to +* bus (such as AHB/AXI, etc) clock. +*/ +static void mxs_phy_clock_switch (void ) +{ +usleep_range (300 ,400 ); +} +static int mxs_phy_hw_init (struct mxs_phy *mxs_phy) {int ret;@@ -276,6 +285,7 @@ static int mxs_phy_init(struct usb_phy *phy) {struct mxs_phy *mxs_phy =to_mxs_phy (phy); +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);return mxs_phy_hw_init (mxs_phy); }drivers/usb/phy/phy-mxs-usb.c static int mxs_phy_suspend(struct usb_phy *x, int suspend) · line 316
Quoted 7 lines
drivers/usb/phy/phy-mxs-usb.c +1
-0@@ -300,6 +310,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) x->io_priv + HW_USBPHY_CTRL_SET);clk_disable_unprepare (mxs_phy->clk); }else { +mxs_phy_clock_switch ();clk_prepare_enable (mxs_phy->clk);writel (BM_USBPHY_CTRL_CLKGATE , x->io_priv +HW_USBPHY_CTRL_CLR );Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Signature · 2 lines
Best Regards, Peter Chen
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
Quoted 11 lines · Peter Chen
Quoted 7 lines · Marc Kleine-Budde
Quoted 2 lines · Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
If this is a general bugbix, please move it to the start of this series and add stable on Cc. I think I hit the bug on the second USB port of a custom MX28 board, the
stmp_reset_block()in the USB phy will fail.Not a bug-fix, just the requirement for the PHY leaves low power mode. Does the bug exists with my this patchset, or just current mainline code?
I see, I found this strange thing on v3.8, but can try on v3.13-rc3.
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/9b6bb951/attachment.sig>
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
In reply to Peter ChenHello.
Quoted 15 lines · Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)drivers/usb/phy/phy-mxs-usb.c +0
-0@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)return mxs_phy->data == &imx6sl_phy_data; }
drivers/usb/phy/phy-mxs-usb.c static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy) · line 162
Quoted 10 lines
drivers/usb/phy/phy-mxs-usb.c +9
-0+/* +* PHY needs some 32K cycles to switch from 32K clock to +* bus (such as AHB/AXI, etc) clock. +*/ +static void mxs_phy_clock_switch (void ) +{ +usleep_range (300 ,400 ); +} +
Don't think this is a good name for this function since it doesn't really
switch anything, just waits. I'd suggest something like mxs_phy_clock_switch_delay().
WBR, Sergei
PATCH v5 15/15 usb: phy-mxs: Add sync time after controller clear phcd
Quoted 20 lines · Sergei Shtylyov
Hello.
Quoted 16 lines · Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock.
Signed-off-by Peter Chen <[email protected]>--- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)drivers/usb/phy/phy-mxs-usb.c +0
-0@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)return mxs_phy->data == &imx6sl_phy_data; }
Quoted 14 lines
drivers/usb/phy/phy-mxs-usb.c static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy) · line 162
Quoted 9 lines
drivers/usb/phy/phy-mxs-usb.c +9
-0+/* +* PHY needs some 32K cycles to switch from 32K clock to +* bus (such as AHB/AXI, etc) clock. +*/ +static void mxs_phy_clock_switch (void ) +{ +usleep_range (300 ,400 ); +} +Don't think this is a good name for this function since it
doesn't really switch anything, just waits. I'd suggest something likemxs_phy_clock_switch_delay().
Thanks, I will change.
Signature · 2 lines
Best Regards, Peter Chen