Skip to contentSkip to conversation

phy: omap_usb2: fix module dependency

PATCH New Felipe Balbi 3 participants 3 messages Dec 10, 2013 – Dec 11, 2013 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: omap_usb2: fix module dependency

Due to over-use of select statements, we could fall into a situation where CONFIG_USB_PHY would be enabled while CONFIG_USB_SUPPORT wouldn't.

This would generate a situation where usb_bind_phy() would not be defined and kernel build for some OMAP2PLUS platforms would fail.

Fix this by replacing a 'select' with a more proper 'depends on'.

---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index a344f3d..d8b1a9a 100644
@@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on OMAP_CONTROL_USB
 	select GENERIC_PHY
 	select USB_PHY
-	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
 	  driver takes care of all the PHY functionality apart from comparator.
Signature · 1 line
1.8.4.GIT
#1 lore raw

PATCH 1/1 phy: omap_usb2: fix module dependency

Quoted 10 lines · Felipe Balbi

Due to over-use of select statements, we could fall into a situation where CONFIG_USB_PHY would be enabled while CONFIG_USB_SUPPORT wouldn't.

This would generate a situation where usb_bind_phy() would not be defined and kernel build for some OMAP2PLUS platforms would fail.

Fix this by replacing a 'select' with a more proper 'depends on'.

Do we also need to update omap2plus_defconfig to select OMAP_CONTROL_USB in this patch?

Regards,

Tony

Quoted 24 lines
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index a344f3d..d8b1a9a 100644
@@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on OMAP_CONTROL_USB
 	select GENERIC_PHY
 	select USB_PHY
-	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
 	  driver takes care of all the PHY functionality apart from comparator.
Signature · 1 line
1.8.4.GIT
#2 lore raw

PATCH 1/1 phy: omap_usb2: fix module dependency

In reply to Felipe Balbi

Hi Felipe,

Quoted 10 lines · Felipe Balbi

Due to over-use of select statements, we could fall into a situation where CONFIG_USB_PHY would be enabled while CONFIG_USB_SUPPORT wouldn't.

This would generate a situation where usb_bind_phy() would not be defined and kernel build for some OMAP2PLUS platforms would fail.

Fix this by replacing a 'select' with a more proper 'depends on'.

last week I sent a patch changing it to depends on USB_PHY and Greg has merged it yesterday so it should come in -rc4. Do you think this patch will also be needed?

Thanks
Kishon

Quoted 23 lines
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index a344f3d..d8b1a9a 100644
@@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on OMAP_CONTROL_USB
 	select GENERIC_PHY
 	select USB_PHY
-	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
 	  driver takes care of all the PHY functionality apart from comparator.