Skip to contentSkip to conversation

spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map.

PATCH Applied Hou Zhiqiang 3 participants 3 messages Dec 11, 2013 1 message not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map.

---
 drivers/spi/spi-fsl-espi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-fsl-espi.c +1 -1
index 80d8f40..8106006 100644
@@ -705,7 +705,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
 		goto err;
 
 	irq = irq_of_parse_and_map(np, 0);
-	if (!ret) {
+	if (!irq) {
 		ret = -EINVAL;
 		goto err;
 	}
Signature · 7 lines
1.8.4.1


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org

Acked-by
#2 lore raw
Quoted 10 lines · Hou Zhiqiang
---
 drivers/spi/spi-fsl-espi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-fsl-espi.c +0 -0
index 80d8f40..8106006 100644

drivers/spi/spi-fsl-espi.c static int of_fsl_espi_probe(struct platform_device *ofdev) · line 711

Quoted 8 lines
drivers/spi/spi-fsl-espi.c +1 -1
@@ -705,7 +705,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
                goto err;
 
        irq = irq_of_parse_and_map(np, 0);
-       if (!ret) {
+       if (!irq) {
                ret = -EINVAL;
                goto err;
        }

Obviously correct.

Quoted 4 lines

--
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html