Skip to contentSkip to conversation

ARM: tegra: add missing break to fuse initialization code

PATCH Superseded Stephen Warren 3 participants 3 messages Dec 6, 2013 – Dec 12, 2013

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: add missing break to fuse initialization code

From: Stephen Warren <[email protected]>

Add a missing break to the switch in tegra_init_fuse() which determines which SoC the code is running on. This prevents the Tegra30+ fuse handling code from running on Tegra20.

Fixes 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")

---
This is a fix for 3.13.

 arch/arm/mach-tegra/fuse.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/fuse.c +1 -0
index 9a4e910c3796..13995b0be9d9 100644
@@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
 	switch (tegra_chip_id) {
 	case TEGRA20:
 		tegra20_fuse_init_randomness();
+		break;
 	case TEGRA30:
 	case TEGRA114:
 	default:
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 ARM: tegra: add missing break to fuse initialization code

Quoted 19 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Add a missing break to the switch in tegra_init_fuse() which determines which SoC the code is running on. This prevents the Tegra30+ fuse handling code from running on Tegra20.

Fixes 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")

---
This is a fix for 3.13.

 arch/arm/mach-tegra/fuse.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/fuse.c +0 -0
index 9a4e910c3796..13995b0be9d9 100644

arch/arm/mach-tegra/fuse.c void __init tegra_init_fuse(void) · line 204

Quoted 7 lines
arch/arm/mach-tegra/fuse.c +1 -0
@@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
 	switch (tegra_chip_id) {
 	case TEGRA20:
 		tegra20_fuse_init_randomness();
+		break;
 	case TEGRA30:
 	case TEGRA114:
 	default:

The code that follows here also doesn't have a break. While not strictly necessary it might be good to have one for consistency. Either way, though:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/55e25ca4/attachment.sig>

#2 lore raw

PATCH 1/1 ARM: tegra: add missing break to fuse initialization code

Quoted 32 lines · Thierry Reding
Quoted 19 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Add a missing break to the switch in tegra_init_fuse() which determines which SoC the code is running on. This prevents the Tegra30+ fuse handling code from running on Tegra20.

Fixes 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")

---
This is a fix for 3.13.

 arch/arm/mach-tegra/fuse.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/fuse.c +0 -0
index 9a4e910c3796..13995b0be9d9 100644

arch/arm/mach-tegra/fuse.c void __init tegra_init_fuse(void) · line 204

Quoted 7 lines
arch/arm/mach-tegra/fuse.c +1 -0
@@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
 	switch (tegra_chip_id) {
 	case TEGRA20:
 		tegra20_fuse_init_randomness();
+		break;
 	case TEGRA30:
 	case TEGRA114:
 	default:

The code that follows here also doesn't have a break. While not strictly necessary it might be good to have one for consistency. Either way, though:

Quoted 1 line

Applied, thanks.

-Olof