Skip to contentSkip to conversation

ARM: tegra: add missing break to fuse initialization code

PATCH New Stephen Warren 2 participants 2 messages Dec 6, 2013 – Dec 12, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: tegra: add missing break to fuse initialization code

From: Stephen Warren <[email protected]>

Add a missing break to the switch in tegra_init_fuse() which determines which SoC the code is running on. This prevents the Tegra30+ fuse handling code from running on Tegra20.

Fixes 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")

---
v2: Add break to all cases

---
 arch/arm/mach-tegra/fuse.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-tegra/fuse.c +2 -0
index 9a4e910c3796..3a9c1f1c219d 100644
@@ -198,10 +198,12 @@ void __init tegra_init_fuse(void)
 	switch (tegra_chip_id) {
 	case TEGRA20:
 		tegra20_fuse_init_randomness();
+		break;
 	case TEGRA30:
 	case TEGRA114:
 	default:
 		tegra30_fuse_init_randomness();
+		break;
 	}
 
 	pr_info("Tegra Revision: %s SKU: %d CPU Process: %d Core Process: %d\n",
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v2 1/1 ARM: tegra: add missing break to fuse initialization code

Quoted 21 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Add a missing break to the switch in tegra_init_fuse() which determines which SoC the code is running on. This prevents the Tegra30+ fuse handling code from running on Tegra20.

Fixes 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")

---
v2: Add break to all cases

---
 arch/arm/mach-tegra/fuse.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-tegra/fuse.c +0 -0
index 9a4e910c3796..3a9c1f1c219d 100644
@@ -198,10 +198,12 @@ void __init tegra_init_fuse(void)
 	switch (tegra_chip_id) {
 	case TEGRA20:

arch/arm/mach-tegra/fuse.c void __init tegra_init_fuse(void) · line 209

Quoted 10 lines
arch/arm/mach-tegra/fuse.c +2 -0
 		tegra20_fuse_init_randomness();
+		break;
 	case TEGRA30:
 	case TEGRA114:
 	default:
 		tegra30_fuse_init_randomness();
+		break;
 	}
 
 	pr_info("Tegra Revision: %s SKU: %d CPU Process: %d Core Process: %d\n",

Ah, yes, dropped previous version and applied this.

-Olof