Skip to contentSkip to conversation

perf symbols: symbol-minimal.c causes random fd to be closed

PATCH In review Anton Blanchard 2 participants 2 messages Dec 12, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf symbols: symbol-minimal.c causes random fd to be closed

I hit a cryptic failure when testing a recent version of perf:

  # perf report
  write failure on standard output: Bad file descriptor

The issue is in commit b68e2f91 (perf symbols: Introduce symsrc structure). symsrc__destroy() does a close(ss->fd) but ss->fd is only initialised in the symbol-elf.c case and not for symbol-minimal.c.

The issue has been around for a while however most people will build with libelf which wont use the symbol-minimal.c code.

---

tools/perf/util/symbol-minimal.c +1 -0
index 2d2dd05..3528204 100644
@@ -254,6 +254,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso __maybe_unused,
 		goto out_close;
 
 	ss->type = type;
+	ss->fd = fd;
 
 	return 0;
 out_close:
#1 lore raw

Em Thu, Dec 12, 2013 at 01:47:25PM +1100, Anton Blanchard escreveu:

Quoted 12 lines

I hit a cryptic failure when testing a recent version of perf:

  # perf report
  write failure on standard output: Bad file descriptor

The issue is in commit b68e2f91 (perf symbols: Introduce symsrc structure). symsrc__destroy() does a close(ss->fd) but ss->fd is only initialised in the symbol-elf.c case and not for symbol-minimal.c.

Quoted 6 lines

The issue has been around for a while however most people will build with libelf which wont use the symbol-minimal.c code.

This was fixed recently, yeah, should go to stable as well:

commit 779e24e2c777bffa9a6e3d5e821859e67008c98b

Author: Adrian Hunter <[email protected]>
Date:   Wed Dec 4 16:23:01 2013 +0200

perf symbols: Fix random fd closing with no libelf

Quoted 14 lines

---

tools/perf/util/symbol-minimal.c +1 -0
index 2d2dd05..3528204 100644
@@ -254,6 +254,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso __maybe_unused,
 		goto out_close;
 
 	ss->type = type;
+	ss->fd = fd;
 
 	return 0;
 out_close: