Skip to contentSkip to conversation

Kesytone II USB host and PHY drivers

PATCH Superseded WingMan Kwok 2 participants 4 messages Dec 12, 2013

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover Kesytone II USB host and PHY drivers

Resending the series with suggested minor updates from v3 [1].

Series adds USB host support for Keystone SOCs. Keystone SOCs uses dwc3 hardware IP implementation. On Keystone II platforms, we use no-op phy driver.

Patchset are tested on Keystone II EVM with USB2.0 and USB3.0 flash drives along with dts changes.

Cc Felipe Balbi <[email protected]>
Cc Santosh Shilimkar <[email protected]>

WingMan Kwok (2):
usb: dwc3: Add Keystone specific glue layer
usb: phy: Add keystone usb phy driver

 drivers/usb/dwc3/Kconfig         |    7 ++
 drivers/usb/dwc3/Makefile        |    1 +
 drivers/usb/dwc3/dwc3-keystone.c |  201 ++++++++++++++++++++++++++++++++++++++
 drivers/usb/phy/Kconfig          |    9 ++
 drivers/usb/phy/Makefile         |    1 +
 drivers/usb/phy/phy-keystone.c   |  142 +++++++++++++++++++++++++++
 6 files changed, 361 insertions(+)
 create mode 100644 drivers/usb/dwc3/dwc3-keystone.c
 create mode 100644 drivers/usb/phy/phy-keystone.c

[1] http://www.spinics.net/lists/linux-usb/msg99178.html

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v4 1/2 usb: dwc3: Add Keystone specific glue layer

Add Keystone platform specific glue layer to support USB3 Host mode.

Cc Santosh Shilimkar <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/dwc3/Kconfig         |    7 ++
 drivers/usb/dwc3/Makefile        |    1 +
 drivers/usb/dwc3/dwc3-keystone.c |  201 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 209 insertions(+)
 create mode 100644 drivers/usb/dwc3/dwc3-keystone.c
drivers/usb/dwc3/Kconfig +7 -0
index 70fc430..e2c730f 100644
@@ -70,6 +70,13 @@ config USB_DWC3_PCI
 	  One such PCIe-based platform is Synopsys' PCIe HAPS model of
 	  this IP.
 
+config USB_DWC3_KEYSTONE
+	tristate "Texas Instruments Keystone2 Platforms"
+	default USB_DWC3
+	help
+	  Support of USB2/3 functionality in TI Keystone2 platforms.
+	  Say 'Y' or 'M' here if you have one such device
+
 comment "Debugging features"
 
 config USB_DWC3_DEBUG
drivers/usb/dwc3/Makefile +1 -0
index dd17601..10ac3e7 100644
@@ -32,3 +32,4 @@ endif
 obj-$(CONFIG_USB_DWC3_OMAP)		+= dwc3-omap.o
 obj-$(CONFIG_USB_DWC3_EXYNOS)		+= dwc3-exynos.o
 obj-$(CONFIG_USB_DWC3_PCI)		+= dwc3-pci.o
+obj-$(CONFIG_USB_DWC3_KEYSTONE)		+= dwc3-keystone.o
drivers/usb/dwc3/dwc3-keystone.c new file +201 -0

201 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v4 1/2 usb: dwc3: Add Keystone specific glue layer

Hi,

drivers/usb/dwc3/dwc3-keystone.c line 174

Quoted 6 lines · WingMan Kwok
drivers/usb/dwc3/dwc3-keystone.c new file +6 -0
+static int kdwc3_remove(struct platform_device *pdev)
+{
+	struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
+
+	kdwc3_disable_irqs(kdwc);
+	clk_disable_unprepare(kdwc->clk);

isn't this same clock feeding dwc3 core ?

drivers/usb/dwc3/dwc3-keystone.c line 175

Quoted 1 line
drivers/usb/dwc3/dwc3-keystone.c new file +1 -0
+	device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);

if it is, you should disable the clock only *after* removing the core, provided core will access registers during remove.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/3302c8f3/attachment.sig>
#3 lore raw

PATCH v4 2/2 usb: phy: Add keystone usb phy driver

In reply to WingMan Kwok

Add Keystone platform USB PHY driver support. Current main purpose of this driver is to enable the PHY reference clock gate on the Keystone SoC. Otherwise it is a nop PHY.

Cc Santosh Shilimkar <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/phy/Kconfig        |    9 +++
 drivers/usb/phy/Makefile       |    1 +
 drivers/usb/phy/phy-keystone.c |  142 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 152 insertions(+)
 create mode 100644 drivers/usb/phy/phy-keystone.c
drivers/usb/phy/Kconfig +9 -0
index 08e2f39..3f2e829 100644
@@ -40,6 +40,15 @@ config ISP1301_OMAP
 	  This driver can also be built as a module.  If so, the module
 	  will be called isp1301_omap.
 
+config KEYSTONE_USB_PHY
+	tristate "Keystone USB PHY Driver"
+	depends on ARCH_KEYSTONE
+	select NOP_USB_XCEIV
+	help
+	  Enable this to support Keystone USB phy. This driver provides
+	  interface to interact with USB 2.0 and USB 3.0 PHY that is part
+	  of the Keystone SOC.
+
 config MV_U3D_PHY
 	bool "Marvell USB 3.0 PHY controller Driver"
 	depends on CPU_MMP3
drivers/usb/phy/Makefile +1 -0
index 022c1da..311b47b 100644
@@ -30,3 +30,4 @@ obj-$(CONFIG_USB_RCAR_PHY)		+= phy-rcar-usb.o
 obj-$(CONFIG_USB_RCAR_GEN2_PHY)		+= phy-rcar-gen2-usb.o
 obj-$(CONFIG_USB_ULPI)			+= phy-ulpi.o
 obj-$(CONFIG_USB_ULPI_VIEWPORT)		+= phy-ulpi-viewport.o
+obj-$(CONFIG_KEYSTONE_USB_PHY)		+= phy-keystone.o
drivers/usb/phy/phy-keystone.c new file +142 -0

142 lines not on this page · raw message

Signature · 1 line
1.7.9.5