Skip to contentSkip to conversation

HID: hid-multitouch: add support for SiS panel in LG 23ET83V

PATCH In review Emanuel Krenz 3 participants 5 messages Dec 12, 2013 – Dec 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: hid-multitouch: add support for SiS panel in LG 23ET83V

3.12.5-stable patch

--------------------
From: Emanuel Krenz <[email protected]>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

---

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't yet included in the hid-multitouch driver (support for SiS panels were just added a few days ago). So I wrote following patch to include the ID number 1030 and patched the latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for me now. This is my first submitted patch by now, hope it's okay.

---
 drivers/hid/hid-core.c          |    1 +
 drivers/hid/hid-ids.h           |    1 +
 drivers/hid/hid-multitouch.c    |    3 +++
 drivers/hid/usbhid/hid-quirks.c |    1 +
 4 files changed, 6 insertions(+)
drivers/hid/hid-core.c +1 -0
@@ -1823,6 +1823,7 @@ static const struct hid_device_id hid_ha
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE, USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_BUZZ_CONTROLLER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_WIRELESS_BUZZ_CONTROLLER) },
drivers/hid/hid-ids.h +1 -0
@@ -755,6 +755,7 @@
 #define USB_VENDOR_ID_SIS2_TOUCH	0x0457
 #define USB_DEVICE_ID_SIS9200_TOUCH	0x9200
 #define USB_DEVICE_ID_SIS817_TOUCH	0x0817
+#define USB_DEVICE_ID_SIS1030_TOUCH	0x1030
 
 #define USB_VENDOR_ID_SKYCABLE			0x1223
 #define	USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER	0x3F07
drivers/hid/hid-multitouch.c +3 -0
@@ -1306,6 +1306,9 @@ static const struct hid_device_id mt_dev
 	{ .driver_data = MT_CLS_DEFAULT,
 		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
 		USB_DEVICE_ID_SIS817_TOUCH) },
+	{ .driver_data = MT_CLS_DEFAULT,
+		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
+		USB_DEVICE_ID_SIS1030_TOUCH) },
 
 	/* Stantum panels */
 	{ .driver_data = MT_CLS_CONFIDENCE,
drivers/hid/usbhid/hid-quirks.c +1 -0
@@ -86,6 +86,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, HID_QUIRK_NOGET },
#1 lore raw
Quoted 11 lines · Emanuel Krenz

3.12.5-stable patch

--------------------
From: Emanuel Krenz <[email protected]>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

I signed off on this? What is the git commit id of the patch in Linus's tree?

confused,

greg k-h

#2 lore raw
Quoted 7 lines · Greg KH
Quoted 7 lines

3.12.5-stable patch

--------------------
From: Emanuel Krenz <[email protected]>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

Quoted 7 lines
Quoted 4 lines

I signed off on this? What is the git commit id of the patch in Linus's tree?

I haven't either, and I don't think I have ever seen this patch (it's definitely neither in Linus' nor my tree).

Emanuel, what is going on here, please? Is it that you authored this patch yourself, and would like to have it included in Linus' tree (only then it can go to -stable)?

If so, please remove all Signoffs of people who haven't provided it to you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell you who are proper recepients of this patch).

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#3 lore raw

Am 13.12.2013 10:39, schrieb Jiri Kosina:

Quoted 22 lines · Greg KH
Quoted 6 lines
Quoted 6 lines

3.12.5-stable patch

--------------------
From: Emanuel Krenz <[email protected]>

Quoted 8 lines
Quoted 6 lines

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

I signed off on this? What is the git commit id of the patch in Linus's tree?

I haven't either, and I don't think I have ever seen this patch (it's definitely neither in Linus' nor my tree).

Emanuel, what is going on here, please? Is it that you authored this patch yourself, and would like to have it included in Linus' tree (only then it can go to -stable)?

Quoted 6 lines

If so, please remove all Signoffs of people who haven't provided it to you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell you who are proper recepients of this patch).

Thanks,

Hello,
I'm sorry, guys. I thought I have to add those "Signed-off-by" lines to mention, where I got the ideas for this patch from. It was actually this patch: https://lkml.org/lkml/2013/12/2/647
That was obviously a mistake, please forgive me.
As I mentioned, this was my first submitted patch, I was just so excited that I might help developing.

Thank you, Jiri, for telling me, to remove this "Signed-off-by" lines and resubmit the patch after using get_maintainer.pl. Now I actually got your name as the maintainer of HID CORE LAYER. So i'll send it to you again without those lines, i hope it's correct now.

Thanks, guys, for all your work and help!

#4 lore raw
Quoted 8 lines · Emanuel Krenz
Quoted 8 lines

Emanuel, what is going on here, please? Is it that you authored this patch yourself, and would like to have it included in Linus' tree (only then it can go to -stable)?

If so, please remove all Signoffs of people who haven't provided it to you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell you who are proper recepients of this patch).

Quoted 5 lines
Quoted 2 lines

Thanks,

Hello,
I'm sorry, guys. I thought I have to add those "Signed-off-by" lines to mention, where I got the ideas for this patch from.

For real meaning of Signed-off-by:, please refer to Documentation/SubmittingPatches, section 12.

Quoted 9 lines

It was actually this patch: https://lkml.org/lkml/2013/12/2/647 That was obviously a mistake, please forgive me. As I mentioned, this was my first submitted patch, I was just so excited that I might help developing.

Thank you, Jiri, for telling me, to remove this "Signed-off-by" lines and resubmit the patch after using get_maintainer.pl.
Now I actually got your name as the maintainer of HID CORE LAYER. So i'll send it to you again without those lines, i hope it's correct now.

Yup, that is the proper process.

Thanks for submitting the patch, I'll respond to that separately.

Signature · 2 lines
Jiri Kosina
SUSE Labs