Skip to contentSkip to conversation

serial/serial_arc - add driver for ARC UART

PATCH In review Alexey Brodkin 2 participants 7 messages Dec 13, 2013 – Feb 7, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial/serial_arc - add driver for ARC UART

Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x

Cc Mischa Jonker <[email protected]>
Cc Francois Bedard <[email protected]>
Cc Tom Rini <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Stefano Babic <[email protected]>
---
 drivers/serial/Makefile     |   1 +
 drivers/serial/serial.c     |   2 +
 drivers/serial/serial_arc.c | 105 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 108 insertions(+)
 create mode 100644 drivers/serial/serial_arc.c
drivers/serial/Makefile +1 -0
index 6b4cade..5eb4601 100644
@@ -34,6 +34,7 @@ obj-$(CONFIG_ZYNQ_SERIAL) += serial_zynq.o
 obj-$(CONFIG_BFIN_SERIAL) += serial_bfin.o
 obj-$(CONFIG_FSL_LPUART) += serial_lpuart.o
 obj-$(CONFIG_MXS_AUART) += mxs_auart.o
+obj-$(CONFIG_ARC_SERIAL) += serial_arc.o
 
 ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_USB_TTY) += usbtty.o
drivers/serial/serial.c +2 -0
index df2b84a..05cb369 100644
@@ -160,6 +160,7 @@ serial_initfunc(sa1100_serial_initialize);
 serial_initfunc(sh_serial_initialize);
 serial_initfunc(arm_dcc_initialize);
 serial_initfunc(mxs_auart_initialize);
+serial_initfunc(arc_serial_initialize);
 
 /**
  * serial_register() - Register serial driver with serial driver core
@@ -253,6 +254,7 @@ void serial_initialize(void)
 	sh_serial_initialize();
 	arm_dcc_initialize();
 	mxs_auart_initialize();
+	arc_serial_initialize();
 
 	serial_assign(default_serial_console()->name);
 }
drivers/serial/serial_arc.c new file +105 -0

105 lines not on this page · raw message

Signature · 1 line
1.8.4.2
#1 lore raw

PATCH 1/1 serial/serial_arc - add driver for ARC UART

Quoted 10 lines · Alexey Brodkin

Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x

Cc Mischa Jonker <[email protected]>
Cc Francois Bedard <[email protected]>
Cc Tom Rini <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Stefano Babic <[email protected]>

Looks fine, please list this as a pre-requisite patch when posting the rest of the board, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131213/d60a2a94/attachment.pgp>
#2 lore raw

PATCH 1/1 serial/serial_arc - add driver for ARC UART

Quoted 3 lines · Tom Rini

Looks fine, please list this as a pre-requisite patch when posting the rest of the board, thanks!

Hi Tom,

is my understanding correct that this patch will be accepted as it is but later when I do submission of corresponding board I just need to indicate that this driver is a pre-requisite (so commiter makes sure this patch is already applied)?

-Alexey

#3 lore raw

PATCH 1/1 serial/serial_arc - add driver for ARC UART

Quoted 6 lines · Alexey Brodkin
Quoted 3 lines · Tom Rini

Looks fine, please list this as a pre-requisite patch when posting the rest of the board, thanks!

Quoted 6 lines

Hi Tom,

is my understanding correct that this patch will be accepted as it is but later when I do submission of corresponding board I just need to indicate that this driver is a pre-requisite (so commiter makes sure this patch is already applied)?

Yes.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131213/457607d8/attachment.pgp>
#4 lore raw
In reply to Alexey Brodkin
Quoted 4 lines · Alexey Brodkin

Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140207/00c6fc24/attachment.pgp>
#5 lore raw

Hello Tom,

Quoted 9 lines · Tom Rini
Quoted 4 lines · Alexey Brodkin

Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x

Applied to u-boot/master, thanks!

Are you sure this patch was applied?
I don't see it in master tree -
http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/serial;h=48a1ed6ee43b81f0392a25b94c54c03fe1e12137;hb=HEAD

And as a result you seeing a build error trying to build "arcangel4" board.

Could you please double-check?

-Alexey

#6 lore raw
Quoted 13 lines · Alexey Brodkin

Hello Tom,

Quoted 9 lines · Tom Rini
Quoted 4 lines · Alexey Brodkin

Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x

Applied to u-boot/master, thanks!

Quoted 8 lines

Are you sure this patch was applied?
I don't see it in master tree -
http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/serial;h=48a1ed6ee43b81f0392a25b94c54c03fe1e12137;hb=HEAD

And as a result you seeing a build error trying to build "arcangel4" board.

Could you please double-check?

Whoops, you're right, this got lost in the shuffle by accident, really applied now.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140207/03944921/attachment.pgp>