Skip to contentSkip to conversation

drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c

PATCH Superseded Rashika Kheria 3 participants 3 messages Dec 14, 2013 Hyper-V/Azure core and drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c

This patch marks the function hv_synic_free_cpu() as static in hv.c because it is not used outside this file.

Thus, it also eliminates the following warning in hv.c:
drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’ [-Wmissing-prototypes]

---
 drivers/hv/hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv.c +1 -1
index f0c5e07..bcb4950 100644
@@ -301,7 +301,7 @@ err:
 	return -ENOMEM;
 }
 
-void hv_synic_free_cpu(int cpu)
+static void hv_synic_free_cpu(int cpu)
 {
 	kfree(hv_context.event_dpc[cpu]);
 	if (hv_context.synic_event_page[cpu])
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rashika Kheria

This patch marks the function hv_synic_free_cpu() as static in hv.c because it is not used outside this file.

Thus, it also eliminates the following warning in hv.c:
drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/hv/hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv.c +1 -1
index f0c5e07..bcb4950 100644
@@ -301,7 +301,7 @@ err:
 	return -ENOMEM;
 }
 
-void hv_synic_free_cpu(int cpu)
+static void hv_synic_free_cpu(int cpu)
 {
 	kfree(hv_context.event_dpc[cpu]);
 	if (hv_context.synic_event_page[cpu])
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 15 lines

-----Original Message-----
From: Josh Triplett [mailto:[email protected]]
Sent: Saturday, December 14, 2013 12:57 PM
To: Rashika Kheria
Cc: [email protected]; KY Srinivasan; Haiyang Zhang; [email protected]
Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c

Quoted 3 lines · Rashika Kheria

This patch marks the function hv_synic_free_cpu() as static in hv.c because it is not used outside this file.

Quoted 7 lines
Quoted 2 lines

Thus, it also eliminates the following warning in hv.c:
drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’

[-Wmissing-prototypes]

Quoted 2 lines

Thank you.

Quoted 12 lines
Quoted 12 lines
 drivers/hv/hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv.c +0 -0
index f0c5e07..bcb4950 100644
@@ -301,7 +301,7 @@ err:
 	return -ENOMEM;
 }
 
Quoted 8 lines
Quoted 8 lines
drivers/hv/hv.c +1 -2
-void hv_synic_free_cpu(int cpu)
+static void hv_synic_free_cpu(int cpu)
 {
 	kfree(hv_context.event_dpc[cpu]);
 	if (hv_context.synic_event_page[cpu])
--

1.7.9.5

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�