Skip to contentSkip to conversation

drivers: input: Include appropriate header file in cyttsp_i2c_common.c

PATCH Applied Rashika Kheria 3 participants 3 messages Dec 14, 2013 – Dec 15, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: input: Include appropriate header file in cyttsp_i2c_common.c

This patch includes appropriate header file cyttsp4_core.h in touchscreen/cyttsp_i2c_common.c because functions cyttsp_i2c_read_block_data() and cyttsp_i2c_write_block_data() have their prototype declaration in cyttsp4_core.h.

Thus, it also eliminates the following warning in cyttsp_i2c_common.c:
drivers/input/touchscreen/cyttsp_i2c_common.c:34:5: warning: no previous prototype for ‘cyttsp_i2c_read_block_data’ [-Wmissing-prototypes] drivers/input/touchscreen/cyttsp_i2c_common.c:64:5: warning: no previous prototype for ‘cyttsp_i2c_write_block_data’ [-Wmissing-prototypes]

---
 drivers/input/touchscreen/cyttsp_i2c_common.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/input/touchscreen/cyttsp_i2c_common.c +2 -0
index 1d7b6f1..ccefa56 100644
@@ -31,6 +31,8 @@
 #include <linux/module.h>
 #include <linux/types.h>
 
+#include "cyttsp4_core.h"
+
 int cyttsp_i2c_read_block_data(struct device *dev, u8 *xfer_buf,
 				      u16 addr, u8 length, void *values)
 {
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Rashika Kheria

This patch includes appropriate header file cyttsp4_core.h in touchscreen/cyttsp_i2c_common.c because functions cyttsp_i2c_read_block_data() and cyttsp_i2c_write_block_data() have their prototype declaration in cyttsp4_core.h.

Thus, it also eliminates the following warning in cyttsp_i2c_common.c:
drivers/input/touchscreen/cyttsp_i2c_common.c:34:5: warning: no previous prototype for ‘cyttsp_i2c_read_block_data’ [-Wmissing-prototypes] drivers/input/touchscreen/cyttsp_i2c_common.c:64:5: warning: no previous prototype for ‘cyttsp_i2c_write_block_data’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/input/touchscreen/cyttsp_i2c_common.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/input/touchscreen/cyttsp_i2c_common.c +2 -0
index 1d7b6f1..ccefa56 100644
@@ -31,6 +31,8 @@
 #include <linux/module.h>
 #include <linux/types.h>
 
+#include "cyttsp4_core.h"
+
 int cyttsp_i2c_read_block_data(struct device *dev, u8 *xfer_buf,
 				      u16 addr, u8 length, void *values)
 {
Signature · 1 line
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer Applied
#2 lore raw
Quoted 6 lines · Josh Triplett
Quoted 5 lines · Rashika Kheria

This patch includes appropriate header file cyttsp4_core.h in touchscreen/cyttsp_i2c_common.c because functions cyttsp_i2c_read_block_data() and cyttsp_i2c_write_block_data() have their prototype declaration in cyttsp4_core.h.

Quoted 8 lines
Quoted 6 lines

Thus, it also eliminates the following warning in cyttsp_i2c_common.c:
drivers/input/touchscreen/cyttsp_i2c_common.c:34:5: warning: no previous prototype for ‘cyttsp_i2c_read_block_data’ [-Wmissing-prototypes] drivers/input/touchscreen/cyttsp_i2c_common.c:64:5: warning: no previous prototype for ‘cyttsp_i2c_write_block_data’ [-Wmissing-prototypes]

Applied, thank you.

Quoted 20 lines
Quoted 20 lines
 drivers/input/touchscreen/cyttsp_i2c_common.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/input/touchscreen/cyttsp_i2c_common.c +2 -0
index 1d7b6f1..ccefa56 100644
@@ -31,6 +31,8 @@
 #include <linux/module.h>
 #include <linux/types.h>
 
+#include "cyttsp4_core.h"
+
 int cyttsp_i2c_read_block_data(struct device *dev, u8 *xfer_buf,
 				      u16 addr, u8 length, void *values)
 {
Signature · 1 line
1.7.9.5
Signature · 5 lines
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html