migrate_disable pushd down in spin_trylock

PATCH In review Nicholas Mc Guire 2 participants 3 messages Nov 30, 2013 – Dec 15, 2013

lore

Share & tools

lore

Nicholas Mc Guire

author

2013-11-30 03:06 UTC #0 lore raw

PATCH 1/4 migrate_disable pushd down in spin_trylock

Quoted 1 line

From 7b60d163555d701b88f463d12ba62c6ceb61fb66 Mon Sep 17 00:00:00 2001

From: Nicholas Mc Guire <[email protected]>
Date: Fri, 29 Nov 2013 00:21:59 -0500
Subject: [PATCH 4/4] migrate_disable pushd down in rt_write_trylock_irqsave

Signed-off-by Nicholas Mc Guire <[email protected]>

---
 kernel/rt.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

kernel/rt.c +2 -3

index 75372f0..ce44afc 100644
@@ -196,10 +196,9 @@ int __lockfunc rt_write_trylock_irqsave(rwlock_t *rwlock, unsigned long *flags)
 	int ret;
 
 	*flags = 0;
-	migrate_disable();
 	ret = rt_write_trylock(rwlock);
-	if (!ret)
-		migrate_enable();
+	if (ret)
+		migrate_disable();
 	return ret;
 }
 EXPORT_SYMBOL(rt_write_trylock_irqsave);

Signature · 1 line

1.7.2.5

Sebastian Andrzej Siewior

2013-12-15 14:29 UTC #1 lore raw

Review int __lockfunc rt_write_trylock_irqsave(rwlock_t *rwlock, unsigned long *flags)

Quoted 7 lines · * Nicholas Mc Guire | 2013-11-30 04:06:28 [+0100]:

Quoted 1 line
From 7b60d163555d701b88f463d12ba62c6ceb61fb66 Mon Sep 17 00:00:00 2001
From: Nicholas Mc Guire <[email protected]>
Date: Fri, 29 Nov 2013 00:21:59 -0500
Subject: [PATCH 4/4] migrate_disable pushd down in rt_write_trylock_irqsave
+++ b/kernel/rt.c
(quoted diff) +0 -0
@@ -196,10 +196,9 @@ int __lockfunc rt_write_trylock_irqsave(rwlock_t *rwlock, unsigned long *flags)

It looks like you loaded the wrong file here. Email's subject line does not match patch's and it seems be to be really the same one as in 4/4.

Sebastian

Nicholas Mc Guire

author

2013-12-15 14:34 UTC #2 lore raw

Quoted 7 lines · Sebastian Andrzej Siewior

Quoted 5 lines · * Nicholas Mc Guire | 2013-11-30 04:06:28 [+0100]:
Quoted 1 line
From 7b60d163555d701b88f463d12ba62c6ceb61fb66 Mon Sep 17 00:00:00 2001
From: Nicholas Mc Guire <[email protected]>
Date: Fri, 29 Nov 2013 00:21:59 -0500
Subject: [PATCH 4/4] migrate_disable pushd down in rt_write_trylock_irqsave

Quoted 6 lines

Review int __lockfunc rt_write_trylock_irqsave(rwlock_t *rwlock, unsigned long *flags)
Quoted 2 lines
+++ b/kernel/rt.c
(quoted diff) +0 -0
@@ -196,10 +196,9 @@ int __lockfunc rt_write_trylock_irqsave(rwlock_t *rwlock, unsigned long *flags)
It looks like you loaded the wrong file here. Email's subject line does not match patch's and it seems be to be really the same one as in 4/4.

sorry for the screwup - will see where the right file is hiding...

thx!
hofrat