ARM: bcm2835: fix mailbox timeout
Subsystems (3)
PATCH 1/1 ARM: bcm2835: fix mailbox timeout
My original intention was to have a 100ms timeout. However, the timer operations used return values in ms not us, so we ended up with a 100s timeout instead. Fixing this exposes that some operations need longer to operate than 100ms, so bump the timeout up to a whole second.
---
Albert, I believe this implies that my "ARM: rpi_b: power on SDHCI and USB HW modules" can be applied now.
arch/arm/cpu/arm1176/bcm2835/mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/arm1176/bcm2835/mbox.c +1 -1
@@ -8,7 +8,7 @@#include <asm/io.h> #include <asm/arch/mbox.h> -#define TIMEOUT (100 * 1000)/* 100mS in uS */ +#define TIMEOUT 1000/* ms */ int bcm2835_mbox_call_raw (u32 chan,u32 send,u32 *recv) {
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: bcm2835: fix mailbox timeout
Quoted 7 lines · Stephen Warren
My original intention was to have a 100ms timeout. However, the timer operations used return values in ms not us, so we ended up with a 100s timeout instead. Fixing this exposes that some operations need longer to operate than 100ms, so bump the timeout up to a whole second.
Reported-by Andre Heider <[email protected]>Signed-off-by Stephen Warren <[email protected]>
Btw, the "get timing" mbox call I mentioned the other day is not what I thought it is. I tried it and it doesn't describe how long the "power on" call would take. I get "1" for every device except UART, for which 40000 was returned iirc.
Thanks,
Andre