Skip to contentSkip to conversation

oprofile: fix install for avr32

PATCH New spdawson at gmail.com 2 participants 3 messages Dec 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oprofile: fix install for avr32

From: Simon Dawson <[email protected]>

There is no perf_events support in the kernel for avr32. The oprofile package makefile hard codes the list of binaries to install. Unfortunately, this hard-coded list contains pe_profiling/operf, which is only built when perf_events support is available.

Fixes autobuild failures such as the following.

http://autobuild.buildroot.net/results/492/492659bc252395a62e62e6005ed0e86e582dcada/

---
 package/oprofile/oprofile.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/oprofile/oprofile.mk +8 -1
index 186e30c..ee94d19 100644
@@ -16,7 +16,14 @@ OPROFILE_CONF_OPT = \
 OPROFILE_AUTORECONF = YES
 OPROFILE_BINARIES = utils/ophelp pp/opannotate pp/oparchive pp/opgprof
 OPROFILE_BINARIES += pp/opreport opjitconv/opjitconv daemon/oprofiled
-OPROFILE_BINARIES += utils/op-check-perfevents pe_profiling/operf libabi/opimport
+OPROFILE_BINARIES += utils/op-check-perfevents libabi/opimport
+
+# No perf_events support in kernel for avr32
+ifneq ($(BR2_avr32),y)
+OPROFILE_BINARIES += pe_profiling/operf
+endif
+
+OPROFILE_MAKE = $(MAKE1)
 
 ifeq ($(BR2_i386),y)
 OPROFILE_ARCH = i386
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 oprofile: fix install for avr32

Hi Simon,

Quoted 23 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

There is no perf_events support in the kernel for avr32. The oprofile package makefile hard codes the list of binaries to install. Unfortunately, this hard-coded list contains pe_profiling/operf, which is only built when perf_events support is available.

Fixes autobuild failures such as the following.

http://autobuild.buildroot.net/results/492/492659bc252395a62e62e6005ed0e86e582dcada/

---
 package/oprofile/oprofile.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/oprofile/oprofile.mk +0 -0
index 186e30c..ee94d19 100644
@@ -16,7 +16,14 @@ OPROFILE_CONF_OPT = \
 OPROFILE_AUTORECONF = YES
 OPROFILE_BINARIES = utils/ophelp pp/opannotate pp/oparchive pp/opgprof

package/oprofile/oprofile.mk OPROFILE_CONF_OPT = \ · line 26

Quoted 10 lines
package/oprofile/oprofile.mk +8 -1
 OPROFILE_BINARIES += pp/opreport opjitconv/opjitconv daemon/oprofiled
-OPROFILE_BINARIES += utils/op-check-perfevents pe_profiling/operf libabi/opimport
+OPROFILE_BINARIES += utils/op-check-perfevents libabi/opimport
+
+# No perf_events support in kernel for avr32
+ifneq ($(BR2_avr32),y)
+OPROFILE_BINARIES += pe_profiling/operf
+endif
+
+OPROFILE_MAKE = $(MAKE1)

Is this change intended? Have you encountered problems with parallel build?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 oprofile: fix install for avr32

Hi Baruch,

Quoted 3 lines · Baruch Siach
Quoted 1 line

+OPROFILE_MAKE = $(MAKE1)

Is this change intended? Have you encountered problems with parallel build?

Oops. No, this was not intended; thanks for spotting it.

Will fix and resubmit.

Simon.