mfd: (max8997) Handle the potential error for mfd_add_devices
PATCH 1/1 mfd: (max8997) Handle the potential error for mfd_add_devices
--- drivers/mfd/max8997.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mfd/max8997.c +5 -5
@@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,pm_runtime_set_active (max8997->dev);max8997_irq_init (max8997); - -mfd_add_devices (max8997->dev,-1 , max8997_devs, + ret =mfd_add_devices (max8997->dev,-1 , max8997_devs,ARRAY_SIZE (max8997_devs),NULL ,0 ,NULL ); +if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }/* * TODO: enable others (flash, muic, rtc, battery, ...) and * check the return value */ -if (ret <0 ) - goto err_mfd; -/* MAX8997 has a power button input. */ device_init_wakeup (max8997->dev, pdata->wakeup);
Signature · 1 line
1.8.5.1
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like git log --oneline -- <subsystem>. And duplicate the format.
Commit message?
Quoted 12 lines
Signed-off-by Laszlo Papp <[email protected]>--- drivers/mfd/max8997.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/mfd/max8997.c +0
-0@@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,pm_runtime_set_active (max8997->dev);
drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 236
Quoted 10 lines
drivers/mfd/max8997.c +5
-2max8997_irq_init (max8997); - -mfd_add_devices (max8997->dev,-1 , max8997_devs, + ret =mfd_add_devices (max8997->dev,-1 , max8997_devs,ARRAY_SIZE (max8997_devs),NULL ,0 ,NULL ); +if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }
Have you tested this patch on h/w? Did you even compile it?
Quoted 11 lines
drivers/mfd/max8997.c +0
-3/* * TODO: enable others (flash, muic, rtc, battery, ...) and * check the return value */ -if (ret <0 ) - goto err_mfd; -/* MAX8997 has a power button input. */ device_init_wakeup (max8997->dev, pdata->wakeup);
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
I think you commented on the wrong patch. There has been a newer submitted.
Quoted 48 lines · Lee Jones
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
Quoted 12 lines
Signed-off-by Laszlo Papp <[email protected]>--- drivers/mfd/max8997.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/mfd/max8997.c +0
-0@@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,pm_runtime_set_active (max8997->dev);drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 236
Quoted 10 lines
drivers/mfd/max8997.c +5
-2max8997_irq_init (max8997); - -mfd_add_devices (max8997->dev,-1 , max8997_devs, + ret =mfd_add_devices (max8997->dev,-1 , max8997_devs,ARRAY_SIZE (max8997_devs),NULL ,0 ,NULL ); +if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }Have you tested this patch on h/w? Did you even compile it?
drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 245
Quoted 11 lines
drivers/mfd/max8997.c +0
-3/* * TODO: enable others (flash, muic, rtc, battery, ...) and * check the return value */ -if (ret <0 ) - goto err_mfd; -/* MAX8997 has a power button input. */ device_init_wakeup (max8997->dev, pdata->wakeup);--
Lee Jones
Linaro STMicroelectronics Landing Team LeadLinaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 1 line
I think you commented on the wrong patch. There has been a newer submitted.
No top posting please.
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Signed-off-by Laszlo Papp <[email protected]>--- drivers/mfd/max8997.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/mfd/max8997.c +0
-0@@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,pm_runtime_set_active (max8997->dev);
Quoted 12 lines
Quoted 11 lines
drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 236
Quoted 10 lines
drivers/mfd/max8997.c +5
-2max8997_irq_init (max8997); - -mfd_add_devices (max8997->dev,-1 , max8997_devs, + ret =mfd_add_devices (max8997->dev,-1 , max8997_devs,ARRAY_SIZE (max8997_devs),NULL ,0 ,NULL ); +if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }Quoted 1 line
Have you tested this patch on h/w? Did you even compile it?
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
drivers/mfd/max8997.c +0
-3/* * TODO: enable others (flash, muic, rtc, battery, ...) and * check the return value */ -if (ret <0 ) - goto err_mfd; -/* MAX8997 has a power button input. */ device_init_wakeup (max8997->dev, pdata->wakeup);
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 3 lines · Lee Jones
Quoted 1 line
I think you commented on the wrong patch. There has been a newer submitted.
No top posting please.
Tell that to the client I need to use. IMO, making these inline posts mandatorily when the reply is a single line makes not much sense. Anyway, I will follow the inconvenient way.
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it? It has a pretty clear commit message. Are you now just picking nits about "foo:" vs "(foo)" in the short line?
Quoted 25 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Signed-off-by Laszlo Papp <[email protected]>--- drivers/mfd/max8997.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/mfd/max8997.c +0
-0@@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,pm_runtime_set_active (max8997->dev);Quoted 12 lines
Quoted 11 lines
drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 236
Quoted 10 lines
drivers/mfd/max8997.c +5
-2max8997_irq_init (max8997); - -mfd_add_devices (max8997->dev,-1 , max8997_devs, + ret =mfd_add_devices (max8997->dev,-1 , max8997_devs,ARRAY_SIZE (max8997_devs),NULL ,0 ,NULL ); +if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }Quoted 1 line
Have you tested this patch on h/w? Did you even compile it?
Quoted 2 lines
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
I am not sure what point you are trying to make. Feel free to reject the patch for this error handling. Clearly, the patch has been updated due to a previous mistake. I would not make a fuss about an issue which had been fixed before getting any comment.
Quoted 4 lines · Laszlo Papp
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it? It has a pretty clear commit message. Are you now just picking nits about "foo:" vs "(foo)" in the short line?
The commit message needs to have subject and a body.
A good message body explains what the current situation is, why it is broken/has problems
and how this patch fixes that.
Signature · 2 lines
Thanks, //richard
Quoted 7 lines · Richard Weinberger
Quoted 6 lines · Laszlo Papp
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it? It has a pretty clear commit message. Are you now just picking nits about "foo:" vs "(foo)" in the short line?
The commit message needs to have subject and a body.
Why? What advantage does that have in very simple cases like this?
Quoted 3 lines
A good message body explains what the current situation is, why it is broken/has problems
and how this patch fixes that.
The current commit message explains that in my opinion. Please bring up real issues with it.
Quoted 18 lines · Laszlo Papp
Quoted 7 lines · Richard Weinberger
Quoted 6 lines · Laszlo Papp
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it? It has a pretty clear commit message. Are you now just picking nits about "foo:" vs "(foo)" in the short line?
The commit message needs to have subject and a body.
Quoted 8 lines
Why? What advantage does that have in very simple cases like this?
Quoted 3 lines
A good message body explains what the current situation is, why it is broken/has problems
and how this patch fixes that.The current commit message explains that in my opinion. Please bring up real issues with it.
Now as I read your arguments I remember your name from IRC. Time to stop the discussion.
Signature · 2 lines
Thanks, //richard
This is not a good introduction to the Kernel Community.
Please adapt your attitude or people will stop helping you.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
I think you commented on the wrong patch. There has been a newer submitted.
No top posting please.
Tell that to the client I need to use. IMO, making these inline posts mandatorily when the reply is a single line makes not much sense. Anyway, I will follow the inconvenient way.
If you are not replying to a particular comment, then there is no need to quote it.
Please read and inwardly digest:
Documentation/email-clients.txt
Quoted 11 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it?
The issue is that there isn't one.
Quoted 1 line
It has a pretty clear commit message.
If you are referencing my comments about the $SUBJECT line, then I have to disagree with you there. It's actually pretty vague, does not describe either the issue or what steps you've taken to rectify it.
Quoted 2 lines
Are you now just
picking nits about "foo:" vs "(foo)" in the short line?
That is also an issue. Did you issue the command I sent you:
`git log --oneline -- drivers/mfd`
Issue it now and see if _anyone_ has _ever_ used your formatting.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
drivers/mfd/max8997.c +4
-0+if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Have you tested this patch on h/w? Did you even compile it?
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
I am not sure what point you are trying to make. Feel free to reject the patch for this error handling.
I'm not rejecting it because of the error handling, I'm rejecting it because it hasn't been tested and it doesn't even compile.
Quoted 3 lines
Clearly, the patch has been updated
due to a previous mistake. I would not make a fuss about an issue which had been fixed before getting any comment.
How was this 'clear'? Our inboxes are date/time sequential.
This patch was read _before_ the one you posted _subsequently_.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 3 lines · Lee Jones
This is not a good introduction to the Kernel Community.
Please adapt your attitude or people will stop helping you.
(I would personally like to stay civil here...)
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
I think you commented on the wrong patch. There has been a newer submitted.
No top posting please.
Tell that to the client I need to use. IMO, making these inline posts mandatorily when the reply is a single line makes not much sense. Anyway, I will follow the inconvenient way.
If you are not replying to a particular comment, then there is no need to quote it.
I did not actually quote anything above my reply.
Quoted 3 lines
Please read and inwardly digest:
Documentation/email-clients.txt
I have read that, however I still have certain restrictions here which are over the kernel community rules. That should not block a useful contribution in my opinion.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it?
The issue is that there isn't one.
I do not follow. Here is the commit message: "mfd: (max8997) Handle the potential error for mfd_add_devices". What is missing? It now handles an error for adding mfd devices which was not handled before. It mentions for which chip. What more needs to be written? I am currently lost.
Quoted 6 lines
Quoted 1 line
It has a pretty clear commit message.
If you are referencing my comments about the $SUBJECT line, then I have to disagree with you there. It's actually pretty vague, does not describe either the issue or what steps you've taken to rectify it.
Quoted 8 lines
Quoted 2 lines
Are you now just
picking nits about "foo:" vs "(foo)" in the short line?That is also an issue. Did you issue the command I sent you:
`git log --oneline -- drivers/mfd`Issue it now and see if _anyone_ has _ever_ used your formatting.
Right, so nitpicking about a minor nuance over a somewhat important error handling. Is that blocking the error handling change or you can fix that up yourself? I currently do not have time, nor environment for satisfy this request. I can probably do it the upcoming days.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
drivers/mfd/max8997.c static int max8997_i2c_probe(struct i2c_client *i2c, · line 236
Quoted 4 lines
drivers/mfd/max8997.c +4
-0+if (ret <0 ) { +dev_err (dev,"cannot add mfd cells\n" ); + goto err_mfd; + }Have you tested this patch on h/w? Did you even compile it?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
I am not sure what point you are trying to make. Feel free to reject the patch for this error handling.
I'm not rejecting it because of the error handling, I'm rejecting it because it hasn't been tested and it doesn't even compile.
It *has* been tested, and it does compile here. I think you just got stuck with the old patch rather than taking any look at new version. May I ask you to do please so? That has been fixed in the new submission before your email.
Quoted 7 lines
Quoted 3 lines
Clearly, the patch has been updated
due to a previous mistake. I would not make a fuss about an issue which had been fixed before getting any comment.How was this 'clear'? Our inboxes are date/time sequential.
This patch was read _before_ the one you posted _subsequently_.
My personal suggestion is to read the latest as well before replying to a potentially obsolete email.
Quoted 10 lines
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
No top posting please.
Tell that to the client I need to use. IMO, making these inline posts mandatorily when the reply is a single line makes not much sense. Anyway, I will follow the inconvenient way.
If you are not replying to a particular comment, then there is no need to quote it.
I did not actually quote anything above my reply.
No, you quoted the entire message _below_ your reply, which is worse.
Quoted 6 lines
Quoted 2 lines
Please read and inwardly digest:
Documentation/email-clients.txtI have read that, however I still have certain restrictions here which are over the kernel community rules. That should not block a useful contribution in my opinion.
Your email client does not prevent you from replying inline, which you've proven by this email. Please abide by the rules if you're going to contribute.
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it?
Quoted 7 lines
Quoted 1 line
The issue is that there isn't one.
I do not follow. Here is the commit message: "mfd: (max8997) Handle the potential error for
mfd_add_devices". What is missing? It now handles an error for adding mfd devices which was not handled before. It mentions for which chip. What more needs to be written? I am currently lost.
Please read:
Documentation/SubmittingPatches
Specifically No2.
Quoted 11 lines
Quoted 11 lines
Quoted 1 line
It has a pretty clear commit message.
If you are referencing my comments about the $SUBJECT line, then I have to disagree with you there. It's actually pretty vague, does not describe either the issue or what steps you've taken to rectify it.
Quoted 2 lines
Are you now just
picking nits about "foo:" vs "(foo)" in the short line?That is also an issue. Did you issue the command I sent you:
Quoted 8 lines
Quoted 3 lines
`git log --oneline -- drivers/mfd`Issue it now and see if _anyone_ has _ever_ used your formatting.
Right, so nitpicking about a minor nuance over a somewhat important error handling. Is that blocking the error handling change or you can fix that up yourself? I currently do not have time, nor environment for satisfy this request. I can probably do it the upcoming days.
It's not my responsibility to fixup your patches for you. It's your job to ensure they are correct on submission. I am happy to review them for you and provide you with my comments, which I have done.
Either fix them up and re-submit or don't. It's no skin off my nose.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ if (ret < 0) { + dev_err(dev, "cannot add mfd cells\n"); + goto err_mfd; + }Have you tested this patch on h/w? Did you even compile it?
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
I am not sure what point you are trying to make. Feel free to reject the patch for this error handling.
Quoted 7 lines
Quoted 2 lines
I'm not rejecting it because of the error handling, I'm rejecting it because it hasn't been tested and it doesn't even compile.
It *has* been tested, and it does compile here. I think you just got stuck with the old patch rather than taking any look at new version. May I ask you to do please so? That has been fixed in the new submission before your email.
I have seen the new patch where you fixed it. My comments are solely in reference to this patch though. Testing patches _after_ you've sent them to the MLs is not acceptable.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 6 lines · Lee Jones
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
No top posting please.
Tell that to the client I need to use. IMO, making these inline posts mandatorily when the reply is a single line makes not much sense. Anyway, I will follow the inconvenient way.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
If you are not replying to a particular comment, then there is no need to quote it.
I did not actually quote anything above my reply.
No, you quoted the entire message _below_ your reply, which is worse.
Why is that bad? Cannot you just reply to the "top-post" sentence with dropping all the quotes below if that is what you wish?
Quoted 10 lines
Quoted 6 lines
Quoted 2 lines
Please read and inwardly digest:
Documentation/email-clients.txtI have read that, however I still have certain restrictions here which are over the kernel community rules. That should not block a useful contribution in my opinion.
Your email client does not prevent you from replying inline, which you've proven by this email. Please abide by the rules if you're going to contribute.
Yes, I can spend more effort with it inconveniently, but currently I do not see why that is for good. Yes, I will follow, as I already wrote, but I still do not see why that is better for anyone. :)
Quoted 20 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
The $SUBJECT line is wrong. To see how a subsystem usually formats theirs you must do something like
git log --oneline -- <subsystem>. And duplicate the format.Commit message?
These comments are still relevant, please re-post your patch with the points rectified.
I really do not understand how they relevant. "Commit message?" -> What about it?
Quoted 7 lines
Quoted 1 line
The issue is that there isn't one.
I do not follow. Here is the commit message: "mfd: (max8997) Handle the potential error for
mfd_add_devices". What is missing? It now handles an error for adding mfd devices which was not handled before. It mentions for which chip. What more needs to be written? I am currently lost.
Quoted 4 lines
Please read:
Documentation/SubmittingPatchesSpecifically No2.
I had read that, but as written, I am not sure what more you want to add. Should I replicate the title in the body, pretty much? Please be specific, and write what you would like to see in the body. I will copy/paste it. Currently, I am not sure.
Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
Quoted 1 line
It has a pretty clear commit message.
If you are referencing my comments about the $SUBJECT line, then I have to disagree with you there. It's actually pretty vague, does not describe either the issue or what steps you've taken to rectify it.
Quoted 2 lines
Are you now just
picking nits about "foo:" vs "(foo)" in the short line?That is also an issue. Did you issue the command I sent you:
Quoted 8 lines
Quoted 3 lines
`git log --oneline -- drivers/mfd`Issue it now and see if _anyone_ has _ever_ used your formatting.
Right, so nitpicking about a minor nuance over a somewhat important error handling. Is that blocking the error handling change or you can fix that up yourself? I currently do not have time, nor environment for satisfy this request. I can probably do it the upcoming days.
Quoted 5 lines
It's not my responsibility to fixup your patches for you. It's your job to ensure they are correct on submission. I am happy to review them for you and provide you with my comments, which I have done.
Either fix them up and re-submit or don't. It's no skin off my nose.
Well, maintainers do it from time to time they apply changes when it only needs a minor nitpick modification like this in the commit message, but it is no problem. I am fine the linux kernel not having this error check, at least for now. :-)
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
(quoted diff) +4
-0+ if (ret < 0) { + dev_err(dev, "cannot add mfd cells\n"); + goto err_mfd; + }Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Have you tested this patch on h/w? Did you even compile it?
You must ensure to test your patches before sending to the MLs, it's the very least we expect.
I am not sure what point you are trying to make. Feel free to reject the patch for this error handling.
I'm not rejecting it because of the error handling, I'm rejecting it because it hasn't been tested and it doesn't even compile.
Quoted 8 lines
Quoted 4 lines
It *has* been tested, and it does compile here. I think you just got stuck with the old patch rather than taking any look at new version. May I ask you to do please so? That has been fixed in the new submission before your email.
I have seen the new patch where you fixed it. My comments are solely in reference to this patch though. Testing patches _after_ you've sent them to the MLs is not acceptable.
I am afraid, you are incorrect here. I did test it before. It was a patch sending workflow issue, but even then: why cannot we move on? It had been fixed pretty much within a few seconds, and then I was resending it.
Quoted 2 lines
The $SUBJECT line does not conform to what's expected of MFD commits. The $SUBJECT line is vague and you are missing a commit body.
As written, I am lost what I would need to add to the commit message. Please advise, and I will copy and paste that before resending.
Quoted 1 line
Why have you removed this line?
That is just noise. It is better not to remove it, thanks.
Quoted 2 lines
We're adding devices here, not cells.
"failed to add devices"
That description is not chosen by me. Actually, that is coming from the other mfd drivers, particularly from the other existing MAXIM mfd driver. I would not personally break the consistency there.
Quoted 2 lines
Why is that bad? Cannot you just reply to the "top-post" sentence with dropping all the quotes below if that is what you wish?
Yes, only quote what you're replying to and quote _below_.
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
Please read and inwardly digest:
Documentation/email-clients.txtI have read that, however I still have certain restrictions here which are over the kernel community rules. That should not block a useful contribution in my opinion.
Quoted 5 lines
Quoted 3 lines
Your email client does not prevent you from replying inline, which you've proven by this email. Please abide by the rules if you're going to contribute.
Yes, I can spend more effort with it inconveniently,
Great, thanks.
<snip>
Quoted 9 lines
Quoted 4 lines
Please read:
Documentation/SubmittingPatchesSpecifically No2.
I had read that, but as written, I am not sure what more you want to add. Should I replicate the title in the body, pretty much? Please be specific, and write what you would like to see in the body. I will copy/paste it. Currently, I am not sure.
A good commit for your patch might look like this:
mfd: max8997: Enforce mfd_add_devices() return value check
The original author provided a random return value check which is redundant and seemingly floating. This patch not only relocates the check so it is more clearly associated with the invokation of mfd_add_devices(), but provides a store for the error value. We also print a meaningful message on error before returning.
Quoted 10 lines
Quoted 5 lines
It's not my responsibility to fixup your patches for you. It's your job to ensure they are correct on submission. I am happy to review them for you and provide you with my comments, which I have done.
Either fix them up and re-submit or don't. It's no skin off my nose.
Well, maintainers do it from time to time they apply changes when it only needs a minor nitpick modification like this in the commit message, but it is no problem. I am fine the linux kernel not having this error check, at least for now. :-)
It's better that you do it yourself. If I fixed up everything that was sent to me incorrect a) I'd have no time left and b) they'd never learn.
This is about teaching a man to fish.
Quoted 8 lines
Quoted 2 lines
The $SUBJECT line does not conform to what's expected of MFD commits. The $SUBJECT line is vague and you are missing a commit body.
As written, I am lost what I would need to add to the commit message. Please advise, and I will copy and paste that before resending.
Quoted 1 line
Why have you removed this line?
Quoted 8 lines
That is just noise. It is better not to remove it, thanks.
Quoted 2 lines
We're adding devices here, not cells.
"failed to add devices"That description is not chosen by me. Actually, that is coming from the other mfd drivers, particularly from the other existing MAXIM mfd driver. I would not personally break the consistency there.
Please reply to the patch in question, or else things could get confusing.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog