rtc: at91sam9: include <mach/hardware.h> explicitly
Subsystems (2)
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
The driver needs the symbol AT91_SLOW_CLOCK which is defined in arch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h -> linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h -> linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h -> linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
So better include it explicitly not only because the last link will go away soon.
--- drivers/rtc/rtc-at91sam9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91sam9.c +1 -1
@@ -24,7 +24,7 @@#include <mach/at91_rtt.h> #include <mach/cpu.h> - +#include <mach/hardware.h> /* * This driver uses two configurable hardware resources that live in the
Signature · 1 line
1.8.4.2
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Quoted 11 lines · Uwe Kleine-K??nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>
we should never use this symbol you need to request the clock clk32k
Best Regards,
J.
Quoted 20 lines
--- drivers/rtc/rtc-at91sam9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-at91sam9.c +1
-1@@ -24,7 +24,7 @@#include <mach/at91_rtt.h> #include <mach/cpu.h> - +#include <mach/hardware.h> /* * This driver uses two configurable hardware resources that live in the Signature · 1 line
1.8.4.2
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Hello,
Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines · Uwe Kleine-K??nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.
Quoted 6 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>we should never use this symbol you need to request the clock clk32k
IMHO this should be addressed in another patch. My intent is to get rid of <mach/timex.h>. So I let someone else take this patch opportunity.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
On 15/11/2013 15:55, Uwe Kleine-K?nig :
Quoted 11 lines
Hello,
Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines · Uwe Kleine-K??nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>we should never use this symbol you need to request the clock clk32k
IMHO this should be addressed in another patch. My intent is to get rid of <
mach/timex.h>. So I let someone else take this patch opportunity.
I understand the objective of this patch.
So, in the meantime, you have my:
(if it is not too late, Uwe).
Thanks for addressing that, bye,
Signature · 1 line
Nicolas Ferre
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
In reply to Uwe Kleine-KönigQuoted 11 lines · Uwe Kleine-K?nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Ping. Is this patch ok despite Jean-Christophe's objection?
Best regards
Uwe
Quoted 25 lines
--- drivers/rtc/rtc-at91sam9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-at91sam9.c +1
-1@@ -24,7 +24,7 @@#include <mach/at91_rtt.h> #include <mach/cpu.h> - +#include <mach/hardware.h> /* * This driver uses two configurable hardware resources that live in the Signature · 7 lines
1.8.4.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Quoted 8 lines · Uwe Kleine-K?nig
Quoted 7 lines · Uwe Kleine-K?nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.
Quoted 5 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
Best regards
Uwe
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Hello Andrew,
Quoted 9 lines · Uwe Kleine-K?nig
Quoted 8 lines · Uwe Kleine-K?nig
Quoted 7 lines · Uwe Kleine-K?nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K?nig <[email protected]>Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
This patch is one of the last few that are needed to drop <mach/timex.h> alltogether that I don't have an ack from the respective maintainer yet.
Can you give your ack instead of sending the patch to Linus, then I'd take it with the patch dropping <mach/timex.h> to make it easier to merge.
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Quoted 16 lines · On Tue, 26 Nov 2013 19:36:29 +0100 Uwe Kleine-K__nig…
Hello Andrew,
Quoted 13 lines · Uwe Kleine-K__nig
Quoted 12 lines · Uwe Kleine-K__nig
Quoted 11 lines · Uwe Kleine-K__nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K__nig <[email protected]>
Quoted 8 lines
Quoted 2 lines
Quoted 1 line
Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
This patch is one of the last few that are needed to drop <
mach/timex.h> alltogether that I don't have an ack from the respective maintainer yet.Can you give your ack instead of sending the patch to Linus, then I'd take it with the patch dropping <
mach/timex.h> to make it easier to merge.
ack ;)
I dropped my copy.
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Hello Andrew,
Quoted 17 lines · Andrew Morton
Quoted 16 lines · On Tue, 26 Nov 2013 19:36:29 +0100 Uwe Kleine-K__nig…
Quoted 15 lines · Uwe Kleine-K__nig
Quoted 8 lines · Uwe Kleine-K__nig
Quoted 7 lines · Uwe Kleine-K__nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.Quoted 5 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K__nig <[email protected]>Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
Quoted 8 lines
Quoted 6 lines
This patch is one of the last few that are needed to drop <
mach/timex.h> alltogether that I don't have an ack from the respective maintainer yet.Can you give your ack instead of sending the patch to Linus, then I'd take it with the patch dropping <
mach/timex.h> to make it easier to merge.ack ;)
thanks. There is another rtc change that I didn't receive any feedback for from a maintainer:
rtc: pxa: drop unused #define TIMER_FREQ
. In the meantime I send a pull request asking to ignore that I didn't get any maintainer reply for the rtc changes. Do you think it's sensible to change the entry in MAINTAINERS? Any combination of:
a) drop Alessandro's M: line
b) add you
c) change Status from Maintained to Odd Fixes or Orphan
Quoted 1 line
I dropped my copy.
fine, thanks
I'll wait for some time now before adding your ack to my tree to prevent that you give me an ack for the other change just when I sent a new pull request :-)
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Quoted 27 lines · On Mon, 16 Dec 2013 20:28:16 +0100 Uwe Kleine-K__nig…
Hello Andrew,
Quoted 24 lines · Andrew Morton
Quoted 22 lines · On Tue, 26 Nov 2013 19:36:29 +0100 Uwe Kleine-K__nig…
Quoted 9 lines · Uwe Kleine-K__nig
Quoted 8 lines · Uwe Kleine-K__nig
Quoted 7 lines · Uwe Kleine-K__nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K__nig <[email protected]>Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
This patch is one of the last few that are needed to drop <
mach/timex.h> alltogether that I don't have an ack from the respective maintainer yet.Can you give your ack instead of sending the patch to Linus, then I'd take it with the patch dropping <
mach/timex.h> to make it easier to merge.
Quoted 5 lines
Quoted 1 line
ack ;)
thanks. There is another rtc change that I didn't receive any feedback for from a maintainer:
rtc: pxa: drop unused #define
TIMER_FREQ
ack. Robert Jarzmik also acked that one.
Quoted 7 lines
. In the meantime I send a pull request asking to ignore that I didn't get any maintainer reply for the rtc changes. Do you think it's sensible to change the entry in
MAINTAINERS? Any combination of:a) drop Alessandro's M: line
b) add you
c) change Status from Maintained to Odd Fixes or Orphan
Yeah, I should have a couple hundred MAINTAINERS entries. Instead I just lurk on mailing lists ;)
PATCH 1/1 rtc: at91sam9: include <mach/hardware.h> explicitly
Hello Andrew,
Quoted 29 lines · Andrew Morton
Quoted 27 lines · On Mon, 16 Dec 2013 20:28:16 +0100 Uwe Kleine-K__nig…
Hello Andrew,
Quoted 24 lines · Andrew Morton
Quoted 22 lines · On Tue, 26 Nov 2013 19:36:29 +0100 Uwe Kleine-K__nig…
Quoted 9 lines · Uwe Kleine-K__nig
Quoted 8 lines · Uwe Kleine-K__nig
Quoted 7 lines · Uwe Kleine-K__nig
The driver needs the symbol
AT91_SLOW_CLOCKwhich is defined inarch/arm/mach-at91/include/mach/hardware.h. This file is included implicitly vialinux/module.h->linux/kmod.h->linux/gfp.h->linux/mmzone.h->linux/memory_hotplug.h->linux/notifier.h->linux/srcu.h->linux/workqueue.h->linux/timer.h->linux/ktime.h->linux/jiffies.h->linux/timex.h->mach/timex.h->mach/hardware.h.Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
So better include it explicitly not only because the last link will go away soon.
Signed-off-by Uwe Kleine-K__nig <[email protected]>Ping. Is this patch ok despite Jean-Christophe's objection?
I saw that akpm already took it into his tree.
This patch is one of the last few that are needed to drop <
mach/timex.h> alltogether that I don't have an ack from the respective maintainer yet.Can you give your ack instead of sending the patch to Linus, then I'd take it with the patch dropping <
mach/timex.h> to make it easier to merge.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
ack ;)
thanks. There is another rtc change that I didn't receive any feedback for from a maintainer:
rtc: pxa: drop unused #define
TIMER_FREQack. Robert Jarzmik also acked that one.
Thanks, I saw Robert Jarzmik's ack, but for taking a $subsystem1 patch through the $subsystem2 tree, I like to have an ack of the maintainer of $subsystem1. And in this regard I think yours is better than Robert's (who is the original author of the driver).
Quoted 10 lines
Quoted 7 lines
. In the meantime I send a pull request asking to ignore that I didn't get any maintainer reply for the rtc changes. Do you think it's sensible to change the entry in
MAINTAINERS? Any combination of:a) drop Alessandro's M: line
b) add you
c) change Status from Maintained to Odd Fixes or OrphanYeah, I should have a couple hundred
MAINTAINERSentries. Instead I just lurk on mailing lists ;)
So only a) and c).
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |