Skip to contentSkip to conversation

Makefile: fix the typo error for mrproper

PATCH In review Bo Shen 3 participants 5 messages Dec 16, 2013 – Dec 19, 2013 Kbuild

lore
Share & tools
lore

Bo Shen

author
#0 lore raw

PATCH 1/1 Makefile: fix the typo error for mrproper

Fix the typo error for mrproper from mkproper.

---
In Makefile, there is no object name is mkproper, so I think this is a typo error.

 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 7310c4e..ddbaaf0 100644
@@ -168,7 +168,7 @@ endif
 include $(TOPDIR)/config.mk
 
 # Targets which don't build the source code
-NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
+NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
 
 # Only do the generic board check when actually building, not configuring
 ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Makefile: fix the typo error for mrproper

Quoted 3 lines · Bo Shen

Fix the typo error for mrproper from mkproper.

Adding Masahiro.

Quoted 23 lines

---
In Makefile, there is no object name is mkproper, so I think this is a typo error.

 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 7310c4e..ddbaaf0 100644
@@ -168,7 +168,7 @@ endif
 include $(TOPDIR)/config.mk
 
 # Targets which don't build the source code
-NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
+NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
 
 # Only do the generic board check when actually building, not configuring
 ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
--

1.7.9.5

#2 lore raw

PATCH 1/1 Makefile: fix the typo error for mrproper

Quoted 21 lines · Simon Glass
Quoted 3 lines · Bo Shen

Fix the typo error for mrproper from mkproper.

Adding Masahiro.

Quoted 14 lines

---
In Makefile, there is no object name is mkproper, so I think this is a typo error.

 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +0 -0
index 7310c4e..ddbaaf0 100644
@@ -168,7 +168,7 @@ endif
 include $(TOPDIR)/config.mk
 
Quoted 6 lines

Makefile endif · line 174

Quoted 6 lines
Makefile +1 -1
 # Targets which don't build the source code
-NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
+NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
 
 # Only do the generic board check when actually building, not configuring
 ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)

Note all of this logic came in with fada9e2 which is you, Simon :) But I'm pretty sure this is trivially correct, so I'll take it soon.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131216/bf88d000/attachment.pgp>
#3 lore raw

PATCH 1/1 Makefile: fix the typo error for mrproper

Hi Tom,

Quoted 26 lines · Tom Rini
Quoted 25 lines · Simon Glass
Quoted 3 lines · Bo Shen

Fix the typo error for mrproper from mkproper.

Adding Masahiro.

Quoted 18 lines

---
In Makefile, there is no object name is mkproper, so I think this is a typo error.

 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 7310c4e..ddbaaf0 100644
@@ -168,7 +168,7 @@ endif
 include $(TOPDIR)/config.mk
 
 # Targets which don't build the source code
-NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
+NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
 
Quoted 5 lines
Quoted 2 lines

Makefile endif · line 174

Quoted 2 lines
Makefile +0 -0
 # Only do the generic board check when actually building, not configuring
 ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)

Note all of this logic came in with fada9e2 which is you, Simon :) But I'm pretty sure this is trivially correct, so I'll take it soon.

OK, I see. Yes looks right.

Regards,
Simon

#4 lore raw
In reply to Bo Shen
Quoted 4 lines · Bo Shen

Fix the typo error for mrproper from mkproper.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131219/d4885c5a/attachment.pgp>