Skip to contentSkip to conversation

bonnie: does not support static builds

PATCH New spdawson at gmail.com 2 participants 3 messages Dec 17, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonnie: does not support static builds

From: Simon Dawson <[email protected]>

Fixes autobuild failues such as the following.

http://autobuild.buildroot.net/results/bb9/bb9665a957e4fed25dff3e36bbf105c523dcf0a7/

---
 package/bonnie/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/bonnie/Config.in +3 -2
index 6dbd06d..a4a50f8 100644
@@ -2,11 +2,12 @@ config BR2_PACKAGE_BONNIE
 	bool "bonnie++"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  Filesystem tester
 
 	  http://www.coker.com.au/bonnie++/
 
-comment "bonnie++ needs a toolchain w/ C++"
+comment "bonnie++ needs a toolchain w/ C++, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_INSTALL_LIBSTDCPP	|| BR2_PREFER_STATIC_LIB
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 bonnie: does not support static builds

Simon,

Quoted 20 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

Fixes autobuild failues such as the following.

http://autobuild.buildroot.net/results/bb9/bb9665a957e4fed25dff3e36bbf105c523dcf0a7/

---
 package/bonnie/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/bonnie/Config.in +1 -0
index 6dbd06d..a4a50f8 100644
@@ -2,11 +2,12 @@ config BR2_PACKAGE_BONNIE
 	bool "bonnie++"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB

package/bonnie/Config.in config BR2_PACKAGE_BONNIE · line 13

Quoted 10 lines
package/bonnie/Config.in +2 -2
 	help
 	  Filesystem tester
 
 	  http://www.coker.com.au/bonnie++/
 
-comment "bonnie++ needs a toolchain w/ C++"
+comment "bonnie++ needs a toolchain w/ C++, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_INSTALL_LIBSTDCPP	|| BR2_PREFER_STATIC_LIB

I need to test this specific case, but I don't think this is the correct fix. If you look at the config.log file, I'm pretty sure you will see that configure bails out because libstdc++.a does not exist. This is a problem in the internal toolchain rework I've done, and that I need to have a look at (make sure it generates the static version of libstdc++).

Therefore, I don't think this patch should be applied: bonnie++, by itself, does not require dynamic library.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 bonnie: does not support static builds

Hi Thomas,

Quoted 6 lines · Thomas Petazzoni

I need to test this specific case, but I don't think this is the correct fix. If you look at the config.log file, I'm pretty sure you will see that configure bails out because libstdc++.a does not exist. This is a problem in the internal toolchain rework I've done, and that I need to have a look at (make sure it generates the static version of libstdc++).

Right.

Quoted 2 lines

Therefore, I don't think this patch should be applied: bonnie++, by itself, does not require dynamic library.

Okay; I did wonder, to be honest. Thanks for the feedback.

Simon.