Skip to contentSkip to conversation

evemu: New package. Also adds libevdev.

PATCH New Andreas Naumann 3 participants 3 messages Dec 18, 2013 – Dec 19, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 evemu: New package. Also adds libevdev.

---

evemu is also available in version v1.2.0, but crosscompile for arm didnt work. Using v1.0.10 which does compile and work (and is the current Ubuntu version).

 package/Config.in            |  2 ++
 package/evemu/Config.in      |  7 +++++++
 package/evemu/evemu.mk       | 15 +++++++++++++++
 package/libevdev/Config.in   |  6 ++++++
 package/libevdev/libevdev.mk | 15 +++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/evemu/Config.in
 create mode 100644 package/evemu/evemu.mk
 create mode 100644 package/libevdev/Config.in
 create mode 100644 package/libevdev/libevdev.mk
package/Config.in +2 -0
index 3429c0e..87fda51 100644
@@ -240,6 +240,7 @@ source "package/dvb-apps/Config.in"
 source "package/dvbsnoop/Config.in"
 source "package/eeprog/Config.in"
 source "package/evtest/Config.in"
+source "package/evemu/Config.in"
 source "package/fan-ctrl/Config.in"
 source "package/flashrom/Config.in"
 source "package/fconfig/Config.in"
@@ -602,6 +603,7 @@ source "package/libdaemon/Config.in"
 source "package/libelf/Config.in"
 source "package/libevent/Config.in"
 source "package/libev/Config.in"
+source "package/libevdev/Config.in"
 source "package/libffi/Config.in"
 source "package/libglib2/Config.in"
 source "package/libical/Config.in"
package/evemu/Config.in new file +7 -0
new file mode 100644
index 0000000..07b7174
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_EVEMU
+	bool "evemu"
+	select BR2_PACKAGE_LIBEVDEV
+	help
+	  evemu records and replays device descriptions and events
+
+	  http://www.freedesktop.org/wiki/Evemu/
package/evemu/evemu.mk new file +15 -0
new file mode 100644
index 0000000..923d205
@@ -0,0 +1,15 @@
+################################################################################
+#
+# evemu
+#
+################################################################################
+
+EVEMU_VERSION = 1.0.10
+EVEMU_SOURCE = evemu-$(EVEMU_VERSION).tar.gz
+EVEMU_SITE = http://cgit.freedesktop.org/evemu/snapshot
+
+EVEMU_AUTORECONF = YES
+EVEMU_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
+
package/libevdev/Config.in new file +6 -0
new file mode 100644
index 0000000..91dd9db
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBEVDEV
+	bool "libevdev"
+	help
+	  libevdev is a wrapper library for evdev devices
+
+	  http://freedesktop.org/wiki/Software/libevdev/
package/libevdev/libevdev.mk new file +15 -0
new file mode 100644
index 0000000..12b6b11
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libevdev
+#
+################################################################################
+
+LIBEVDEV_VERSION = 0.5
+LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.gz
+LIBEVDEV_SITE = http://cgit.freedesktop.org/libevdev/snapshot
+
+LIBEVDEV_AUTORECONF = YES
+LIBEVDEV_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
+
Signature · 1 line
1.8.4.1
#1 lore raw

PATCH 1/1 evemu: New package. Also adds libevdev.

Andreas, All,

On 2013-12-18 15:01 +0100, Andreas Naumann spake thusly:

Quoted 4 lines

---

evemu is also available in version v1.2.0, but crosscompile for arm didnt work. Using v1.0.10 which does compile and work (and is the current Ubuntu version).

Please, provide two patches: one for libevdev, and a second one for evemu.

Quoted 16 lines
 package/Config.in            |  2 ++
 package/evemu/Config.in      |  7 +++++++
 package/evemu/evemu.mk       | 15 +++++++++++++++
 package/libevdev/Config.in   |  6 ++++++
 package/libevdev/libevdev.mk | 15 +++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/evemu/Config.in
 create mode 100644 package/evemu/evemu.mk
 create mode 100644 package/libevdev/Config.in
 create mode 100644 package/libevdev/libevdev.mk
package/Config.in +0 -0
index 3429c0e..87fda51 100644

package/Config.in source "package/dvb-apps/Config.in" · line 243

Quoted 4 lines
package/Config.in +1 -0
@@ -240,6 +240,7 @@ source "package/dvb-apps/Config.in"
 source "package/dvbsnoop/Config.in"
 source "package/eeprog/Config.in"
 source "package/evtest/Config.in"
+source "package/evemu/Config.in"o

Alphabetical order, please: evemu should come before evtest.

[--SNIP--]

Quoted 6 lines
package/evemu/evemu.mk new file +0 -0
new file mode 100644
index 0000000..923d205

package/evemu/evemu.mk line 8

Quoted 8 lines
package/evemu/evemu.mk new file +8 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# evemu
+#
+################################################################################
+
+EVEMU_VERSION = 1.0.10
+EVEMU_SOURCE = evemu-$(EVEMU_VERSION).tar.gz

This _SOURCE is not needed, that's the default.

package/evemu/evemu.mk line 11

Quoted 3 lines
package/evemu/evemu.mk new file +3 -0
+EVEMU_SITE = http://cgit.freedesktop.org/evemu/snapshot
+
+EVEMU_AUTORECONF = YES

Can you add a comment on why _AUTORECONF is required?

package/evemu/evemu.mk line 12

Quoted 1 line
package/evemu/evemu.mk new file +1 -0
+EVEMU_INSTALL_STAGING = YES

Why do we need to install it to staging? It's does not look like a library, so it should not be needed in staging. Otherwise, please add a comment on why this is needed, since it is not obvious.

package/evemu/evemu.mk line 14

Quoted 2 lines
package/evemu/evemu.mk new file +2 -0
+$(eval $(autotools-package))
+

Trailing empty line.

[--SNIP--]

Quoted 6 lines
package/libevdev/libevdev.mk new file +0 -0
new file mode 100644
index 0000000..12b6b11

package/libevdev/libevdev.mk line 8

Quoted 8 lines
package/libevdev/libevdev.mk new file +8 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libevdev
+#
+################################################################################
+
+LIBEVDEV_VERSION = 0.5
+LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.gz

Ditto, this _SOURCE is not needed, since it's the default.

package/libevdev/libevdev.mk line 11

Quoted 3 lines
package/libevdev/libevdev.mk new file +3 -0
+LIBEVDEV_SITE = http://cgit.freedesktop.org/libevdev/snapshot
+
+LIBEVDEV_AUTORECONF = YES

Ditto: explain why _AUTORECONF is needed.

package/libevdev/libevdev.mk line 12

Quoted 1 line
package/libevdev/libevdev.mk new file +1 -0
+LIBEVDEV_INSTALL_STAGING = YES

That one looks logicial sicne it's a library, so needs no explanations. ;-)

package/libevdev/libevdev.mk line 14

Quoted 2 lines
package/libevdev/libevdev.mk new file +2 -0
+$(eval $(autotools-package))
+

Trailing empty line.

Except for those minor nitpicks, it all Looks Good To Me (TM).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 evemu: New package. Also adds libevdev.

Yann, Andreas,

Yann's comments are good, I'm just going to add one more below.

Quoted 1 line · Yann E. MORIN

Except for those minor nitpicks, it all Looks Good To Me (TM).

Both packages lack the <pkg>_LICENSE and <pkg>_LICENSE_FILES informations. See the Buildroot manual for details about these variables.

Also, the libevdev configure.ac script uses PKG_CHECK_MODULES, so the package should depend on host-pkgconf. Same thing for evemu.

Finally, your packages don't have any toolchain dependency. This might be correct, but it would be good if you could test the build of both of those packages with the following initial configurations:

http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config

If it builds fine with both of those toolchain configuration, then you're good to go. If not, then it means that there are some missing toolchain dependencies.

Best regards,

Thomas Petazzoni

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com