Skip to contentSkip to conversation

drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c

PATCH Applied Rashika Kheria 3 participants 3 messages Dec 18, 2013 – Jan 2, 2014 Thermal

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c

Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c because it is not used outside this file.

This eliminates the following warning in x86_pkg_temp_thermal.c:
drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]

---
 drivers/thermal/x86_pkg_temp_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/x86_pkg_temp_thermal.c +1 -1
index 7722cb9..972e1c7 100644
@@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
 	return 0;
 }
 
-int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
 							unsigned long temp)
 {
 	u32 l, h;
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rashika Kheria

Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c because it is not used outside this file.

This eliminates the following warning in x86_pkg_temp_thermal.c:
drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/thermal/x86_pkg_temp_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/x86_pkg_temp_thermal.c +1 -1
index 7722cb9..972e1c7 100644
@@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
 	return 0;
 }
 
-int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
 							unsigned long temp)
 {
 	u32 l, h;
Signature · 1 line
1.7.9.5
reviewer Applied
#2 lore raw
Quoted 11 lines · On Wed, 2013-12-18 at 10:40 -0800, [email protected] wrote:
Quoted 7 lines · Rashika Kheria

Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c because it is not used outside this file.

This eliminates the following warning in x86_pkg_temp_thermal.c:
drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]

applied.

thanks,
rui

Quoted 23 lines
Quoted 19 lines
 drivers/thermal/x86_pkg_temp_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/x86_pkg_temp_thermal.c +1 -1
index 7722cb9..972e1c7 100644
@@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
 	return 0;
 }
 
-int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
 							unsigned long temp)
 {
 	u32 l, h;
Signature · 1 line
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html