Skip to contentSkip to conversation

arm: omap3: Fix beagleboard SPL boot hangup (GPIO clocks not enabled)

PATCH In review Stefan Roese 3 participants 3 messages Dec 17, 2013 – Dec 18, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: omap3: Fix beagleboard SPL boot hangup (GPIO clocks not enabled)

Patch f33b9bd3
[arm: omap3: Enable clocks for peripherals only if they are used] breaks SPL booting on Beagleboard. Since some gpio input's are read to detect the board revision. But with this patch above, the clocks to the GPIO subsystems are not enabled per default any more. The GPIO banks need to be configured specifically now.

Cc Tom Rini <[email protected]>
Cc Michael Trimarchi <[email protected]>
---
 include/configs/omap3_beagle.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/omap3_beagle.h +3 -0
index 3acb854..1b566c0 100644
@@ -123,6 +123,9 @@
 #define CONFIG_USB_ETHER_SMSC95XX
 #define CONFIG_USB_ETHER_ASIX
 
+/* GPIO banks */
+#define CONFIG_OMAP3_GPIO_5		/* GPIO128..159 is in GPIO bank 5 */
+#define CONFIG_OMAP3_GPIO_6		/* GPIO160..191 is in GPIO bank 6 */
 
 /* commands to include */
 #include <config_cmd_default.h>
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 arm: omap3: Fix beagleboard SPL boot hangup (GPIO clocks not enabled)

Hi Stefan

Quoted 29 lines · Stefan Roese

Patch f33b9bd3
[arm: omap3: Enable clocks for peripherals only if they are used] breaks SPL booting on Beagleboard. Since some gpio input's are read to detect the board revision. But with this patch above, the clocks to the GPIO subsystems are not enabled per default any more. The GPIO banks need to be configured specifically now.

Cc Tom Rini <[email protected]>
Cc Michael Trimarchi <[email protected]>
---
 include/configs/omap3_beagle.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/omap3_beagle.h +3 -1
index 3acb854..1b566c0 100644
@@ -123,6 +123,9 @@
 #define CONFIG_USB_ETHER_SMSC95XX
 #define CONFIG_USB_ETHER_ASIX
 
+/* GPIO banks */
+#define CONFIG_OMAP3_GPIO_5            /* GPIO128..159 is in GPIO bank 5 */
+#define CONFIG_OMAP3_GPIO_6            /* GPIO160..191 is in GPIO bank 6 */
 
 /* commands to include */
 #include <config_cmd_default.h>
--
Quoted 2 lines

1.8.4.5

Ok, this is one of the problem that we can have with the new patch.

Thank you

Michael

#2 lore raw
In reply to Stefan Roese
Quoted 10 lines · Stefan Roese

Patch f33b9bd3
[arm: omap3: Enable clocks for peripherals only if they are used] breaks SPL booting on Beagleboard. Since some gpio input's are read to detect the board revision. But with this patch above, the clocks to the GPIO subsystems are not enabled per default any more. The GPIO banks need to be configured specifically now.

Cc Tom Rini <[email protected]>
Cc Michael Trimarchi <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131218/ecebdabb/attachment.pgp>