Skip to contentSkip to conversation

misc: Reserve minor for VFIO

PATCH In review Alex Williamson 5 participants 8 messages Dec 18, 2013 – Dec 20, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 misc: Reserve minor for VFIO

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)
Documentation/devices.txt +1 -0
index 80b7241..10378cc 100644
@@ -409,6 +409,7 @@ Your cooperation is appreciated.
 		193 = /dev/d7s		SPARC 7-segment display
 		194 = /dev/zkshim	Zero-Knowledge network shim control
 		195 = /dev/elographics/e2201	Elographics touchscreen E271-2201
+		196 = /dev/vfio/vfio	VFIO userspace driver interface
 		198 = /dev/sexec	Signed executable interface
 		199 = /dev/scanners/cuecat :CueCat barcode scanner
 		200 = /dev/net/tun	TAP/TUN network device
include/linux/miscdevice.h +1 -0
index f7eaf2d..3737f72 100644
@@ -30,6 +30,7 @@
 #define STORE_QUEUE_MINOR	155
 #define I2O_MINOR		166
 #define MICROCODE_MINOR		184
+#define VFIO_MINOR		196
 #define TUN_MINOR		200
 #define CUSE_MINOR		203
 #define MWAVE_MINOR		219	/* ACP/Mwave Modem */
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 26 lines · Alex Williamson

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

Quoted 3 lines
 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)

Feel free to take this through your tree.

thanks,

greg k-h

#2 lore raw
Quoted 27 lines · Greg KH
Quoted 26 lines · Alex Williamson

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

Quoted 7 lines
Quoted 3 lines
 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)

Feel free to take this through your tree.

Thanks!

#3 lore raw
In reply to Greg KH
Quoted 27 lines · Greg KH
Quoted 26 lines · Alex Williamson

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

Quoted 6 lines
Quoted 3 lines
 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)

I think Alan Cox was the last person to man <[email protected]>... Alan, are you still doing that? (Otherwise patching the file in the Linux kernel tree seems eminently sensible... there really isn't any need to reserve numbers for out-of-tree drivers anymore. Just another perk of being in-tree.)

-hpa

#4 lore raw
Quoted 5 lines

I think Alan Cox was the last person to man <[email protected]>... Alan, are you still doing that? (Otherwise patching the file in the Linux kernel tree seems eminently sensible... there really isn't any need to reserve numbers for out-of-tree drivers anymore. Just another perk of being in-tree.)

I am sort of but the mail alias hasn't worked for a long time afaik.

Quoted 1 line

From the records I have 196 was never issued to anything in tree or

mainstream in recent history so lets make it official ?

#5 lore raw
Quoted 11 lines · One Thousand Gnomes
Quoted 5 lines

I think Alan Cox was the last person to man <[email protected]>... Alan, are you still doing that? (Otherwise patching the file in the Linux kernel tree seems eminently sensible... there really isn't any need to reserve numbers for out-of-tree drivers anymore. Just another perk of being in-tree.)

I am sort of but the mail alias hasn't worked for a long time afaik.

From the records I have 196 was never issued to anything in tree or mainstream in recent history so lets make it official ?

I wonder if I have the RCS file from way back when...

-hpa

#6 lore raw
In reply to H. Peter Anvin
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Greg KH
Quoted 8 lines · Alex Williamson

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Why not have libvirt or systemctl try to load vfio first? If it does not work it would error out.

Or perhaps make the loading of modules in /dev/vfio automatic? I thought it was based on the name?

Quoted 39 lines
Quoted 18 lines
Quoted 18 lines

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

Quoted 6 lines
Quoted 3 lines
 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)

I think Alan Cox was the last person to man <[email protected]>... Alan, are you still doing that? (Otherwise patching the file in the Linux kernel tree seems eminently sensible... there really isn't any need to reserve numbers for out-of-tree drivers anymore. Just another perk of being in-tree.)

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#7 lore raw
Quoted 12 lines · Konrad Rzeszutek Wilk
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Greg KH
Quoted 8 lines · Alex Williamson

VFIO currently allocates it's own dynamic chardev range, reserving the first minor for the control part of the interface (/dev/vfio/vfio) and the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it doesn't support auto loading. For instance when libvirt checks for VFIO support it looks for /dev/vfio/vfio, which currently doesn't exist unless the vfio module is loaded. By converting the control device to a misc driver and reserving a static minor, we can enable auto loading.

Quoted 2 lines

Why not have libvirt or systemctl try to load vfio first? If it does not work it would error out.

Kay Sievers made a pass through the kernel a while back adding devname support to a number of drivers to "remove a bunch of pretty useless init scripts and modprobes from init scripts". So I believe this to be the preferred approach for systemd. Besides, the init scripts don't know if the feature is actually being used, so it's a waste to blindly load the module because you've installed qemu or libvirt.

libvirt also has little interest in loading the module themselves and frowned on the approach of them loading the module when I proposed it. VFIO also has scope beyond libvirt, so solving it there only addresses one use case, granted it's currently the most prevalent use case of VFIO.

A number of other drivers have adopted the devname model for auto-loading, kvm, vhost, fuse, dm, tun, ppp, etc, so why not use it here too?

Quoted 2 lines

Or perhaps make the loading of modules in /dev/vfio automatic? I thought it was based on the name?

I don't think I understand the question, this is an effort to do that for /dev/vfio/vfio. I don't wish to force this module to be statically loaded into the kernel, it's only used by a small fraction of users. To support autoloading udev needs to know a static major/minor for the device entry. It cannot be done with only a name. I posted a companion patch to this last week that converts VFIO's control interface to a misc driver with this static minor to accomplish that. Thanks,

Alex

Quoted 39 lines
Quoted 39 lines
Quoted 18 lines
Quoted 18 lines

Reserving the minor is a prerequist to that conversion. Minor 196 is unused by anything currently in the kernel.

---

v2: Plea for ack edition

As Alan suspected, there's been no response from [email protected], so there's probably nobody monitoring it anymore. I've done due diligence looking at all the callers of misc_register() in linux-next and cannot find any conflicts with minor 196. If anyone wants to toss me an ack or sign-off I'll be happy to bring this in through my vfio tree, otherwise I'd appreciate if someone wants to take it directly. Thanks!

Quoted 6 lines
Quoted 3 lines
 Documentation/devices.txt  |    1 +
 include/linux/miscdevice.h |    1 +
 2 files changed, 2 insertions(+)

I think Alan Cox was the last person to man <[email protected]>... Alan, are you still doing that? (Otherwise patching the file in the Linux kernel tree seems eminently sensible... there really isn't any need to reserve numbers for out-of-tree drivers anymore. Just another perk of being in-tree.)

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/