usb: musb: Remove USB_GADGET driver dependency
Subsystems (2)
PATCH 1/1 usb: musb: Remove USB_GADGET driver dependency
This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing the dependency.
Tested on a Beaglebone black (AM335x) using a regular USB mass storage device.
--- drivers/usb/musb/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/usb/musb/Kconfig +0 -1
@@ -6,7 +6,6 @@ # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller config USB_MUSB_HDRC tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' - depends on USB_GADGET help Say Y here if your system has a dual role high speed USB controller based on the Mentor Graphics silicon IP. Then
Signature · 1 line
1.8.1.5
PATCH 1/1 usb: musb: Remove USB_GADGET driver dependency
Quoted 17 lines · Ezequiel Garcia
This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to
USB_GADGET. Fix this by removing the dependency.Tested on a Beaglebone black (AM335x) using a regular USB mass storage device.
Signed-off-by Ezequiel Garcia <[email protected]>--- drivers/usb/musb/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/usb/musb/Kconfig +0
-0
drivers/usb/musb/Kconfig line 9
Quoted 4 lines
drivers/usb/musb/Kconfig +0
-1@@ -6,7 +6,6 @@ # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller config USB_MUSB_HDRC tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' - depends on USB_GADGET
the correct patch would be to turn this into (USB || USB_GADGET) and fix the mode selection just like dwc3 is doing.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131220/cb68bbdc/attachment.sig>
PATCH 1/1 usb: musb: Remove USB_GADGET driver dependency
Quoted 13 lines · Felipe Balbi
Quoted 12 lines · Ezequiel Garcia
This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to
USB_GADGET. Fix this by removing the dependency.Tested on a Beaglebone black (AM335x) using a regular USB mass storage device.
Signed-off-by Ezequiel Garcia <[email protected]>--- drivers/usb/musb/Kconfig | 1 - 1 file changed, 1 deletion(-)
Quoted 13 lines
drivers/usb/musb/Kconfig line 9
Quoted 9 lines
drivers/usb/musb/Kconfig +0
-1@@ -6,7 +6,6 @@ # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller config USB_MUSB_HDRC tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' - depends on USB_GADGETthe correct patch would be to turn this into (USB ||
USB_GADGET) and fix the mode selection just like dwc3 is doing.
Ah, I see now. Let me prepare a v2 then.
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com