Skip to contentSkip to conversation

gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

PATCH New Thomas De Schampheleire 4 participants 6 messages Dec 19, 2013 – Dec 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

---
 package/gstreamer/gst-plugins-good/Config.in |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Note: I don't understand why kconfig does not check/warn on this...

package/gstreamer/gst-plugins-good/Config.in +1 -1
@@ -214,7 +214,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUG
 	select BR2_PACKAGE_LIBSOUP
 
 comment "souphttpsrc needs a toolchain w/ wchar, threads"
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREAD
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_SPEEX
 	bool "speex"
#2 lore raw

PATCH 1/1 gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

In reply to Thomas De Schampheleire

Hello Yann,

package/gstreamer/gst-plugins-good/Config.in config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUG · line 217

Quoted 3 lines · Thomas De Schampheleire

comment "souphttpsrc needs a toolchain w/ wchar, threads"

package/gstreamer/gst-plugins-good/Config.in +1 -1
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREAD
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Do you know if there is a way of making kconfig complain loudly if there is a reference to an undefined symbol?

I know of only one occurrence in Buildroot where we rely on a non-existing symbol: BR2_BROKEN. But we could just as well define this symbol to be always false.

Having such a check would help ensuring we don't make typos on symbol names.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

Thomas, All,

On 2013-12-20 09:50 +0100, Thomas Petazzoni spake thusly:

Quoted 8 lines · Thomas De Schampheleire

package/gstreamer/gst-plugins-good/Config.in config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUG · line 217

Quoted 4 lines

comment "souphttpsrc needs a toolchain w/ wchar, threads"

package/gstreamer/gst-plugins-good/Config.in +1 -1
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREAD
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Do you know if there is a way of making kconfig complain loudly if there is a reference to an undefined symbol?

No, this is not even a warning.

When Kconfig parsess a 'depends on' line, if the symbol does not exist yet, it is added to the list of symbols, in case it is defined later on.

But then there is no way to know if a symbol was added because there was a corresponding 'config' (or 'menuconfig' or 'choice') entry in any of the Config.in files, or because it was added due to it being listed in a 'depends on' (or a 'select').

We can't even rely on the symbol having no type, since it is valid for a symbol to have no type (can't recall off-the-top-of-my-head what case it was, but it is valid in the Kconfig grammar).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

Dear Yann E. MORIN,

Quoted 8 lines · Yann E. MORIN
Quoted 2 lines

Do you know if there is a way of making kconfig complain loudly if there is a reference to an undefined symbol?

No, this is not even a warning.

When Kconfig parsess a 'depends on' line, if the symbol does not exist yet, it is added to the list of symbols, in case it is defined later on.

Ok.

Quoted 4 lines

But then there is no way to know if a symbol was added because there was a corresponding 'config' (or 'menuconfig' or 'choice') entry in any of the Config.in files, or because it was added due to it being listed in a 'depends on' (or a 'select').

Can't we add this information? When you find a symbol, if it's through a depends on or a select, you store the symbol, but mark it as "referenced". When you find a symbol that is really defined through config/menuconfig/choice, you store the symbol and mark it as "defined" (or changed from "referenced" to "defined" if the symbol had already been found). And then, at the end of the parsing, if there are some remaining symbols marked "referenced", whose state has not been changed to "defined", you warn about them.

Am I dreaming too much about kconfig ? :-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 8 lines

Can't we add this information? When you find a symbol, if it's through a depends on or a select, you store the symbol, but mark it as "referenced". When you find a symbol that is really defined through config/menuconfig/choice, you store the symbol and mark it as "defined" (or changed from "referenced" to "defined" if the symbol had already been found). And then, at the end of the parsing, if there are some remaining symbols marked "referenced", whose state has not been changed to "defined", you warn about them.

I was thinking something like that as well. We might not be able to tell the user where the symbol was referenced, but we can atleast warn that it wasn't found.

Signature · 1 line
Bye, Peter Korsgaard